From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id A02D04C24A
for <ffmpegdev@gitmailbox.com>; Wed, 2 Apr 2025 18:29:59 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3DD28689F44;
Wed, 2 Apr 2025 21:29:56 +0300 (EEST)
Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com
[209.85.160.51])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ACE406898A6
for <ffmpeg-devel@ffmpeg.org>; Wed, 2 Apr 2025 21:29:49 +0300 (EEST)
Received: by mail-oa1-f51.google.com with SMTP id
586e51a60fabf-2c769da02b0so12117fac.3
for <ffmpeg-devel@ffmpeg.org>; Wed, 02 Apr 2025 11:29:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1743618588; x=1744223388; darn=ffmpeg.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=FWEduU5NjHAzwCzaLC12xWDuyjwU2pqU+Ojhzea68ow=;
b=iE5fiGfACE+66vRnTQNJkEh3dG+/1Rzx5+Ol6oA/Z+AaW25uCMo7UcU5hvAb/w1Mxx
knca6/b7Y+7SBVMk4pDrNGF6qec1IwAqpBLWlyV1/Y36n+bIT//ENhA7gNfZU0m17Nt+
G3yHbOqPRwdbpEbrn3QTPxOfDRemrKYI18YJUSlMf+XcAlVLwWXFbhT1nG9UdcJUDsqx
9s2yQehFLbObg2DV6eNvFeuwUp+ov646Qifyxqo/pgcOMmajCHM3QkkwHhWa9G49TqBP
dWR6wy9XwV+89b8LAbTOO0u9pkeu0sz430AEHI/Sna09TuyEGTX1piNRaNOUpMFBje+5
PxVA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1743618588; x=1744223388;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=FWEduU5NjHAzwCzaLC12xWDuyjwU2pqU+Ojhzea68ow=;
b=HYCjWZxV7MVLFtxUbjSoGDUQwuyVy0XDocrbHdVNOwokWhazMgibUfTHHh7sUgfRGX
wCmNoF2kEMnlkQufLQL6hRwOuT1OXjctfBOM1J8cTU8EWeBX3tpvYB1iYYZpBo00wjd7
Gvl0YlOq37NC/8Hcya9EMXffNuKBKSac43hlzgyUjltWJiyaK7dR7K1DNgmwDqiALr+A
+whSvwz46+MkToQEQOc3g7f04HBZb86U3761tTs0CaEVK+vZBl766dCc0Hmj6/bPQWTI
Hy1tpmg8LtXcW0ZgLQ/9cIawLZKf23LryhDhMI0Fkvgu55/BhZ/9GP8tkfcJytx1iI5Y
dcFw==
X-Gm-Message-State: AOJu0YxWYFcCRPDQzNAicCFyaRZ2Jj4Ey5NP0IY2MmYkjzkE3giqsKD6
q4Ifm3PjHM67aKCgui/Y96YU85/w0um3uOvjWwsyIrYwpGTn6Cr8QqwpSf/Q
X-Gm-Gg: ASbGncuknhOZx52M8V1mIB3PrXu5IMvvvqorvm7MXo0OcZ8oqEdKgEximUPBAetPZHv
IaFjdCtYg5fzXRR8VHYSOkUjajGPcYKGltkz5XW8dc9KB3VAOMZArCIu5Ggw1RIRJTVfbDjwXIa
JIXXtqEpGHwlajQPSe/c/JswMLQfz5uWE1hPzuezXgbzFQpOc6rpJiKuBPagy2L4EH5Ksv+hj/T
kxiSexEugkLpXs8gpZ8XUF2iHQTPe1XJMKOwshOhIh+QMt5tTKxfV4MbA7aRSDHRt3wGRq6QLf0
teSa21vDBVKRDLBhnBVCteJfAqzcMAZThYdQl37A8LyuPYZ2yUGJXkwjstLMpZbnqZowyOTKgJZ
39535u9UJF4CJ
X-Google-Smtp-Source: AGHT+IFq61M8JTxA18kTkyPbuB29hM33pmKLTO9DOnfz7EcFq7lCvcTvj9m9Isz9ViYmFeEJwfMIEQ==
X-Received: by 2002:a05:6871:a103:b0:2c2:5852:72e9 with SMTP id
586e51a60fabf-2cbcf4198c9mr9909562fac.1.1743618587766;
Wed, 02 Apr 2025 11:29:47 -0700 (PDT)
Received: from mac.lan (ip72-211-125-114.no.no.cox.net. [72.211.125.114])
by smtp.gmail.com with ESMTPSA id
46e09a7af769-72c58267f54sm2349862a34.55.2025.04.02.11.29.47
(version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);
Wed, 02 Apr 2025 11:29:47 -0700 (PDT)
From: Romain Beauxis <romain.beauxis@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Date: Wed, 2 Apr 2025 13:29:33 -0500
Message-Id: <20250402182940.29726-2-romain.beauxis@gmail.com>
X-Mailer: git-send-email 2.39.5 (Apple Git-154)
In-Reply-To: <20250402182940.29726-1-romain.beauxis@gmail.com>
References: <20250402182940.29726-1-romain.beauxis@gmail.com>
MIME-Version: 1.0
Subject: [FFmpeg-devel] [PATCH v10 1/8] libavcodec/decode.c: intercept
`AV_PKT_DATA_METADATA_UPDATE` packet extra data,
attach them to the next decoded frame with the same PTS.
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Romain Beauxis <romain.beauxis@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250402182940.29726-2-romain.beauxis@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
---
libavcodec/decode.c | 130 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 130 insertions(+)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index fca0c7ff58..b754ea13b6 100644
--- a/libavcodec/decode.c
+++ b/libavcodec/decode.c
@@ -39,6 +39,7 @@
#include "libavutil/mastering_display_metadata.h"
#include "libavutil/mem.h"
#include "libavutil/stereo3d.h"
+#include "libavutil/tree.h"
#include "avcodec.h"
#include "avcodec_internal.h"
@@ -97,8 +98,114 @@ typedef struct DecodeContext {
int lcevc_frame;
int width;
int height;
+
+ struct AVTreeNode *pending_metadata;
} DecodeContext;
+typedef struct PendingMetadata {
+ int64_t pts;
+ uint8_t *data;
+ size_t size;
+} PendingMetadata;
+
+static int compare_pending_metadata(const void *left, const void *right)
+{
+ PendingMetadata *left_packet = (PendingMetadata *)left;
+ PendingMetadata *right_packet = (PendingMetadata *)right;
+
+ if (left_packet->pts == right_packet->pts)
+ return 0;
+ if (left_packet->pts < right_packet->pts)
+ return -1;
+ return 1;
+}
+
+static int insert_pending_metadata(struct AVTreeNode **pending_metadata,
+ int64_t pts, const uint8_t *data,
+ size_t size)
+{
+ struct AVTreeNode *next = NULL;
+ PendingMetadata *pending = NULL;
+ PendingMetadata *ret;
+
+ next = av_tree_node_alloc();
+ if (!next)
+ goto fail;
+
+ pending = av_malloc(sizeof(PendingMetadata));
+ if (!pending)
+ goto fail;
+
+ pending->pts = pts;
+ pending->data = av_malloc(size);
+ pending->size = size;
+
+ if (!pending->data)
+ goto fail;
+
+ memcpy(pending->data, data, size);
+
+ ret = av_tree_insert(pending_metadata, pending, compare_pending_metadata,
+ &next);
+
+ // If node alrady exist, we update with the latest value.
+ if (ret && ret != pending) {
+ av_free(ret->data);
+ ret->data = pending->data;
+ ret->size = pending->size;
+ av_free(next);
+ av_free(pending);
+ }
+
+ return 0;
+
+fail:
+ if (pending && pending->data)
+ av_free(pending->data);
+ av_free(pending);
+ av_free(next);
+ return AVERROR(ENOMEM);
+}
+
+static void remove_pending_metadata(struct AVTreeNode **pending_metadata,
+ PendingMetadata *pending)
+{
+ struct AVTreeNode *next = NULL;
+
+ av_tree_insert(pending_metadata, pending, compare_pending_metadata,
+ &next);
+
+ av_free(pending->data);
+ av_free(pending);
+ av_free(next);
+}
+
+static int free_pending_entry(void *opaque, void *pending)
+{
+ av_free(((PendingMetadata *)pending)->data);
+ av_free(pending);
+ return 0;
+}
+
+static void free_pending_metadata(struct AVTreeNode **pending_metadata)
+{
+ av_tree_enumerate(*pending_metadata, NULL, NULL, free_pending_entry);
+
+ av_tree_destroy(*pending_metadata);
+ *pending_metadata = NULL;
+}
+
+static PendingMetadata *find_pending_metadata(
+ struct AVTreeNode *pending_metadata, int64_t pts)
+{
+ PendingMetadata pending;
+
+ pending.pts = pts;
+
+ return av_tree_find(pending_metadata, &pending, compare_pending_metadata,
+ NULL);
+}
+
static DecodeContext *decode_ctx(AVCodecInternal *avci)
{
return (DecodeContext *)avci;
@@ -702,6 +809,8 @@ int attribute_align_arg avcodec_send_packet(AVCodecContext *avctx, const AVPacke
{
AVCodecInternal *avci = avctx->internal;
DecodeContext *dc = decode_ctx(avci);
+ const uint8_t *side_metadata;
+ size_t size;
int ret;
if (!avcodec_is_open(avctx) || !av_codec_is_decoder(avctx->codec))
@@ -719,6 +828,14 @@ int attribute_align_arg avcodec_send_packet(AVCodecContext *avctx, const AVPacke
ret = av_packet_ref(avci->buffer_pkt, avpkt);
if (ret < 0)
return ret;
+
+ side_metadata = av_packet_get_side_data(avpkt, AV_PKT_DATA_METADATA_UPDATE, &size);
+ if (avpkt->pts != AV_NOPTS_VALUE && side_metadata) {
+ ret = insert_pending_metadata(&dc->pending_metadata, avpkt->pts,
+ side_metadata, size);
+ if (ret < 0)
+ return ret;
+ }
} else
dc->draining_started = 1;
@@ -788,6 +905,8 @@ fail:
int ff_decode_receive_frame(AVCodecContext *avctx, AVFrame *frame)
{
AVCodecInternal *avci = avctx->internal;
+ DecodeContext *dc = decode_ctx(avci);
+ PendingMetadata *pending;
int ret;
if (avci->buffer_frame->buf[0]) {
@@ -810,6 +929,16 @@ int ff_decode_receive_frame(AVCodecContext *avctx, AVFrame *frame)
avctx->frame_num++;
+ if (frame->pts != AV_NOPTS_VALUE) {
+ pending = find_pending_metadata(dc->pending_metadata, frame->pts);
+ if (pending) {
+ ret = av_packet_unpack_dictionary(pending->data, pending->size,
+ &frame->metadata);
+ remove_pending_metadata(&dc->pending_metadata, pending);
+ if (ret) goto fail;
+ }
+ }
+
return 0;
fail:
av_frame_unref(frame);
@@ -2220,4 +2349,5 @@ void ff_decode_internal_uninit(AVCodecContext *avctx)
DecodeContext *dc = decode_ctx(avci);
av_refstruct_unref(&dc->lcevc);
+ free_pending_metadata(&dc->pending_metadata);
}
--
2.39.5 (Apple Git-154)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".