From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id EB1B74BEE9 for <ffmpegdev@gitmailbox.com>; Mon, 31 Mar 2025 13:44:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A0697687CB7; Mon, 31 Mar 2025 16:44:45 +0300 (EEST) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6187B6879D9 for <ffmpeg-devel@ffmpeg.org>; Mon, 31 Mar 2025 16:44:39 +0300 (EEST) Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-399737f4fa4so2198693f8f.0 for <ffmpeg-devel@ffmpeg.org>; Mon, 31 Mar 2025 06:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743428678; x=1744033478; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=blFk6WxvfZ0Dn4FJO8eGQgyV/w70y6f+lqX5vhoojZw=; b=PevAEM72zgPj//ObUQ7hfkRixlnH9EwpPAcEJUMlvIZkf2Epx/GMSA9/2M6O2iQ/qR RYNQaiwjaoL1iTRimfOx5byhMtuCwzvFZCEq+m+aSKXiRyWP+iriIMo99ZSu0D9nq/N+ tyhkAM6iR9EErdP6rMEJc7OHggDxgmIaAuGFAHIp6H+CLWsDqsSrmSh7qhsj6y+vP5N2 BBNj1Fcxfq4XWxvYQV313i21OVHS93gtL0fPNEM2w6dd9mpadk2XLeRaXpPPbbUCPIKA lLiQGGSj3/UZozNreAcAyYsbvjQh+Y5HJWH6HhMTzGUI4kheiu4RuN/UngvYFS5P1ACJ qo+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743428678; x=1744033478; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=blFk6WxvfZ0Dn4FJO8eGQgyV/w70y6f+lqX5vhoojZw=; b=jHpi8nGnWvpstzFAVVGBgOIVdZZiOrAb5HY+pqr5U+1T8MfiUIPVnKDmJZe3xIESN/ R+JMvQ7tIBJzT0xPnRD4mSvkkX4ZSE5tUC8xwBhCC8OyLzzzn7pKaGTemR75OsTG5VOi g/bTiGeUJIBb4Cgc/mi3FKrrRSz7KzFlu1kXLnWKNXVWQKTDa88yJ5x7FuCFr6Nl+aHu N7mUDnUHsyFJe6vPReLfke9ctKJDYj3LSaX4r5rg/fbAka9pBdd2VW+2p/RIpUl9jU96 4zq++OGOSuBSZ60B+WOwEVFRzLL2AASnWOzDEul/CnMDFo9aPKEzupGmbDlFwyoTEobG yPVQ== X-Gm-Message-State: AOJu0Yzd2Yqm9t2qVfA34fCCgejKhODr0/PvdejGxs7T4fsH5StcPib1 W9AlOgfqMZVUYSB+vaynOwbj9Ec9BbJqqvi+4I0sVGnMUskLjveyTGDa5gww/SA= X-Gm-Gg: ASbGncswPadAAeHL9v6SB8m0hN7T3q4jTwf7V+42XvkgtyNx/OQ3gZgmUJBeJwj2cb1 9jyFgCF09uqHsytmDz2j3g35jXeWv4w/QtpF0aOVOS7oBj5IUcYDvesPY2ZD9DWd5yjGozPcxeD NRVuLj1S2UL0AbiNz1QZrTYG9yEyP8FjLFoTHFDh6N8XWJuF6pnjdIRmVYXCnrgfsr+NQHheQ8H sprVGjfJtmWITHbmHvbdZWfsn/k1Zjd/JYCpULWuZ5oBCuPIk4k0E2cuAKWtQ2nb78btCuXCDsP AJ4Tzrtjgwm5XAMuVYdGvkWfxVazecPhnBef819FnCLB4ym4QnYp1RewK4Nmt6UIAZmcNv+E+rK PDXv6+w== X-Google-Smtp-Source: AGHT+IFdWXLwZxBpxs5gXFNOvgJ13NgaVMLYlz8mqmQE2FxH4E82HTmAC3Yjt0rHHPjg1u/gRepIVg== X-Received: by 2002:a05:6000:188b:b0:390:f0ff:2c11 with SMTP id ffacd0b85a97d-39c120cb546mr7710937f8f.2.1743428677651; Mon, 31 Mar 2025 06:44:37 -0700 (PDT) Received: from localhost.localdomain ([87.116.182.236]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c0b79e467sm11389227f8f.79.2025.03.31.06.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 06:44:36 -0700 (PDT) From: Dmitrii Ovchinnikov <ovchinnikov.dmitrii@gmail.com> To: ffmpeg-devel@ffmpeg.org Date: Mon, 31 Mar 2025 15:44:22 +0200 Message-ID: <20250331134422.1147-1-ovchinnikov.dmitrii@gmail.com> X-Mailer: git-send-email 2.47.1.windows.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] libavcodec/amfenc: Setting the VBAQ property before the init call. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: Dmitrii Ovchinnikov <ovchinnikov.dmitrii@gmail.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250331134422.1147-1-ovchinnikov.dmitrii@gmail.com/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> --- libavcodec/amfenc_h264.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/libavcodec/amfenc_h264.c b/libavcodec/amfenc_h264.c index 8f3276de27..2098c59263 100644 --- a/libavcodec/amfenc_h264.c +++ b/libavcodec/amfenc_h264.c @@ -501,6 +501,16 @@ FF_ENABLE_DEPRECATION_WARNINGS AMF_ASSIGN_PROPERTY_INT64(res, ctx->encoder, AMF_VIDEO_ENCODER_REF_B_PIC_DELTA_QP, ctx->ref_b_frame_delta_qp); } + if (ctx->rate_control_mode == AMF_VIDEO_ENCODER_RATE_CONTROL_METHOD_CONSTANT_QP) { + AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, AMF_VIDEO_ENCODER_ENABLE_VBAQ, 0); + if (ctx->enable_vbaq) + av_log(ctx, AV_LOG_WARNING, "VBAQ is not supported by cqp Rate Control Method, automatically disabled\n"); + } else { + if (ctx->enable_vbaq != -1) { + AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, AMF_VIDEO_ENCODER_ENABLE_VBAQ, !!ctx->enable_vbaq); + } + } + // Wait inside QueryOutput() if supported by the driver AMF_ASSIGN_PROPERTY_INT64(res, ctx->encoder, AMF_VIDEO_ENCODER_QUERY_TIMEOUT, 1); res = ctx->encoder->pVtbl->GetProperty(ctx->encoder, AMF_VIDEO_ENCODER_QUERY_TIMEOUT, &var); @@ -523,15 +533,6 @@ FF_ENABLE_DEPRECATION_WARNINGS AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, AMF_VIDEO_ENCODER_RATE_CONTROL_SKIP_FRAME_ENABLE, ((ctx->skip_frame == 0) ? false : true)); } - if (ctx->rate_control_mode == AMF_VIDEO_ENCODER_RATE_CONTROL_METHOD_CONSTANT_QP) { - AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, AMF_VIDEO_ENCODER_ENABLE_VBAQ, 0); - if (ctx->enable_vbaq) - av_log(ctx, AV_LOG_WARNING, "VBAQ is not supported by cqp Rate Control Method, automatically disabled\n"); - } else { - if (ctx->enable_vbaq != -1) { - AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, AMF_VIDEO_ENCODER_ENABLE_VBAQ, !!ctx->enable_vbaq); - } - } AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, AMF_VIDEO_ENCODER_DE_BLOCKING_FILTER, !!deblocking_filter); // Keyframe Interval -- 2.47.1.windows.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".