From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 1968E4BD78
for <ffmpegdev@gitmailbox.com>; Sun, 30 Mar 2025 15:00:37 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D36B4687C80;
Sun, 30 Mar 2025 18:00:32 +0300 (EEST)
Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net
[217.70.183.200])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7517C687C18
for <ffmpeg-devel@ffmpeg.org>; Sun, 30 Mar 2025 18:00:25 +0300 (EEST)
Received: by mail.gandi.net (Postfix) with ESMTPSA id CB5F043215
for <ffmpeg-devel@ffmpeg.org>; Sun, 30 Mar 2025 15:00:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
s=gm1; t=1743346825;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding;
bh=eSoOMwmrrV5o8/ffCESbLuiKZw3kum0kQqqpB41vT9A=;
b=cpMK5LhfiJwNhgzIgL0jq2HenqaxeDi/zut5GizmyAKJuOjxhP7nWTYvHOqbTCNhiu0t3a
MsS8joVaobrmQctHxEY2KonhXlaJPCVqEgQ7emcZb+6fMWoh/RDvxwuY2OZNcN8deQdxSE
jd6EQWz8HDBcNSawnaJAU12MLMMb5Is/498o2LJI9ooVQe5Je4uys1ayMdOU9D+Ql+aGvh
0Pk5ckL9p5YiUf28neKQY8D3T8yaejNh47yC86bxiIvKcuo8MXCNd2G0nJe+Aojx28raLp
uJ+4buLYBEAh/CwuN8oj791y+zkVwFaM+QHBmSOr7YAYp35tc0zbv17Kk2BJpA==
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Date: Sun, 30 Mar 2025 17:00:22 +0200
Message-ID: <20250330150023.1484947-1-michael@niedermayer.cc>
X-Mailer: git-send-email 2.49.0
MIME-Version: 1.0
X-GND-State: clean
X-GND-Score: -70
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddujeejfeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhephffvufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpefhledvvdehgfettdefueevtdeifffhkeeljeetjeeugfelgfffieduheevvefgvdenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg
X-GND-Sasl: michael@niedermayer.cc
Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/ffv1enc: replace 3 double
precision log2() by 1 single precision log2()
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250330150023.1484947-1-michael@niedermayer.cc/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
This makes the remap finding heuristic much faster
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavcodec/ffv1enc.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c
index a09b31218db..2a188ade776 100644
--- a/libavcodec/ffv1enc.c
+++ b/libavcodec/ffv1enc.c
@@ -1390,7 +1390,7 @@ static void encode_float32_remap(FFV1Context *f, FFV1SliceContext *sc,
int last_mul_index = -1;
int mul_count = 1 << log2_mul_count;
- score_sum[log2_mul_count] += log2_mul_count;
+ score_sum[log2_mul_count] += log2_mul_count * log2_mul_count;
for (int i= 0; i<pixel_num; i++) {
int64_t val = sc->unit[p][i].val;
int mul_index = (val + 1LL)*mul_count >> 32;
@@ -1414,11 +1414,17 @@ static void encode_float32_remap(FFV1Context *f, FFV1SliceContext *sc,
}
cost = FFMAX((delta + mul/2) / mul, 1);
- score_tab[si] += log2(cost);
- if (mul > 1)
- score_tab[si] += log2(fabs(delta - cost*mul)+1) * (1 + (mul_count > 1));
+ float score = 1;
+ if (mul > 1) {
+ score *= (fabs(delta - cost*mul)+1);
+ if (mul_count > 1)
+ score *= score;
+ }
+ score *= cost;
+ score *= score;
if (mul_index != last_mul_index)
- score_tab[si] += 0.5*log2(mul);
+ score *= mul;
+ score_tab[si] += log2f(score);
}
}
last_val = val;
--
2.49.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".