From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/ffv1enc: replace 3 double precision log2() by 1 single precision log2() Date: Sun, 30 Mar 2025 17:00:22 +0200 Message-ID: <20250330150023.1484947-1-michael@niedermayer.cc> (raw) This makes the remap finding heuristic much faster Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavcodec/ffv1enc.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index a09b31218db..2a188ade776 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1enc.c @@ -1390,7 +1390,7 @@ static void encode_float32_remap(FFV1Context *f, FFV1SliceContext *sc, int last_mul_index = -1; int mul_count = 1 << log2_mul_count; - score_sum[log2_mul_count] += log2_mul_count; + score_sum[log2_mul_count] += log2_mul_count * log2_mul_count; for (int i= 0; i<pixel_num; i++) { int64_t val = sc->unit[p][i].val; int mul_index = (val + 1LL)*mul_count >> 32; @@ -1414,11 +1414,17 @@ static void encode_float32_remap(FFV1Context *f, FFV1SliceContext *sc, } cost = FFMAX((delta + mul/2) / mul, 1); - score_tab[si] += log2(cost); - if (mul > 1) - score_tab[si] += log2(fabs(delta - cost*mul)+1) * (1 + (mul_count > 1)); + float score = 1; + if (mul > 1) { + score *= (fabs(delta - cost*mul)+1); + if (mul_count > 1) + score *= score; + } + score *= cost; + score *= score; if (mul_index != last_mul_index) - score_tab[si] += 0.5*log2(mul); + score *= mul; + score_tab[si] += log2f(score); } } last_val = val; -- 2.49.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2025-03-30 15:00 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-03-30 15:00 Michael Niedermayer [this message] 2025-03-30 15:00 ` [FFmpeg-devel] [PATCH 2/2] avcodec/ffv1enc: replace the remaining log2() by magic Michael Niedermayer 2025-04-02 21:21 ` [FFmpeg-devel] [PATCH 1/2] avcodec/ffv1enc: replace 3 double precision log2() by 1 single precision log2() Michael Niedermayer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20250330150023.1484947-1-michael@niedermayer.cc \ --to=michael@niedermayer.cc \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git