From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 73B3D4BB3D for <ffmpegdev@gitmailbox.com>; Sun, 30 Mar 2025 00:04:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 13D88687CA0; Sun, 30 Mar 2025 02:04:22 +0200 (EET) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2CF4F687AF1 for <ffmpeg-devel@ffmpeg.org>; Sun, 30 Mar 2025 02:04:16 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 723AA44368 for <ffmpeg-devel@ffmpeg.org>; Sun, 30 Mar 2025 00:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1743293055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K5uxjJYoAL8HLwSm1RrCx/5wMYvYX7t2wozuzfuhFhk=; b=LoE3+1FIJ7+MvgBVe9htvwccvIZpYwdjjft3K/h9XYLLHGrlmycwmaXRXndsfRHmVF58Al BkSPpORCVKs8jAAsTukuOthMAx9hF2MDwjGB7vWFLXTM5brd8nV9jnul+iscawHYD7GRwe fE+tib2yZT3cC25/fdjGDzGT+rxP1wf4msiXlbAsevtzmNBfysez1AJt0ye6Kn3meFD9U7 JMAw4TAEx5ffOPzw8WsGtBEw+zjTYbnX5veSLh4vgNwxI+DddIWIn3RlFFpu/ncnxT+zAt GeVilf5TY3HQSr+iVwc9a/YKvuLNtekOPmAZdTIiWj7h6z0vd4b8oqOv7Szw9Q== Date: Sun, 30 Mar 2025 01:04:14 +0100 From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <20250330000414.GU4991@pb2> References: <6bef7ee3-6e0b-496a-9018-ce02d5e8cd63@gmail.com> <2477728b-6217-446a-9a15-830f028baea0@gmail.com> <8bdfe841-080b-49f6-913b-7577d03a1214@gmail.com> <20250328213828.GI4991@pb2> <8ab047e5-97cb-4d5d-806c-f71ee1223ad9@gmail.com> MIME-Version: 1.0 In-Reply-To: <8ab047e5-97cb-4d5d-806c-f71ee1223ad9@gmail.com> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddujeehheejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeefjedvvddtteegvddvffdtjeeiveffgeeijeffueduteffjeetleeugeekkefgjeenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhgihhtqdhstghmrdgtohhmnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avfilter: Proof of Concept: enable out-of-tree filters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: multipart/mixed; boundary="===============4968734033048075547==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250330000414.GU4991@pb2/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> --===============4968734033048075547== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xxZ3tyy/4nypiOBu" Content-Disposition: inline --xxZ3tyy/4nypiOBu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Sat, Mar 29, 2025 at 03:52:52PM +0100, Leandro Santiago wrote: [...] > The good side of it is that it's up to the developer of the external filt= er to worry about keeping track with changes in the ffmpeg core, not the ot= her way round. >=20 > > > > That is each filter developer simply maintaining a fork of ffmpeg and t= heir > > filter, in that fork. Adding lines to configure, Makefile, ... > > > > If we take the last filter as a random example, what it chanegd looks l= ike this: > > > > avfilter/interlace_vulkan: add interlace_vulkan filter > > > > This is a Vulkan-accelerated version of the existing interlace filt= er. > > > > configure | 1 + > > doc/filters.texi | 2 +- > > libavfilter/Makefile | 1 + > > libavfilter/allfilters.c | 1 + > > libavfilter/vf_interlace_vulkan.c | 313 ++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++ > > 5 files changed, 317 insertions(+), 1 deletion(-) > Interesting, the case of documentation integration is still an open issue= on my proposal. I'll have a look at it. > > > > The advantage of "git merge" wether by hand or by a automated tool > > is that its not limited to what it can do. Its much more powerfull >=20 > How would that work when the user is building ffmpeg+external-filters via= release tarballs? If one seriously wanted this, we could include the .git directory in the ta= rball. But someone who wants to include any type of module at compile time will have to work with various tools. like a compiler and configure and some way to obtain the module into the right place. typing git pull --no-rebase --no-edit https://github.com/author/project branch is simpler ATM, i see a system we need to maintain that supports only libavfilter and git which we dont have to maintain that supports every module Iam lazy, so iam drawen toward git If git fails to work, then we can look into other solutions, can you try simply using git and check if it would work ? >=20 > > > > and the changes outside adding the filter itself are very basic. > > Conflicts are something that we can workaround in many ways if they > > become a problem > > > > Also it much easier alows transitioning between actually including a fi= lter > > in git master, if the community desires that for a filter later. >=20 > For those cases, git has good support for merging unrelated repositories = with unrelated histories those days. I have experienced using it on less co= mplex codebases and it worked really well. >=20 > Do you think it would be problematic? [1] >=20 > [1] https://git-scm.com/docs/git-merge#Documentation/git-merge.txt---allo= w-unrelated-histories yes thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin --xxZ3tyy/4nypiOBu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ+iKeAAKCRBhHseHBAsP q5lhAJ92tQAjpUwjZ+F4vrx6kvAtr+1SJACgkqiuYzHC8ile2VVYtanfNwvkrvs= =Z6JN -----END PGP SIGNATURE----- --xxZ3tyy/4nypiOBu-- --===============4968734033048075547== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4968734033048075547==--