Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mjpegenc: Simplify allocating huffman table

From: Michael Niedermayer <michael@niedermayer.cc>
To: ffmpeg-devel@ffmpeg.org
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mjpegenc: Simplify allocating huffman table
Date: Thu, 27 Mar 2025 02:16:37 +0100
Message-ID: <20250327011637.GC2448403@pb2> (raw)
In-Reply-To: <20250326040856.71D62412944@natalya.videolan.org>

[-- Attachment #1.1: Type: text/plain, Size: 1976 bytes --]

On Wed, Mar 26, 2025 at 04:08:55AM +0000, Andreas Rheinhardt wrote:
> ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt@outlook.com> | Mon Mar  3 02:36:55 2025 +0100| [24dbc4c2e82481f89d6fcacee1949e5038c5c2fc] | committer: Andreas Rheinhardt
> 
> avcodec/mjpegenc: Simplify allocating huffman table
> 
> Reuse the already computed value of macroblocks; use an array
> instead of a switch, evaluate 64 * sizeof(MJpegHuffmanCode)
> at compile-time.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=24dbc4c2e82481f89d6fcacee1949e5038c5c2fc
> ---
> 
>  libavcodec/mjpegenc.c | 24 ++++++++++--------------
>  1 file changed, 10 insertions(+), 14 deletions(-)

Breaks: (did not investigate why)

./ffmpeg  -i lena.pnm -strict -1 -s 4096x2048 -bitexact -y /tmp/file-4096x2048.m2v && ./ffmpeg -i /tmp/file-4096x2048.m2v -y -bitexact /tmp/file-4096x2048-dec.jpg

[vost#0:0/mjpeg @ 0x5576d6b7ab00] [enc:mjpeg @ 0x5576d6b79580] Error while opening encoder - maybe incorrect parameters such as bit_rate, rate, width or height.
[vf#0:0 @ 0x5576d6b7f140] Error sending frames to consumers: Cannot allocate memory
[vf#0:0 @ 0x5576d6b7f140] Task finished with error code: -12 (Cannot allocate memory)
[vf#0:0 @ 0x5576d6b7f140] Terminating thread with return code -12 (Cannot allocate memory)
[vost#0:0/mjpeg @ 0x5576d6b7ab00] [enc:mjpeg @ 0x5576d6b79580] Could not open encoder before EOF
[vost#0:0/mjpeg @ 0x5576d6b7ab00] Task finished with error code: -22 (Invalid argument)
[vost#0:0/mjpeg @ 0x5576d6b7ab00] Terminating thread with return code -22 (Invalid argument)
[out#0/image2 @ 0x5576d6b7ec80] Nothing was written into output file, because at least one of its streams received no packets.

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".