From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 6BE5B4B80F
	for <ffmpegdev@gitmailbox.com>; Wed, 26 Mar 2025 20:51:24 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EC610687B01;
	Wed, 26 Mar 2025 22:51:20 +0200 (EET)
Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com
 [209.85.214.181])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9D0EE687A1B
 for <ffmpeg-devel@ffmpeg.org>; Wed, 26 Mar 2025 22:51:13 +0200 (EET)
Received: by mail-pl1-f181.google.com with SMTP id
 d9443c01a7336-223a7065ff8so10591275ad.0
 for <ffmpeg-devel@ffmpeg.org>; Wed, 26 Mar 2025 13:51:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1743022271; x=1743627071; darn=ffmpeg.org;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:from:to:cc:subject:date:message-id:reply-to;
 bh=jdyJDKEZQUrxdLPoILMeAcZYKdHZ52ou9t5AKFHbyHk=;
 b=XyhY/Nl5H4MSKBt8T5sqWuvxZzRLYESM5ah5EHB91kDnTwjfe7wKUDjBtiU5aFfZ7M
 LauqyBL60U8EXxC0b6iAufnyqEcYVNd3i3S+pwzyP6ctQpcAF66MzBtFM2GLhPgBpA5A
 MPwwQuua9zwoP3fgbfxvZJ4L3HRgf+hkmNyqbldmhEI9X2CpyJMUxYfhS5l8a/4/83Zq
 /FGTtzONuZdOuR3/4cFYsU1b2Ce7tUUnraLItVz+9vOnJP1sF8ZVcGkpcAf4/IJxA0nL
 C8wt/WLBENDFbVnTei9qA7y+SOjbCxGxX0O0duXimuSx7mtJPCVPIZe3jjLTad7okzP4
 Y9dw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1743022271; x=1743627071;
 h=content-transfer-encoding:mime-version:message-id:date:subject:cc
 :to:from:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=jdyJDKEZQUrxdLPoILMeAcZYKdHZ52ou9t5AKFHbyHk=;
 b=pheJ4M4una7LTykokz5K5+5CZ/c+OMQiwexEAtQE5EFgY38jnqat2p60dhn4+IHxFC
 qqrEa+S7b5fkHUxH9LJdZ/nExjkYBw/Rg7m27rA5r+a+0DFtPaMHOb2S7mVp6yN68cSq
 zoYADxLOvAk6ak+R1I1KbEe3PrCv6HNG1zsUyXT2+ywVMvwt0p/tG993hIMGLeFILqW/
 wk+GQnuYx7RqIlPKTj1Qu1omCMRZwBunxHmSsKn0yye/O7XSab3k8sGG6EoYcUevybiW
 8pw7JxuxJU1SaA7E8CjkN/gTs5kNS20nq++F8+hmqLydkmblXCgl0Kya/odMPqh5lzhM
 e6vg==
X-Gm-Message-State: AOJu0Yw792ESlrcE2DOhAT8JO/dl6D3unQuiRVEH3LhRu+o11sw80neD
 HU2BFQ+soxGFLe6MFE/qDxZS3+uLMN5+Cnr7OFxrQ0vo0mzpM4RvPwyo8A==
X-Gm-Gg: ASbGncuXQZS2pnJ5dJSLOr5xvchB65nrMu/LuGv7bFpyQLEgwXA1BxYodioeKdu61et
 L4EyO6Q45QqAqK8m0+1XAFJJr3xlIK9NcV+BU6Hy22J6eTKpXLaX3235KmR5Zsp/SqbPhBbRON6
 gqRwls436UkbYPg6COGgwKVrzHEG0Qj5evOPlUsv7kpDLTaOTG3veFdfNwsjeg54LWCRlxZmfST
 FbiNCmg6jRPY4STvPLg9iQ+q6qj72Wd+jNpgMb0LbRUNtPNBwTtvV5TkV7ZtAeIVhNuCptcxagk
 STNPEBa+hhXVujAAWmw9DfWkFYD1LMKVAqN+NBc7eUb9c+R7mJzeV0xxy/GoR31PLJdB9fF2Wg=
 =
X-Google-Smtp-Source: AGHT+IFGC3QcgeTD8e4L1oyi3vIGPLxvCcoWvxAsym1io1aTgafmNrKLE9iPd6yJca2xzq82mneZvw==
X-Received: by 2002:a17:903:3c63:b0:223:f408:c3e2 with SMTP id
 d9443c01a7336-22804851d3dmr15622915ad.14.1743022270983; 
 Wed, 26 Mar 2025 13:51:10 -0700 (PDT)
Received: from localhost.localdomain ([2001:559:76c:0:5d1f:f149:30ce:c3b7])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-227811b808bsm114444285ad.141.2025.03.26.13.51.10
 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);
 Wed, 26 Mar 2025 13:51:10 -0700 (PDT)
From: koushd@gmail.com
To: ffmpeg-devel@ffmpeg.org
Date: Wed, 26 Mar 2025 13:50:57 -0700
Message-Id: <20250326205057.73627-1-koushd@gmail.com>
X-Mailer: git-send-email 2.39.5 (Apple Git-154)
MIME-Version: 1.0
Subject: [FFmpeg-devel] [PATCH] libavformat/sdp: VPS is not a mandatory HEVC
 codec parameter.
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Koushik Dutta <koushd@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250326205057.73627-1-koushd@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

From: Koushik Dutta <koushd@gmail.com>

Many IP cameras do not place VPS in the SDP, and only send it
in the stream. The RTSP SDP only contains SPS/PPS.

Signed-off-by: Koushik Dutta <koushd@gmail.com>
---
 libavformat/sdp.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/libavformat/sdp.c b/libavformat/sdp.c
index 28490d77f3..64fe9d61ac 100644
--- a/libavformat/sdp.c
+++ b/libavformat/sdp.c
@@ -301,7 +301,9 @@ static int extradata2psets_hevc(AVFormatContext *fmt, const AVCodecParameters *p
             pos += len;
         }
     }
-    if (!ps_pos[0] || !ps_pos[1] || !ps_pos[2])
+
+    // VPS is not mandatory
+    if (!ps_pos[1] || !ps_pos[2])
         goto err;
 
     psets = av_mallocz(MAX_PSET_SIZE);
@@ -314,6 +316,8 @@ static int extradata2psets_hevc(AVFormatContext *fmt, const AVCodecParameters *p
 
     for (i = 0; i < 3; i++) {
         pos = ps_pos[i];
+        if (!pos)
+            continue;
 
         if (i > 0)
             av_strlcat(psets, "; ", MAX_PSET_SIZE);
-- 
2.39.5 (Apple Git-154)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".