Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] libavformat/sdp: VPS is not a mandatory HEVC codec parameter.
@ 2025-03-26 20:50 koushd
  0 siblings, 0 replies; only message in thread
From: koushd @ 2025-03-26 20:50 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Koushik Dutta

From: Koushik Dutta <koushd@gmail.com>

Many IP cameras do not place VPS in the SDP, and only send it
in the stream. The RTSP SDP only contains SPS/PPS.

Signed-off-by: Koushik Dutta <koushd@gmail.com>
---
 libavformat/sdp.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/libavformat/sdp.c b/libavformat/sdp.c
index 28490d77f3..64fe9d61ac 100644
--- a/libavformat/sdp.c
+++ b/libavformat/sdp.c
@@ -301,7 +301,9 @@ static int extradata2psets_hevc(AVFormatContext *fmt, const AVCodecParameters *p
             pos += len;
         }
     }
-    if (!ps_pos[0] || !ps_pos[1] || !ps_pos[2])
+
+    // VPS is not mandatory
+    if (!ps_pos[1] || !ps_pos[2])
         goto err;
 
     psets = av_mallocz(MAX_PSET_SIZE);
@@ -314,6 +316,8 @@ static int extradata2psets_hevc(AVFormatContext *fmt, const AVCodecParameters *p
 
     for (i = 0; i < 3; i++) {
         pos = ps_pos[i];
+        if (!pos)
+            continue;
 
         if (i > 0)
             av_strlcat(psets, "; ", MAX_PSET_SIZE);
-- 
2.39.5 (Apple Git-154)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-03-26 20:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-26 20:50 [FFmpeg-devel] [PATCH] libavformat/sdp: VPS is not a mandatory HEVC codec parameter koushd

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git