From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id EECF94B6BD
for <ffmpegdev@gitmailbox.com>; Wed, 26 Mar 2025 10:38:26 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C0AD8687B9C;
Wed, 26 Mar 2025 12:38:21 +0200 (EET)
Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com
[209.85.128.41])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8E339687B02
for <ffmpeg-devel@ffmpeg.org>; Wed, 26 Mar 2025 12:38:14 +0200 (EET)
Received: by mail-wm1-f41.google.com with SMTP id
5b1f17b1804b1-43cf680d351so4042895e9.0
for <ffmpeg-devel@ffmpeg.org>; Wed, 26 Mar 2025 03:38:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1742985493; x=1743590293; darn=ffmpeg.org;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=hUmVFnlbe3tf6Yn2fkiQxzgnRduvl4UKNd9uSKuczF4=;
b=fQCwHXNEaJHvb8NSYJHphyQL1VRy8bFiyRigCoxX8fKDqhdYvAZiTq80CPvoYkj147
gR36l7yQRMgeR2fuGlmt/qiqJ47XYIuUhk2p3RATZN0l+edFy8ONND3Uz5Jk3MypMxMX
dUNnfiTzzLmP6QTc1igFu3UdTRMEYt7nYSP6pKAJ9SVTNI4/m2AHI5cYYlKkygvPtxQz
ijVDg2BBG3dCYFFeKnq8J22UC01lI1OeyzsIRgDg80+iTd4CQu0VTktAU+LK2YeGKPtj
fMMotn132NR4p7mEczc3ruW33Ew/I/E+fhXoFWA/7SI73PGly27hvtolPAS7zsTfgtyK
gAhg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1742985493; x=1743590293;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=hUmVFnlbe3tf6Yn2fkiQxzgnRduvl4UKNd9uSKuczF4=;
b=W+eKDyVRiz90w6M9bP1BWsE7PYWeEiQKiGde12HqPTdsIUHGMJxwOtOTTkzckGpHVl
pVuN582TyfQyXdBI3tQxa/PyacJaNx+BvkFKbwe6eptyz1LIj/kSXn42rjXVGcJsldo9
C8o/r6bu7muqw9u8Fi2bXBeGsSsaNpOZmIcQ1wFF/nKzrH1a2xf+UhBBtrGKvdok0bkL
DfEQRGalUG9c1ngMRY/ACHDQvZ/0ESeMG/DxiDZGApwHvH9NKgMKLl1z4Pz2qK7xJy5M
ISzcH8W2N+O95aBdSTJQEvOKRmAp0ETBSDtbNR25IUhe9t2N7V+ClWUC81S1IbpSt36U
RnlA==
X-Gm-Message-State: AOJu0YyBJ/wIJ53ZCAUSbCoroAr3C2YjmvdNmbucRQ4Az8Yh/q3mn09S
YStZa7NuuVZpaSlO3+lCM27Y0gSQBpVPYjXK9w9PXnj5kYzKW65vC/6qig==
X-Gm-Gg: ASbGncuzeUd+HKKUPRzAiabHuw+uwRk0bT+4y/8tWUSMUlsf3OrqST+3JgU11t/sroW
oQKQdZaY1yLmVJcsDv27a1IbqxYv18bU+XfPo11be184Oo/NwPvaaAOjD0Q+aPjjdbhyRFLrkiV
4wrChOWvPT0g/YVPrNs/JGV0OA5POR+3FtTr3Nl2KYYbq4GpCttv1iboshZV4/6olXcO1VEotZT
knlTb74137rUznX+Pxqd8I3+UWDpnOoBKMLPR3Nc9FWLMycTdmj9RoAVCr4Sn+D0GkonAOnImrH
h1beExSLJHoSSR5aCG0ThvqfVLpeNerBrti9RC2ZUcCsNzFBvp8k
X-Google-Smtp-Source: AGHT+IHoVTgCeKReJ44IqmtAueNbzMjzeTjiru7Nm8+H1t3chC9jverdgGI7zLFl7H/znIxvjxcXpw==
X-Received: by 2002:a5d:64c3:0:b0:391:2889:ade0 with SMTP id
ffacd0b85a97d-39acc4771f1mr2579477f8f.18.1742985493216;
Wed, 26 Mar 2025 03:38:13 -0700 (PDT)
Received: from localhost.localdomain ([49.51.162.193])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-3997f9b260fsm16183584f8f.43.2025.03.26.03.38.12
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 26 Mar 2025 03:38:12 -0700 (PDT)
From: Jun Zhao <mypopy@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Date: Wed, 26 Mar 2025 18:38:06 +0800
Message-Id: <20250326103808.1079263-1-mypopy@gmail.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Subject: [FFmpeg-devel] [PATCH 1/2] fftools/cmdutils: fix error message for
"ffmpeg -init_hw_device list"
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Jun Zhao <barryjzhao@tencent.com>, Jun Zhao <mypopydev@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250326103808.1079263-1-mypopy@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
From: Jun Zhao <mypopydev@gmail.com>
When running 'ffmpeg -init_hw_device list' to display available hardware
devices, it incorrectly shows an error message:
"Failed to set value 'list' for option 'init_hw_device': Immediate exit requested"
This is a regression introduced by commit a50f90f1c23. The command is
actually working as intended - it should exit after listing devices, but
shouldn't display an error message.
Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
---
fftools/cmdutils.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index 8ac20bf049..aa782c7754 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
@@ -352,9 +352,11 @@ static int write_option(void *optctx, const OptionDef *po, const char *opt,
ret = po->u.func_arg(optctx, opt, arg);
if (ret < 0) {
- av_log(NULL, AV_LOG_ERROR,
- "Failed to set value '%s' for option '%s': %s\n",
- arg, opt, av_err2str(ret));
+ if (strcmp(opt, "init_hw_device") || strcmp(arg, "list")) {
+ av_log(NULL, AV_LOG_ERROR,
+ "Failed to set value '%s' for option '%s': %s\n",
+ arg, opt, av_err2str(ret));
+ }
goto finish;
}
}
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".