[FFmpeg-devel] [PATCH v2] checkasm/v210enc.c: Use checkasm_check()

[FFmpeg-devel] [PATCH v2] checkasm/v210enc.c: Use checkasm_check()

[Martin Storsjö]

From: Kieran Kunhya <kierank@obe.tv>

This gives more informative printouts if the tests fail,
if checkasm is run with "-v".

Signed-off-by: Martin Storsjö <martin@martin.st>
---
 tests/checkasm/v210enc.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tests/checkasm/v210enc.c b/tests/checkasm/v210enc.c
index 9fb8321c25..106f00c851 100644
--- a/tests/checkasm/v210enc.c
+++ b/tests/checkasm/v210enc.c
@@ -72,11 +72,10 @@
             randomize_buffers(mask);                                               \
             call_ref(y0 + y_offset, u0 + uv_offset, v0 + uv_offset, dst0, width);  \
             call_new(y1 + y_offset, u1 + uv_offset, v1 + uv_offset, dst1, width);  \
-            if (memcmp(y0, y1, BUF_SIZE * sizeof(type))                            \
-                    || memcmp(u0, u1, BUF_SIZE * sizeof(type) / 2)                 \
-                    || memcmp(v0, v1, BUF_SIZE * sizeof(type) / 2)                 \
-                    || memcmp(dst0, dst1, width * 8 / 3))                          \
-                fail();                                                            \
+            checkasm_check(type,    y0,   0, y1,   0, BUF_SIZE,      1, "y");      \
+            checkasm_check(type,    u0,   0, u1,   0, BUF_SIZE / 2,  1, "u");      \
+            checkasm_check(type,    v0,   0, v1,   0, BUF_SIZE / 2,  1, "v");      \
+            checkasm_check(uint8_t, dst0, 0, dst1, 0, width * 8 / 3, 1, "dst");    \
             bench_new(y1 + y_offset, u1 + uv_offset, v1 + uv_offset, dst1, width); \
         }                                                                          \
     } while (0)
-- 
2.39.5 (Apple Git-154)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] checkasm/v210enc.c: Use checkasm_check()

[Martin Storsjö]

On Wed, 26 Mar 2025, Martin Storsjö wrote:

> From: Kieran Kunhya <kierank@obe.tv>
>
> This gives more informative printouts if the tests fail,
> if checkasm is run with "-v".
>
> Signed-off-by: Martin Storsjö <martin@martin.st>
> ---
> tests/checkasm/v210enc.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/tests/checkasm/v210enc.c b/tests/checkasm/v210enc.c
> index 9fb8321c25..106f00c851 100644
> --- a/tests/checkasm/v210enc.c
> +++ b/tests/checkasm/v210enc.c
> @@ -72,11 +72,10 @@
>             randomize_buffers(mask);                                               \
>             call_ref(y0 + y_offset, u0 + uv_offset, v0 + uv_offset, dst0, width);  \
>             call_new(y1 + y_offset, u1 + uv_offset, v1 + uv_offset, dst1, width);  \
> -            if (memcmp(y0, y1, BUF_SIZE * sizeof(type))                            \
> -                    || memcmp(u0, u1, BUF_SIZE * sizeof(type) / 2)                 \
> -                    || memcmp(v0, v1, BUF_SIZE * sizeof(type) / 2)                 \
> -                    || memcmp(dst0, dst1, width * 8 / 3))                          \
> -                fail();                                                            \
> +            checkasm_check(type,    y0,   0, y1,   0, BUF_SIZE,      1, "y");      \
> +            checkasm_check(type,    u0,   0, u1,   0, BUF_SIZE / 2,  1, "u");      \
> +            checkasm_check(type,    v0,   0, v1,   0, BUF_SIZE / 2,  1, "v");      \
> +            checkasm_check(uint8_t, dst0, 0, dst1, 0, width * 8 / 3, 1, "dst");    \
>             bench_new(y1 + y_offset, u1 + uv_offset, v1 + uv_offset, dst1, width); \
>         }                                                                          \
>     } while (0)
> -- 
> 2.39.5 (Apple Git-154)

Will push soon unless there are objections.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] checkasm/v210enc.c: Use checkasm_check()

[Martin Storsjö]

On Tue, 1 Apr 2025, Martin Storsjö wrote:

> On Wed, 26 Mar 2025, Martin Storsjö wrote:
>
>> From: Kieran Kunhya <kierank@obe.tv>
>> 
>> This gives more informative printouts if the tests fail,
>> if checkasm is run with "-v".
>> 
>> Signed-off-by: Martin Storsjö <martin@martin.st>
>> ---
>> tests/checkasm/v210enc.c | 9 ++++-----
>> 1 file changed, 4 insertions(+), 5 deletions(-)
>> 
>> diff --git a/tests/checkasm/v210enc.c b/tests/checkasm/v210enc.c
>> index 9fb8321c25..106f00c851 100644
>> --- a/tests/checkasm/v210enc.c
>> +++ b/tests/checkasm/v210enc.c
>> @@ -72,11 +72,10 @@
>>             randomize_buffers(mask); 
>> \
>>             call_ref(y0 + y_offset, u0 + uv_offset, v0 + uv_offset, dst0, 
>> width);  \
>>             call_new(y1 + y_offset, u1 + uv_offset, v1 + uv_offset, dst1, 
>> width);  \
>> -            if (memcmp(y0, y1, BUF_SIZE * sizeof(type)) 
>> \
>> -                    || memcmp(u0, u1, BUF_SIZE * sizeof(type) / 2) 
>> \
>> -                    || memcmp(v0, v1, BUF_SIZE * sizeof(type) / 2) 
>> \
>> -                    || memcmp(dst0, dst1, width * 8 / 3)) 
>> \
>> -                fail(); 
>> \
>> +            checkasm_check(type,    y0,   0, y1,   0, BUF_SIZE,      1, 
>> "y");      \
>> +            checkasm_check(type,    u0,   0, u1,   0, BUF_SIZE / 2,  1, 
>> "u");      \
>> +            checkasm_check(type,    v0,   0, v1,   0, BUF_SIZE / 2,  1, 
>> "v");      \
>> +            checkasm_check(uint8_t, dst0, 0, dst1, 0, width * 8 / 3, 1, 
>> "dst");    \
>>             bench_new(y1 + y_offset, u1 + uv_offset, v1 + uv_offset, dst1, 
>> width); \
>>         } 
>> \
>>     } while (0)
>> -- 
>> 2.39.5 (Apple Git-154)
>
> Will push soon unless there are objections.

Pushed.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".