Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Martin Storsjö" <martin@martin.st>
To: ffmpeg-devel@ffmpeg.org
Cc: Kieran Kunhya <kierank@obe.tv>
Subject: [FFmpeg-devel] [PATCH v2] checkasm/v210enc.c: Use checkasm_check()
Date: Wed, 26 Mar 2025 12:30:59 +0200
Message-ID: <20250326103059.44372-1-martin@martin.st> (raw)

From: Kieran Kunhya <kierank@obe.tv>

This gives more informative printouts if the tests fail,
if checkasm is run with "-v".

Signed-off-by: Martin Storsjö <martin@martin.st>
---
 tests/checkasm/v210enc.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tests/checkasm/v210enc.c b/tests/checkasm/v210enc.c
index 9fb8321c25..106f00c851 100644
--- a/tests/checkasm/v210enc.c
+++ b/tests/checkasm/v210enc.c
@@ -72,11 +72,10 @@
             randomize_buffers(mask);                                               \
             call_ref(y0 + y_offset, u0 + uv_offset, v0 + uv_offset, dst0, width);  \
             call_new(y1 + y_offset, u1 + uv_offset, v1 + uv_offset, dst1, width);  \
-            if (memcmp(y0, y1, BUF_SIZE * sizeof(type))                            \
-                    || memcmp(u0, u1, BUF_SIZE * sizeof(type) / 2)                 \
-                    || memcmp(v0, v1, BUF_SIZE * sizeof(type) / 2)                 \
-                    || memcmp(dst0, dst1, width * 8 / 3))                          \
-                fail();                                                            \
+            checkasm_check(type,    y0,   0, y1,   0, BUF_SIZE,      1, "y");      \
+            checkasm_check(type,    u0,   0, u1,   0, BUF_SIZE / 2,  1, "u");      \
+            checkasm_check(type,    v0,   0, v1,   0, BUF_SIZE / 2,  1, "v");      \
+            checkasm_check(uint8_t, dst0, 0, dst1, 0, width * 8 / 3, 1, "dst");    \
             bench_new(y1 + y_offset, u1 + uv_offset, v1 + uv_offset, dst1, width); \
         }                                                                          \
     } while (0)
-- 
2.39.5 (Apple Git-154)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2025-03-26 10:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-26 10:30 Martin Storsjö [this message]
2025-04-01  9:36 ` Martin Storsjö
2025-04-01 15:33   ` Martin Storsjö

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250326103059.44372-1-martin@martin.st \
    --to=martin@martin.st \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=kierank@obe.tv \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git