From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 5/5] avcodec/ffv1enc: Store run1start_mul_index instead of computing
Date: Tue, 25 Mar 2025 15:06:55 +0100
Message-ID: <20250325140655.612516-5-michael@niedermayer.cc> (raw)
In-Reply-To: <20250325140655.612516-1-michael@niedermayer.cc>
Theres a special case I missed, its simpler to just store
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavcodec/ffv1enc.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c
index d28cb8f5700..bc59f96746c 100644
--- a/libavcodec/ffv1enc.c
+++ b/libavcodec/ffv1enc.c
@@ -1268,6 +1268,7 @@ typedef struct RemapEncoderState {
int run1final;
int64_t run1start_i;
int64_t run1start_last_val;
+ int run1start_mul_index;
} RemapEncoderState;
static inline void copy_state(RemapEncoderState *dst, const RemapEncoderState *src)
@@ -1287,6 +1288,7 @@ static inline void copy_state(RemapEncoderState *dst, const RemapEncoderState *s
dst->run1final = src->run1final;
dst->run1start_i = src->run1start_i;
dst->run1start_last_val = src->run1start_last_val;
+ dst->run1start_mul_index = src->run1start_mul_index;
}
static int encode_float32_remap_segment(FFV1SliceContext *sc,
@@ -1337,6 +1339,7 @@ static int encode_float32_remap_segment(FFV1SliceContext *sc,
if (!s.run) {
s.run1start_i = s.i - 1;
s.run1start_last_val = s.last_val;
+ s.run1start_mul_index= s.current_mul_index;
}
if (step == 1) {
if (s.run1final) {
@@ -1355,9 +1358,7 @@ static int encode_float32_remap_segment(FFV1SliceContext *sc,
put_symbol_inline(&s.rc, s.state[s.lu][0], s.run, 0, NULL, NULL);
s.i = s.run1start_i;
s.last_val = s.run1start_last_val; // we could compute this instead of storing
- av_assert2(s.last_val >= 0 && s.i >= 0); // first state is zero run so we cant have this in a one run and current_mul_index would be -1
- if (s.run)
- s.current_mul_index = ((s.last_val + 1) * s.mul_count) >> 32;
+ s.current_mul_index = s.run1start_mul_index;
}
s.run1final ^= 1;
--
2.48.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-03-25 14:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 14:06 [FFmpeg-devel] [PATCH 1/5] avcodec/ffv1enc: Eliminate encode_mul() Michael Niedermayer
2025-03-25 14:06 ` [FFmpeg-devel] [PATCH 2/5] avcodec/ffv1dec: Fix end handling Michael Niedermayer
2025-03-25 14:06 ` [FFmpeg-devel] [PATCH 3/5] avcodec/ffv1enc: " Michael Niedermayer
2025-03-25 14:06 ` [FFmpeg-devel] [PATCH 4/5] avcodec/ffv1enc: Fix off by 1 in assert Michael Niedermayer
2025-03-25 14:06 ` Michael Niedermayer [this message]
2025-03-26 13:10 ` [FFmpeg-devel] [PATCH 1/5] avcodec/ffv1enc: Eliminate encode_mul() Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325140655.612516-5-michael@niedermayer.cc \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git