From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id D50394AEB5
for <ffmpegdev@gitmailbox.com>; Tue, 25 Mar 2025 09:50:12 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 497A9687B65;
Tue, 25 Mar 2025 11:50:09 +0200 (EET)
Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net
[217.70.183.194])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7078A687A1D
for <ffmpeg-devel@ffmpeg.org>; Tue, 25 Mar 2025 11:50:02 +0200 (EET)
Received: by mail.gandi.net (Postfix) with ESMTPSA id C9E7543157
for <ffmpeg-devel@ffmpeg.org>; Tue, 25 Mar 2025 09:50:01 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
s=gm1; t=1742896202;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=Dy+LhVCfwrgwLEfRCd/J6oX4g6w2Et4k9Yel5lAn1Gc=;
b=PrbJUBmaygekcNfDKYqZiJuddd8bk/rnoSVVktuGRwgKaWDBNSk4T1wqxEPDG+gc8xGv2B
ssg0Bx3APv+u/lTx/vHWUEhdCtdcGgeON0Hk6P8xUW476DrTX0QeZcu0HkLK5/kI/Y8Yfk
OhICg46M9f2V1t1dEpx8lSPrURGYHVV7+TjhjqWSogDUMJ4AbdHXFgCE4eZtVlx1KBk7Dm
seDocvMoUMCJbS9RKesvXJISWUDv38F5ye3vgYbyWlIMYLk8Se710wBLh+ogMmLyko3WZj
qvGTfbDDcwWWy/0G8DT5heLuY7CjcOAbQO5Nce4T2t3EFSNQ3tkJBUqPvAAHWQ==
Date: Tue, 25 Mar 2025 10:50:01 +0100
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20250325095001.GX4991@pb2>
References: <20250324222051.19096-1-jamrial@gmail.com>
<20250325015053.GU4991@pb2>
<b667e162-df8c-4954-b240-1803bab810d6@gmail.com>
<919d56e9-90f6-47f5-ddda-c33c14a5acfa@martin.st>
MIME-Version: 1.0
In-Reply-To: <919d56e9-90f6-47f5-ddda-c33c14a5acfa@martin.st>
X-GND-State: clean
X-GND-Score: -90
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduiedvfeefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculddutddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddunecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeevueefgeefudetuefggfeivdetteekgfdukedtjeeuffevheegleduleffudfgheenucffohhmrghinhepfhhfmhhpvghgrdhorhhgnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc: further reduce stack
usage
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============0968335786502828298=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250325095001.GX4991@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
--===============0968335786502828298==
Content-Type: multipart/signed; micalg=pgp-sha512;
protocol="application/pgp-signature"; boundary="Ut5ETL1MjSEO3UT2"
Content-Disposition: inline
--Ut5ETL1MjSEO3UT2
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi Martin
On Tue, Mar 25, 2025 at 11:20:52AM +0200, Martin Storsj=F6 wrote:
> On Mon, 24 Mar 2025, James Almer wrote:
>=20
> > On 3/24/2025 10:50 PM, Michael Niedermayer wrote:
> > > Hi
> > >=20
> > > On Mon, Mar 24, 2025 at 07:20:50PM -0300, James Almer wrote:
> > > > Continues from commit 702239bc500b, fixing FATE failures on MacOS.
> > > >=20
> > > > Signed-off-by: James Almer <jamrial@gmail.com>
> > > > ---
> > > > Confirmed by Martin Storsj=F6. Float encoding untested.
> > > >=20
> > > > libavcodec/ffv1.h | 16 ++++
> > > > libavcodec/ffv1enc.c | 177 +++++++++++++++++---------------------=
-----
> > > > 2 files changed, 84 insertions(+), 109 deletions(-)
> > > >=20
> > > > diff --git a/libavcodec/ffv1.h b/libavcodec/ffv1.h
> > > > index 09118e0b7d..d1c239f138 100644
> > > > --- a/libavcodec/ffv1.h
> > > > +++ b/libavcodec/ffv1.h
> > > > @@ -115,6 +115,22 @@ typedef struct FFV1SliceContext {
> > > > uint32_t val; //this is unneeded if you accept a
> > > > dereference on each access
> > > > uint16_t ndx;
> > > > } unit[4][65536];
> > > > + struct RemapEncoderState {
> > > > + int delta_stack[65536]; //We need to encode the run
> > > > value before the adjustments, this stores the adjustments until
> > > > we know the length of the run
> > > > + int16_t index_stack[65537]; //only needed with multiple se=
gments
> > > > + uint8_t state[2][3][32];
> > > > + int mul[4096+1];
> > > > + RangeCoder rc;
> > > > + int lu;
> > > > + int run;
> > > > + int64_t last_val;
> > > > + int compact_index;
> > > > + int mul_count;
> > > > + int i;
> > > > + int pixel_num;
> > > > + int p;
> > > > + int current_mul_index;
> > > > + } remap_state;
> > > > } FFV1SliceContext;
> > >=20
> > > please provide a link to the failure
> >=20
> > Martin will have to do that. I can't seem to find any FATE instance
> > failing, but he said it affected his OSX machines.
>=20
> I set up a couple of macOS FATE instances now, both which show the failur=
e:
> https://fate.ffmpeg.org/history.cgi?slot=3Daarch64-apple-darwin-macos11
> https://fate.ffmpeg.org/history.cgi?slot=3Dx86_64-apple-darwin-macos11
I wonder if strictly taken, this is a compiler bug, given the code is not
executed or reachable
Ill apply a fix that eliminates these 2 arrays entirely
thx
[...]
--=20
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
--Ut5ETL1MjSEO3UT2
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ+J8RQAKCRBhHseHBAsP
qy2oAJwLqbO4umvLC21c1JmFhxDXaOLIqACfUr9hYKPR+tLeJ3XVoQ11MT/rG6Y=
=HQI3
-----END PGP SIGNATURE-----
--Ut5ETL1MjSEO3UT2--
--===============0968335786502828298==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--===============0968335786502828298==--