Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 04/11] avcodec/ffv1enc: remap table size is 1<<bits_per_raw_sample not fixed 65536
Date: Mon, 24 Mar 2025 18:39:38 +0100
Message-ID: <20250324173945.2574461-4-michael@niedermayer.cc> (raw)
In-Reply-To: <20250324173945.2574461-1-michael@niedermayer.cc>

not a bugfix as this path was only used for float16 but it makes sense
to allow using this for integers too

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/ffv1enc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c
index 05b43c12abf..78a9a903039 100644
--- a/libavcodec/ffv1enc.c
+++ b/libavcodec/ffv1enc.c
@@ -1168,6 +1168,7 @@ static void choose_rct_params(const FFV1Context *f, FFV1SliceContext *sc,
 
 static void encode_histogram_remap(FFV1Context *f, FFV1SliceContext *sc)
 {
+    int len = 1 << f->bits_per_raw_sample;
     int flip = sc->remap == 2 ? 0x7FFF : 0;
 
     for (int p= 0; p < 1 + 2*f->chroma_planes + f->transparency; p++) {
@@ -1179,7 +1180,7 @@ static void encode_histogram_remap(FFV1Context *f, FFV1SliceContext *sc)
         memset(state, 128, sizeof(state));
         put_symbol(&sc->c, state[0], 0, 0);
         memset(state, 128, sizeof(state));
-        for (int i= 0; i<65536; i++) {
+        for (int i= 0; i<len; i++) {
             int ri = i ^ ((i&0x8000) ? 0 : flip);
             int u = sc->fltmap[p][ri];
             sc->fltmap[p][ri] = j;
-- 
2.48.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2025-03-24 17:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-24 17:39 [FFmpeg-devel] [PATCH 01/11] avformat/nut: Add GBR(A)PF16/32LE/BE Michael Niedermayer
2025-03-24 17:39 ` [FFmpeg-devel] [PATCH 02/11] avcodec/raw: " Michael Niedermayer
2025-03-24 17:39 ` [FFmpeg-devel] [PATCH 03/11] avcodec/ffv1enc: remap mode 2 is for floats only Michael Niedermayer
2025-03-25  9:38   ` Michael Niedermayer
2025-03-24 17:39 ` Michael Niedermayer [this message]
2025-03-24 17:39 ` [FFmpeg-devel] [PATCH 05/11] avcodec/ffv1dec: compute end instead of hardcoding it and test for fltmap correctly Michael Niedermayer
2025-03-24 17:39 ` [FFmpeg-devel] [PATCH 06/11] avcodec/ffv1dec: replace literal 65535 by what it is Michael Niedermayer
2025-03-24 17:39 ` [FFmpeg-devel] [PATCH 07/11] avcodec/ffv1enc: eliminate if() Michael Niedermayer
2025-03-24 17:39 ` [FFmpeg-devel] [PATCH 08/11] avcodec/ffv1enc: introduce step to simplify code Michael Niedermayer
2025-03-24 17:39 ` [FFmpeg-devel] [PATCH 09/11] avcodec/ffv1enc: Simplify last_val update Michael Niedermayer
2025-03-24 17:39 ` [FFmpeg-devel] [PATCH 10/11] avcodec/ffv1enc: Factorize s.last_val update out Michael Niedermayer
2025-03-24 17:39 ` [FFmpeg-devel] [PATCH 11/11] avcodec/ffv1enc: Heuristic to select fixed in float multipliers Michael Niedermayer
2025-03-28 12:24 ` [FFmpeg-devel] [PATCH 01/11] avformat/nut: Add GBR(A)PF16/32LE/BE Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250324173945.2574461-4-michael@niedermayer.cc \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git