From: Romain Beauxis <romain.beauxis@gmail.com> To: ffmpeg-devel@ffmpeg.org Cc: samples-request@ffmpeg.org, Romain Beauxis <romain.beauxis@gmail.com> Subject: [FFmpeg-devel] [PATCH v9 0/8] Properly decode ogg metadata in ogg/{vorbis, flac, opus} chained bitstreams Date: Mon, 24 Mar 2025 09:50:51 -0500 Message-ID: <20250324145059.16593-1-romain.beauxis@gmail.com> (raw) This is a series of patches to allow proper decoding of ogg metadata in chained `ogg/vorbis, `ogg/flac` and `ogg/opus` streams. FATE samples for the new tests can be found here: https://www.dropbox.com/scl/fo/xrtrna2rxr1j354hrtymq/AGwemlxHYecBLNmQ8Fsy--4?rlkey=lzilr4m9w4gfdqygoe172vvy8&dl=0 ## Changes since last version: * Fixed fate test run in cross-compiled environments. * Switched to av_tree to store pending metadata as pts->metadata mappings in case packets arrive in non-linear order or metadata updates are split accross multiple packets for a single frame. Romain Beauxis (8): libavcodec/decode.c: intercept `AV_PKT_DATA_METADATA_UPDATE` packet extra data, attach them to the next decoded frame with the same PTS. tests: Add stream dump test API util. tests: Add chained ogg/vorbis stream dump test. libavformat/oggdec.h, libavformat/oggparsevorbis.c: Factor out vorbis metadata update mechanism. libavformat/oggparseflac.c: Parse ogg/flac comments in new ogg packets, add them to ogg stream new_metadata. tests: Add chained ogg/flac stream dump test. libavformat/oggparseopus.c: Parse comments from secondary chained streams header packet. tests: Add chained ogg/opus stream dump test. libavcodec/decode.c | 131 +++++++++++++++ libavformat/oggdec.h | 14 ++ libavformat/oggparseflac.c | 21 +++ libavformat/oggparseopus.c | 13 +- libavformat/oggparsevorbis.c | 25 ++- tests/Makefile | 4 + tests/api/Makefile | 2 +- tests/api/api-dump-stream-meta-test.c | 175 +++++++++++++++++++++ tests/fate/ogg-flac.mak | 11 ++ tests/fate/ogg-opus.mak | 11 ++ tests/fate/ogg-vorbis.mak | 11 ++ tests/ref/fate/ogg-flac-chained-meta.txt | 13 ++ tests/ref/fate/ogg-opus-chained-meta.txt | 27 ++++ tests/ref/fate/ogg-vorbis-chained-meta.txt | 17 ++ 14 files changed, 465 insertions(+), 10 deletions(-) create mode 100644 tests/api/api-dump-stream-meta-test.c create mode 100644 tests/fate/ogg-flac.mak create mode 100644 tests/fate/ogg-opus.mak create mode 100644 tests/fate/ogg-vorbis.mak create mode 100644 tests/ref/fate/ogg-flac-chained-meta.txt create mode 100644 tests/ref/fate/ogg-opus-chained-meta.txt create mode 100644 tests/ref/fate/ogg-vorbis-chained-meta.txt -- 2.39.5 (Apple Git-154) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2025-03-24 14:51 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-03-24 14:50 Romain Beauxis [this message] 2025-03-24 14:50 ` [FFmpeg-devel] [PATCH v9 1/8] libavcodec/decode.c: intercept `AV_PKT_DATA_METADATA_UPDATE` packet extra data, attach them to the next decoded frame with the same PTS Romain Beauxis 2025-03-24 14:50 ` [FFmpeg-devel] [PATCH v9 2/8] tests: Add stream dump test API util Romain Beauxis 2025-03-24 14:50 ` [FFmpeg-devel] [PATCH v9 3/8] tests: Add chained ogg/vorbis stream dump test Romain Beauxis 2025-03-24 14:50 ` [FFmpeg-devel] [PATCH v9 4/8] libavformat/oggdec.h, libavformat/oggparsevorbis.c: Factor out vorbis metadata update mechanism Romain Beauxis 2025-03-24 14:50 ` [FFmpeg-devel] [PATCH v9 5/8] libavformat/oggparseflac.c: Parse ogg/flac comments in new ogg packets, add them to ogg stream new_metadata Romain Beauxis 2025-03-24 14:50 ` [FFmpeg-devel] [PATCH v9 6/8] tests: Add chained ogg/flac stream dump test Romain Beauxis 2025-03-24 14:50 ` [FFmpeg-devel] [PATCH v9 7/8] libavformat/oggparseopus.c: Parse comments from secondary chained streams header packet Romain Beauxis 2025-03-24 14:50 ` [FFmpeg-devel] [PATCH v9 8/8] tests: Add chained ogg/opus stream dump test Romain Beauxis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20250324145059.16593-1-romain.beauxis@gmail.com \ --to=romain.beauxis@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ --cc=samples-request@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git