Re: [FFmpeg-devel] [PATCH 01/77] avcodec/mpegvideo(_enc)?: Mark init, close functions as, av_cold

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 2155 bytes --]

On Wed, Mar 19, 2025 at 10:18:38PM +0100, Andreas Rheinhardt wrote:
> First part of a patchset; the second part will be sent separately
> because the complete set crosses the ML thresholds ("Message body is too
> big: 1731572 bytes with a limit of 1000 KB"). A complete branch can be

> found here: https://github.com/mkver/FFmpeg/tree/mpvenc

tested the branch on mips:

make -k
CC	libavcodec/mpegvideo_unquantize.o
src/libavcodec/mpegvideo_unquantize.c: In function ‘ff_mpv_unquantize_init’:
src/libavcodec/mpegvideo_unquantize.c:272:34: error: ‘s’ is a pointer; did you mean to use ‘->’?
     ff_mpv_unquantize_init_mips(s. avctx, q_scale_type);
                                  ^
                                  ->
src/libavcodec/mpegvideo_unquantize.c:272:43: warning: passing argument 2 of ‘ff_mpv_unquantize_init_mips’ makes pointer from integer without a cast [-Wint-conversion]
     ff_mpv_unquantize_init_mips(s. avctx, q_scale_type);
                                           ^~~~~~~~~~~~
In file included from src/libavcodec/mpegvideo_unquantize.c:34:0:
src/libavcodec/mpegvideo_unquantize.h:60:6: note: expected ‘AVCodecContext * {aka struct AVCodecContext *}’ but argument is of type ‘int’
 void ff_mpv_unquantize_init_mips(MPVUnquantDSPContext *s, AVCodecContext *avctx,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
src/libavcodec/mpegvideo_unquantize.c:272:5: error: too few arguments to function ‘ff_mpv_unquantize_init_mips’
     ff_mpv_unquantize_init_mips(s. avctx, q_scale_type);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from src/libavcodec/mpegvideo_unquantize.c:34:0:
src/libavcodec/mpegvideo_unquantize.h:60:6: note: declared here
 void ff_mpv_unquantize_init_mips(MPVUnquantDSPContext *s, AVCodecContext *avctx,
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
make: *** [src/ffbuild/common.mak:81: libavcodec/mpegvideo_unquantize.o] Error 1
make: Target 'all' not remade because of errors.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".