Re: [FFmpeg-devel] [PATCH v7 8/8] tests: Add chained ogg/opus stream dump test.

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 5008 bytes --]

On Sun, Mar 16, 2025 at 08:03:58PM -0500, Romain Beauxis wrote:
> Le dim. 16 mars 2025 à 19:18, Michael Niedermayer
> <michael@niedermayer.cc> a écrit :
> >
> > On Mon, Mar 17, 2025 at 01:11:51AM +0100, Michael Niedermayer wrote:
> > > On Tue, Feb 25, 2025 at 04:01:21PM -0600, Romain Beauxis wrote:
> > > > ---
> > > >  tests/Makefile          |  1 +
> > > >  tests/fate/ogg-opus.mak | 11 +++++++++++
> > > >  2 files changed, 12 insertions(+)
> > > >  create mode 100644 tests/fate/ogg-opus.mak
> > > >
> > > > diff --git a/tests/Makefile b/tests/Makefile
> > > > index a37f2ab587..75b9bcc729 100644
> > > > --- a/tests/Makefile
> > > > +++ b/tests/Makefile
> > > > @@ -221,6 +221,7 @@ include $(SRC_PATH)/tests/fate/mpegts.mak
> > > >  include $(SRC_PATH)/tests/fate/mxf.mak
> > > >  include $(SRC_PATH)/tests/fate/ogg-vorbis.mak
> > > >  include $(SRC_PATH)/tests/fate/ogg-flac.mak
> > > > +include $(SRC_PATH)/tests/fate/ogg-opus.mak
> > > >  include $(SRC_PATH)/tests/fate/oma.mak
> > > >  include $(SRC_PATH)/tests/fate/opus.mak
> > > >  include $(SRC_PATH)/tests/fate/pcm.mak
> > > > diff --git a/tests/fate/ogg-opus.mak b/tests/fate/ogg-opus.mak
> > > > new file mode 100644
> > > > index 0000000000..75cb15bc05
> > > > --- /dev/null
> > > > +++ b/tests/fate/ogg-opus.mak
> > > > @@ -0,0 +1,11 @@
> > > > +FATE_OGG_OPUS += fate-ogg-opus-chained-meta
> > > > +fate-ogg-opus-chained-meta: REF = $(SAMPLES)/ogg-opus/chained-meta.txt
> > > > +fate-ogg-opus-chained-meta: CMD = $(APITESTSDIR)/api-dump-stream-meta-test$(EXESUF) $(TARGET_SAMPLES)/ogg-opus/chained-meta.ogg
> > > > +
> > > > +FATE_OGG_OPUS-$(call DEMDEC, OGG, OPUS) += $(FATE_OGG_OPUS)
> > > > +
> > > > +FATE_SAMPLES_DUMP_STREAM_META += $(FATE_OGG_OPUS-yes)
> > > > +
> > > > +FATE_EXTERN += $(FATE_OGG_OPUS-yes)
> > > > +
> > > > +fate-ogg-opus: $(FATE_OGG_OPUS-yes)
> > >
> > > fails on mingw64
> > >
> > > --- src/tests/ref/fate/ogg-opus-chained-meta.txt      2025-03-16 23:56:34.170930298 +0100
> > > +++ tests/data/fate/ogg-opus-chained-meta     2025-03-17 01:08:35.230686947 +0100
> > > @@ -1,27 +0,0 @@
> > > -Stream ID: 0, codec name: opus, metadata: encoder=Lavc61.19.100 libopus:title=First Stream
> > > -Stream ID: 0, packet PTS: -312, packet DTS: -312
> > > -Stream ID: 0, new metadata: encoder=Lavc61.19.100 libopus:title=First Stream
> > > -Stream ID: 0, frame PTS: -312, metadata:
> > > -Stream ID: 0, packet PTS: 648, packet DTS: 648
> > > -Stream ID: 0, frame PTS: 648, metadata:
> > > -Stream ID: 0, packet PTS: 1608, packet DTS: 1608
> > > -Stream ID: 0, frame PTS: 1608, metadata:
> > > -Stream ID: 0, packet PTS: 2568, packet DTS: 2568
> > > -Stream ID: 0, frame PTS: 2568, metadata:
> > > -Stream ID: 0, packet PTS: 3528, packet DTS: 3528
> > > -Stream ID: 0, frame PTS: 3528, metadata:
> > > -Stream ID: 0, packet PTS: 4488, packet DTS: 4488
> > > -Stream ID: 0, frame PTS: 4488, metadata:
> > > -Stream ID: 0, packet PTS: -312, packet DTS: -312
> > > -Stream ID: 0, new metadata: encoder=Lavc61.19.100 libopus:title=Second Stream
> > > -Stream ID: 0, frame PTS: -312, metadata: encoder=Lavc61.19.100 libopus:title=Second Stream
> > > -Stream ID: 0, packet PTS: 648, packet DTS: 648
> > > -Stream ID: 0, frame PTS: 648, metadata:
> > > -Stream ID: 0, packet PTS: 1608, packet DTS: 1608
> > > -Stream ID: 0, frame PTS: 1608, metadata:
> > > -Stream ID: 0, packet PTS: 2568, packet DTS: 2568
> > > -Stream ID: 0, frame PTS: 2568, metadata:
> > > -Stream ID: 0, packet PTS: 3528, packet DTS: 3528
> > > -Stream ID: 0, frame PTS: 3528, metadata:
> > > -Stream ID: 0, packet PTS: 4488, packet DTS: 4488
> > > -Stream ID: 0, frame PTS: 4488, metadata:
> > > Test ogg-opus-chained-meta failed. Look at tests/data/fate/ogg-opus-chained-meta.err for details.
> > > src/tests/fate-run.sh: 1: eval: tests/api/api-dump-stream-meta-test.exe: Exec format error
> > > threads=1
> > > make: *** [src/tests/Makefile:315: fate-ogg-opus-chained-meta] Error 2
> > >
> > > wine tests/api/api-dump-stream-meta-test.exe
> > > vs.
> > > tests/api/api-dump-stream-meta-test.exe
> >
> > similar issue on mips (qemu instead of wine)
> 
> Thanks for pointing that out.
> 
> Is there documentation of the list of host/target that need to pass
> for FATE tests to be accepted?
> 
> Do they need to be native host? Cross-compiled targets?

The idea is that what worked before should continue working.
https://fate.ffmpeg.org/
is probably a good list of what worked

but generally if code works for you it will work on all other platforms
theres no need to test on platforms other than yours, unless you want
or in a case where an issue is found (like here) or expected

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Whats the most studid thing your enemy could do ? Blow himself up
Whats the most studid thing you could do ? Give up your rights and
freedom because your enemy blew himself up.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".