[FFmpeg-devel] [PATCH] ffmpeg_demux: set default for readrate_catchup to be 5% faster

[FFmpeg-devel] [PATCH] ffmpeg_demux: set default for readrate_catchup to be 5% faster

[Gyan Doshi]

The existing default value is the same as the primary readrate.
This maintains the flow rate as best as possible but does not
reduce the lag. This new value allows catchup to gradually happen
without overwhelming the receiver.

Addresses a concern brought up in #11469
---
 fftools/ffmpeg_demux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c
index b8171e336e..23216f6c13 100644
--- a/fftools/ffmpeg_demux.c
+++ b/fftools/ffmpeg_demux.c
@@ -1892,7 +1892,7 @@ int ifile_open(const OptionsContext *o, const char *filename, Scheduler *sch)
                    d->readrate_initial_burst);
             return AVERROR(EINVAL);
         }
-        d->readrate_catchup = o->readrate_catchup ? o->readrate_catchup : d->readrate;
+        d->readrate_catchup = o->readrate_catchup ? o->readrate_catchup : d->readrate * 1.05;
         if (d->readrate_catchup < d->readrate) {
             av_log(d, AV_LOG_ERROR,
                    "Option -readrate_catchup is %0.3f; it must be at least equal to %0.3f.\n",
-- 
2.46.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] ffmpeg_demux: set default for readrate_catchup to be 5% faster

[Gyan Doshi]

On 2025-03-19 04:36 pm, Gyan Doshi wrote:
> The existing default value is the same as the primary readrate.
> This maintains the flow rate as best as possible but does not
> reduce the lag. This new value allows catchup to gradually happen
> without overwhelming the receiver.
>
> Addresses a concern brought up in #11469

Plan to push tomorrow.

Regards,
Gyan

> ---
>   fftools/ffmpeg_demux.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c
> index b8171e336e..23216f6c13 100644
> --- a/fftools/ffmpeg_demux.c
> +++ b/fftools/ffmpeg_demux.c
> @@ -1892,7 +1892,7 @@ int ifile_open(const OptionsContext *o, const char *filename, Scheduler *sch)
>                      d->readrate_initial_burst);
>               return AVERROR(EINVAL);
>           }
> -        d->readrate_catchup = o->readrate_catchup ? o->readrate_catchup : d->readrate;
> +        d->readrate_catchup = o->readrate_catchup ? o->readrate_catchup : d->readrate * 1.05;
>           if (d->readrate_catchup < d->readrate) {
>               av_log(d, AV_LOG_ERROR,
>                      "Option -readrate_catchup is %0.3f; it must be at least equal to %0.3f.\n",

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".