* [FFmpeg-devel] [PATCH v2] configure: improve ar test for response files
@ 2025-03-18 15:49 Gyan Doshi
2025-03-18 18:11 ` Marvin Scholz
2025-03-19 9:24 ` Martin Storsjö
0 siblings, 2 replies; 5+ messages in thread
From: Gyan Doshi @ 2025-03-18 15:49 UTC (permalink / raw)
To: ffmpeg-devel
---
configure | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/configure b/configure
index d84e32196d..14f7bcde0e 100755
--- a/configure
+++ b/configure
@@ -5230,12 +5230,6 @@ else
ar_o='$@'
fi
-if $ar 2>&1 | grep -qi "@.*file"; then
- ar_objs="true"
-else
- ar_objs=""
-fi
-
add_cflags $extra_cflags
add_cxxflags $extra_cxxflags
add_objcflags $extra_objcflags
@@ -7759,6 +7753,13 @@ case $ld_type in
;;
esac
+{
+ar_out=${FFTMPDIR}/test$LIBSUF
+respfile="@/dev/null"
+out_arg="$(echo $ar_o | sed "s;\$@;$ar_out;g")"
+test_cmd $ar $arflags $out_arg $respfile && ar_objs="true" || ar_objs=""
+}
+
enable frame_thread_encoder
enabled asm || { arch=c; disable $ARCH_LIST $ARCH_EXT_LIST; }
--
2.46.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [FFmpeg-devel] [PATCH v2] configure: improve ar test for response files
2025-03-18 15:49 [FFmpeg-devel] [PATCH v2] configure: improve ar test for response files Gyan Doshi
@ 2025-03-18 18:11 ` Marvin Scholz
2025-03-18 18:28 ` Timo Rothenpieler
2025-03-19 9:24 ` Martin Storsjö
1 sibling, 1 reply; 5+ messages in thread
From: Marvin Scholz @ 2025-03-18 18:11 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On 18 Mar 2025, at 16:49, Gyan Doshi wrote:
> ---
> configure | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/configure b/configure
> index d84e32196d..14f7bcde0e 100755
> --- a/configure
> +++ b/configure
> @@ -5230,12 +5230,6 @@ else
> ar_o='$@'
> fi
>
> -if $ar 2>&1 | grep -qi "@.*file"; then
> - ar_objs="true"
> -else
> - ar_objs=""
> -fi
> -
> add_cflags $extra_cflags
> add_cxxflags $extra_cxxflags
> add_objcflags $extra_objcflags
> @@ -7759,6 +7753,13 @@ case $ld_type in
> ;;
> esac
>
> +{
> +ar_out=${FFTMPDIR}/test$LIBSUF
> +respfile="@/dev/null"
> +out_arg="$(echo $ar_o | sed "s;\$@;$ar_out;g")"
> +test_cmd $ar $arflags $out_arg $respfile && ar_objs="true" || ar_objs=""
> +}
Wouldn't that break on Windows where you don't have /dev/null?
> +
> enable frame_thread_encoder
>
> enabled asm || { arch=c; disable $ARCH_LIST $ARCH_EXT_LIST; }
> --
> 2.46.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [FFmpeg-devel] [PATCH v2] configure: improve ar test for response files
2025-03-18 18:11 ` Marvin Scholz
@ 2025-03-18 18:28 ` Timo Rothenpieler
0 siblings, 0 replies; 5+ messages in thread
From: Timo Rothenpieler @ 2025-03-18 18:28 UTC (permalink / raw)
To: ffmpeg-devel
On 18.03.2025 19:11, Marvin Scholz wrote:
>
>
> On 18 Mar 2025, at 16:49, Gyan Doshi wrote:
>
>> ---
>> configure | 13 +++++++------
>> 1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/configure b/configure
>> index d84e32196d..14f7bcde0e 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5230,12 +5230,6 @@ else
>> ar_o='$@'
>> fi
>>
>> -if $ar 2>&1 | grep -qi "@.*file"; then
>> - ar_objs="true"
>> -else
>> - ar_objs=""
>> -fi
>> -
>> add_cflags $extra_cflags
>> add_cxxflags $extra_cxxflags
>> add_objcflags $extra_objcflags
>> @@ -7759,6 +7753,13 @@ case $ld_type in
>> ;;
>> esac
>>
>> +{
>> +ar_out=${FFTMPDIR}/test$LIBSUF
>> +respfile="@/dev/null"
>> +out_arg="$(echo $ar_o | sed "s;\$@;$ar_out;g")"
>> +test_cmd $ar $arflags $out_arg $respfile && ar_objs="true" || ar_objs=""
>> +}
>
> Wouldn't that break on Windows where you don't have /dev/null?
Every single bash/sh environment for Windows provides the standard dev
nodes.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2] configure: improve ar test for response files
2025-03-18 15:49 [FFmpeg-devel] [PATCH v2] configure: improve ar test for response files Gyan Doshi
2025-03-18 18:11 ` Marvin Scholz
@ 2025-03-19 9:24 ` Martin Storsjö
2025-03-19 10:13 ` Gyan Doshi
1 sibling, 1 reply; 5+ messages in thread
From: Martin Storsjö @ 2025-03-19 9:24 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Tue, 18 Mar 2025, Gyan Doshi wrote:
> ---
> configure | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/configure b/configure
> index d84e32196d..14f7bcde0e 100755
> --- a/configure
> +++ b/configure
> @@ -5230,12 +5230,6 @@ else
> ar_o='$@'
> fi
>
> -if $ar 2>&1 | grep -qi "@.*file"; then
> - ar_objs="true"
> -else
> - ar_objs=""
> -fi
> -
> add_cflags $extra_cflags
> add_cxxflags $extra_cxxflags
> add_objcflags $extra_objcflags
> @@ -7759,6 +7753,13 @@ case $ld_type in
> ;;
> esac
>
> +{
> +ar_out=${FFTMPDIR}/test$LIBSUF
> +respfile="@/dev/null"
> +out_arg="$(echo $ar_o | sed "s;\$@;$ar_out;g")"
> +test_cmd $ar $arflags $out_arg $respfile && ar_objs="true" || ar_objs=""
> +}
> +
> enable frame_thread_encoder
LGTM, thanks!
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [FFmpeg-devel] [PATCH v2] configure: improve ar test for response files
2025-03-19 9:24 ` Martin Storsjö
@ 2025-03-19 10:13 ` Gyan Doshi
0 siblings, 0 replies; 5+ messages in thread
From: Gyan Doshi @ 2025-03-19 10:13 UTC (permalink / raw)
To: ffmpeg-devel
On 2025-03-19 02:54 pm, Martin Storsjö wrote:
> On Tue, 18 Mar 2025, Gyan Doshi wrote:
>
>> ---
>> configure | 13 +++++++------
>> 1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/configure b/configure
>> index d84e32196d..14f7bcde0e 100755
>> --- a/configure
>> +++ b/configure
>> @@ -5230,12 +5230,6 @@ else
>> ar_o='$@'
>> fi
>>
>> -if $ar 2>&1 | grep -qi "@.*file"; then
>> - ar_objs="true"
>> -else
>> - ar_objs=""
>> -fi
>> -
>> add_cflags $extra_cflags
>> add_cxxflags $extra_cxxflags
>> add_objcflags $extra_objcflags
>> @@ -7759,6 +7753,13 @@ case $ld_type in
>> ;;
>> esac
>>
>> +{
>> +ar_out=${FFTMPDIR}/test$LIBSUF
>> +respfile="@/dev/null"
>> +out_arg="$(echo $ar_o | sed "s;\$@;$ar_out;g")"
>> +test_cmd $ar $arflags $out_arg $respfile && ar_objs="true" ||
>> ar_objs=""
>> +}
>> +
>> enable frame_thread_encoder
>
> LGTM, thanks!
Thanks. Pushed as b75b568b3d290ce827b80568ced1d68c277309e6
Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-03-19 10:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-18 15:49 [FFmpeg-devel] [PATCH v2] configure: improve ar test for response files Gyan Doshi
2025-03-18 18:11 ` Marvin Scholz
2025-03-18 18:28 ` Timo Rothenpieler
2025-03-19 9:24 ` Martin Storsjö
2025-03-19 10:13 ` Gyan Doshi
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git