From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 39F824D034
	for <ffmpegdev@gitmailbox.com>; Mon, 17 Mar 2025 00:18:42 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DD53A68D203;
	Mon, 17 Mar 2025 02:18:37 +0200 (EET)
Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net
 [217.70.183.201])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BCE0D687D16
 for <ffmpeg-devel@ffmpeg.org>; Mon, 17 Mar 2025 02:18:31 +0200 (EET)
Received: by mail.gandi.net (Postfix) with ESMTPSA id 272C743400
 for <ffmpeg-devel@ffmpeg.org>; Mon, 17 Mar 2025 00:18:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
 s=gm1; t=1742170711;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=HcDy2RtmUcg+vS2IqqYHMRTMvXKaAQmLC5Ro1tipfXI=;
 b=VmHF53oYJgEpJKwC2OG4zRS7cbbgKuxEAN8U6G1Y91PkfU+ElC87IOJPMA2r+74bMNsv0F
 pDmd78kK1B5D1pT3UDUVRyMZEB4+SF7MoG6wd3h5enajVAE4G6vs4U6h6RL2UeY2TkmygP
 UjGxQ8QSOByjA624dDGcdIMikOHnHv/hS5ayGPmlOW2Sbo1ktJ6cr0hMe7+x7NLEQsmQEH
 tjUUpkaypcGRQ+lse/xGPsX82PgrRO0p51EXoZsd8ajebU2WUAE3nuAxfM5dE94VXnV7wv
 rWqCrLKkrymdtMevI/Z91H+kQi9imkX1XrvAmdP3U4DlkvJaCtd/CLhArAalYA==
Date: Mon, 17 Mar 2025 01:18:30 +0100
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20250317001830.GX4991@pb2>
References: <20250225220121.98449-1-romain.beauxis@gmail.com>
 <20250225220121.98449-9-romain.beauxis@gmail.com>
 <20250317001151.GW4991@pb2>
MIME-Version: 1.0
In-Reply-To: <20250317001151.GW4991@pb2>
X-GND-State: clean
X-GND-Score: -70
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddufeektdefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH v7 8/8] tests: Add chained ogg/opus
 stream dump test.
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============3588673510363857306=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250317001830.GX4991@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


--===============3588673510363857306==
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="RIRIM3owv9lvlXEV"
Content-Disposition: inline


--RIRIM3owv9lvlXEV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 17, 2025 at 01:11:51AM +0100, Michael Niedermayer wrote:
> On Tue, Feb 25, 2025 at 04:01:21PM -0600, Romain Beauxis wrote:
> > ---
> >  tests/Makefile          |  1 +
> >  tests/fate/ogg-opus.mak | 11 +++++++++++
> >  2 files changed, 12 insertions(+)
> >  create mode 100644 tests/fate/ogg-opus.mak
> >=20
> > diff --git a/tests/Makefile b/tests/Makefile
> > index a37f2ab587..75b9bcc729 100644
> > --- a/tests/Makefile
> > +++ b/tests/Makefile
> > @@ -221,6 +221,7 @@ include $(SRC_PATH)/tests/fate/mpegts.mak
> >  include $(SRC_PATH)/tests/fate/mxf.mak
> >  include $(SRC_PATH)/tests/fate/ogg-vorbis.mak
> >  include $(SRC_PATH)/tests/fate/ogg-flac.mak
> > +include $(SRC_PATH)/tests/fate/ogg-opus.mak
> >  include $(SRC_PATH)/tests/fate/oma.mak
> >  include $(SRC_PATH)/tests/fate/opus.mak
> >  include $(SRC_PATH)/tests/fate/pcm.mak
> > diff --git a/tests/fate/ogg-opus.mak b/tests/fate/ogg-opus.mak
> > new file mode 100644
> > index 0000000000..75cb15bc05
> > --- /dev/null
> > +++ b/tests/fate/ogg-opus.mak
> > @@ -0,0 +1,11 @@
> > +FATE_OGG_OPUS +=3D fate-ogg-opus-chained-meta
> > +fate-ogg-opus-chained-meta: REF =3D $(SAMPLES)/ogg-opus/chained-meta.t=
xt
> > +fate-ogg-opus-chained-meta: CMD =3D $(APITESTSDIR)/api-dump-stream-met=
a-test$(EXESUF) $(TARGET_SAMPLES)/ogg-opus/chained-meta.ogg
> > +
> > +FATE_OGG_OPUS-$(call DEMDEC, OGG, OPUS) +=3D $(FATE_OGG_OPUS)
> > +
> > +FATE_SAMPLES_DUMP_STREAM_META +=3D $(FATE_OGG_OPUS-yes)
> > +
> > +FATE_EXTERN +=3D $(FATE_OGG_OPUS-yes)
> > +
> > +fate-ogg-opus: $(FATE_OGG_OPUS-yes)
>=20
> fails on mingw64
>=20
> --- src/tests/ref/fate/ogg-opus-chained-meta.txt	2025-03-16 23:56:34.1709=
30298 +0100
> +++ tests/data/fate/ogg-opus-chained-meta	2025-03-17 01:08:35.230686947 +=
0100
> @@ -1,27 +0,0 @@
> -Stream ID: 0, codec name: opus, metadata: encoder=3DLavc61.19.100 libopu=
s:title=3DFirst Stream
> -Stream ID: 0, packet PTS: -312, packet DTS: -312
> -Stream ID: 0, new metadata: encoder=3DLavc61.19.100 libopus:title=3DFirs=
t Stream
> -Stream ID: 0, frame PTS: -312, metadata:
> -Stream ID: 0, packet PTS: 648, packet DTS: 648
> -Stream ID: 0, frame PTS: 648, metadata:
> -Stream ID: 0, packet PTS: 1608, packet DTS: 1608
> -Stream ID: 0, frame PTS: 1608, metadata:
> -Stream ID: 0, packet PTS: 2568, packet DTS: 2568
> -Stream ID: 0, frame PTS: 2568, metadata:
> -Stream ID: 0, packet PTS: 3528, packet DTS: 3528
> -Stream ID: 0, frame PTS: 3528, metadata:
> -Stream ID: 0, packet PTS: 4488, packet DTS: 4488
> -Stream ID: 0, frame PTS: 4488, metadata:
> -Stream ID: 0, packet PTS: -312, packet DTS: -312
> -Stream ID: 0, new metadata: encoder=3DLavc61.19.100 libopus:title=3DSeco=
nd Stream
> -Stream ID: 0, frame PTS: -312, metadata: encoder=3DLavc61.19.100 libopus=
:title=3DSecond Stream
> -Stream ID: 0, packet PTS: 648, packet DTS: 648
> -Stream ID: 0, frame PTS: 648, metadata:
> -Stream ID: 0, packet PTS: 1608, packet DTS: 1608
> -Stream ID: 0, frame PTS: 1608, metadata:
> -Stream ID: 0, packet PTS: 2568, packet DTS: 2568
> -Stream ID: 0, frame PTS: 2568, metadata:
> -Stream ID: 0, packet PTS: 3528, packet DTS: 3528
> -Stream ID: 0, frame PTS: 3528, metadata:
> -Stream ID: 0, packet PTS: 4488, packet DTS: 4488
> -Stream ID: 0, frame PTS: 4488, metadata:
> Test ogg-opus-chained-meta failed. Look at tests/data/fate/ogg-opus-chain=
ed-meta.err for details.
> src/tests/fate-run.sh: 1: eval: tests/api/api-dump-stream-meta-test.exe: =
Exec format error
> threads=3D1
> make: *** [src/tests/Makefile:315: fate-ogg-opus-chained-meta] Error 2
>=20
> wine tests/api/api-dump-stream-meta-test.exe
> vs.
> tests/api/api-dump-stream-meta-test.exe

similar issue on mips (qemu instead of wine)

[...]

--=20
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
than the original author, trying to rewrite it will not make it better.

--RIRIM3owv9lvlXEV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ9dqVgAKCRBhHseHBAsP
q84RAJ9cbMbaxdGuAXnTatCry7CDUucYlQCbBIsWY0CWI6NxoHGoRGIThJm/SDQ=
=cCCx
-----END PGP SIGNATURE-----

--RIRIM3owv9lvlXEV--

--===============3588673510363857306==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

--===============3588673510363857306==--