From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v7 8/8] tests: Add chained ogg/opus stream dump test.
Date: Mon, 17 Mar 2025 01:18:30 +0100
Message-ID: <20250317001830.GX4991@pb2> (raw)
In-Reply-To: <20250317001151.GW4991@pb2>
[-- Attachment #1.1: Type: text/plain, Size: 4007 bytes --]
On Mon, Mar 17, 2025 at 01:11:51AM +0100, Michael Niedermayer wrote:
> On Tue, Feb 25, 2025 at 04:01:21PM -0600, Romain Beauxis wrote:
> > ---
> > tests/Makefile | 1 +
> > tests/fate/ogg-opus.mak | 11 +++++++++++
> > 2 files changed, 12 insertions(+)
> > create mode 100644 tests/fate/ogg-opus.mak
> >
> > diff --git a/tests/Makefile b/tests/Makefile
> > index a37f2ab587..75b9bcc729 100644
> > --- a/tests/Makefile
> > +++ b/tests/Makefile
> > @@ -221,6 +221,7 @@ include $(SRC_PATH)/tests/fate/mpegts.mak
> > include $(SRC_PATH)/tests/fate/mxf.mak
> > include $(SRC_PATH)/tests/fate/ogg-vorbis.mak
> > include $(SRC_PATH)/tests/fate/ogg-flac.mak
> > +include $(SRC_PATH)/tests/fate/ogg-opus.mak
> > include $(SRC_PATH)/tests/fate/oma.mak
> > include $(SRC_PATH)/tests/fate/opus.mak
> > include $(SRC_PATH)/tests/fate/pcm.mak
> > diff --git a/tests/fate/ogg-opus.mak b/tests/fate/ogg-opus.mak
> > new file mode 100644
> > index 0000000000..75cb15bc05
> > --- /dev/null
> > +++ b/tests/fate/ogg-opus.mak
> > @@ -0,0 +1,11 @@
> > +FATE_OGG_OPUS += fate-ogg-opus-chained-meta
> > +fate-ogg-opus-chained-meta: REF = $(SAMPLES)/ogg-opus/chained-meta.txt
> > +fate-ogg-opus-chained-meta: CMD = $(APITESTSDIR)/api-dump-stream-meta-test$(EXESUF) $(TARGET_SAMPLES)/ogg-opus/chained-meta.ogg
> > +
> > +FATE_OGG_OPUS-$(call DEMDEC, OGG, OPUS) += $(FATE_OGG_OPUS)
> > +
> > +FATE_SAMPLES_DUMP_STREAM_META += $(FATE_OGG_OPUS-yes)
> > +
> > +FATE_EXTERN += $(FATE_OGG_OPUS-yes)
> > +
> > +fate-ogg-opus: $(FATE_OGG_OPUS-yes)
>
> fails on mingw64
>
> --- src/tests/ref/fate/ogg-opus-chained-meta.txt 2025-03-16 23:56:34.170930298 +0100
> +++ tests/data/fate/ogg-opus-chained-meta 2025-03-17 01:08:35.230686947 +0100
> @@ -1,27 +0,0 @@
> -Stream ID: 0, codec name: opus, metadata: encoder=Lavc61.19.100 libopus:title=First Stream
> -Stream ID: 0, packet PTS: -312, packet DTS: -312
> -Stream ID: 0, new metadata: encoder=Lavc61.19.100 libopus:title=First Stream
> -Stream ID: 0, frame PTS: -312, metadata:
> -Stream ID: 0, packet PTS: 648, packet DTS: 648
> -Stream ID: 0, frame PTS: 648, metadata:
> -Stream ID: 0, packet PTS: 1608, packet DTS: 1608
> -Stream ID: 0, frame PTS: 1608, metadata:
> -Stream ID: 0, packet PTS: 2568, packet DTS: 2568
> -Stream ID: 0, frame PTS: 2568, metadata:
> -Stream ID: 0, packet PTS: 3528, packet DTS: 3528
> -Stream ID: 0, frame PTS: 3528, metadata:
> -Stream ID: 0, packet PTS: 4488, packet DTS: 4488
> -Stream ID: 0, frame PTS: 4488, metadata:
> -Stream ID: 0, packet PTS: -312, packet DTS: -312
> -Stream ID: 0, new metadata: encoder=Lavc61.19.100 libopus:title=Second Stream
> -Stream ID: 0, frame PTS: -312, metadata: encoder=Lavc61.19.100 libopus:title=Second Stream
> -Stream ID: 0, packet PTS: 648, packet DTS: 648
> -Stream ID: 0, frame PTS: 648, metadata:
> -Stream ID: 0, packet PTS: 1608, packet DTS: 1608
> -Stream ID: 0, frame PTS: 1608, metadata:
> -Stream ID: 0, packet PTS: 2568, packet DTS: 2568
> -Stream ID: 0, frame PTS: 2568, metadata:
> -Stream ID: 0, packet PTS: 3528, packet DTS: 3528
> -Stream ID: 0, frame PTS: 3528, metadata:
> -Stream ID: 0, packet PTS: 4488, packet DTS: 4488
> -Stream ID: 0, frame PTS: 4488, metadata:
> Test ogg-opus-chained-meta failed. Look at tests/data/fate/ogg-opus-chained-meta.err for details.
> src/tests/fate-run.sh: 1: eval: tests/api/api-dump-stream-meta-test.exe: Exec format error
> threads=1
> make: *** [src/tests/Makefile:315: fate-ogg-opus-chained-meta] Error 2
>
> wine tests/api/api-dump-stream-meta-test.exe
> vs.
> tests/api/api-dump-stream-meta-test.exe
similar issue on mips (qemu instead of wine)
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
than the original author, trying to rewrite it will not make it better.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-03-17 0:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 22:01 [FFmpeg-devel] [PATCH v7 0/8] Properly decode ogg metadata in ogg/{vorbis, flac, opus} chained bitstreams Romain Beauxis
2025-02-25 22:01 ` [FFmpeg-devel] [PATCH v7 1/8] Add generic metadata injection using AV_PKT_DATA_METADATA_UPDATE Romain Beauxis
2025-03-09 18:31 ` Michael Niedermayer
2025-03-10 13:50 ` Romain Beauxis
2025-03-10 20:46 ` Michael Niedermayer
2025-03-10 21:21 ` Romain Beauxis
2025-03-10 7:13 ` Andreas Rheinhardt
2025-03-10 13:49 ` Romain Beauxis
2025-02-25 22:01 ` [FFmpeg-devel] [PATCH v7 2/8] tests: Add stream dump test API util Romain Beauxis
2025-02-25 22:01 ` [FFmpeg-devel] [PATCH v7 3/8] tests: Add chained ogg/vorbis stream dump test Romain Beauxis
2025-02-25 22:03 ` Romain Beauxis
2025-02-25 22:01 ` [FFmpeg-devel] [PATCH v7 4/8] libavformat/oggdec.h, libavformat/oggparsevorbis.c: Factor out vorbis metadata update mechanism Romain Beauxis
2025-02-25 22:01 ` [FFmpeg-devel] [PATCH v7 5/8] libavformat/oggparseflac.c: Parse ogg/flac comments in new ogg packets, add them to ogg stream new_metadata Romain Beauxis
2025-02-25 22:01 ` [FFmpeg-devel] [PATCH v7 6/8] tests: Add chained ogg/flac stream dump test Romain Beauxis
2025-02-25 22:01 ` [FFmpeg-devel] [PATCH v7 7/8] libavformat/oggparseopus.c: Parse comments from secondary chained streams header packet Romain Beauxis
2025-02-25 22:01 ` [FFmpeg-devel] [PATCH v7 8/8] tests: Add chained ogg/opus stream dump test Romain Beauxis
2025-03-17 0:11 ` Michael Niedermayer
2025-03-17 0:18 ` Michael Niedermayer [this message]
2025-03-17 1:03 ` Romain Beauxis
2025-02-28 19:54 ` [FFmpeg-devel] [PATCH v7 0/8] Properly decode ogg metadata in ogg/{vorbis, flac, opus} chained bitstreams Romain Beauxis
2025-03-07 22:03 ` Romain Beauxis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250317001830.GX4991@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git