From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id BCE914E7AB for <ffmpegdev@gitmailbox.com>; Sun, 16 Mar 2025 00:20:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3348668DF26; Sun, 16 Mar 2025 02:20:24 +0200 (EET) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2074D68DD8D for <ffmpeg-devel@ffmpeg.org>; Sun, 16 Mar 2025 02:20:18 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 519EB432FA for <ffmpeg-devel@ffmpeg.org>; Sun, 16 Mar 2025 00:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1742084417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EdlSiZ9V743tMDr246nw4W3k0WUEzSZq4PCu86YQ+uw=; b=XrHgm9l6lBI2+qjaqGTHPMVNLBqt6XXPV25oEOrTfko861Umc/f1JIYdNYzGYISWcHMJFB yZTDlvBXVY5VjjAzuFHgMz6HfJ38ETu7t/x8Sn9S+0IhIPZR5zXWRCnjSNaf1/cc5nqI50 MztDTQ4DQOrkLJmVqw00RA3sEXWxc9GPyoRXkvzTTVyr5xUmYkwC5mFF7GeKVivjam18YH pkLjs0SPBI61QhulLh4yfDtBcnSSmotQwr7AsDMg7b9Zg/RUVIa6ex7R90AApcLNkmdIvH CzMhTn55Le3RWRKz893oF7fP0qh7fiq6hHJn/vLDlblGZgGlSedz9YuyWDErXQ== Date: Sun, 16 Mar 2025 01:20:16 +0100 From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Message-ID: <20250316002016.GU4991@pb2> References: <20250314020809.14220-1-jamrial@gmail.com> <20250315233517.GR4991@pb2> <eb0635bf-96f7-4943-8064-1bfafdf1ca39@gmail.com> <20250315234201.GS4991@pb2> <dd409999-f134-4dca-92e5-3e247e88a934@gmail.com> MIME-Version: 1.0 In-Reply-To: <dd409999-f134-4dca-92e5-3e247e88a934@gmail.com> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddufeehudegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avcodec/exrdec: restore applying color transfer characteristics for float16 samples X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: multipart/mixed; boundary="===============1276889373201818389==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250316002016.GU4991@pb2/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> --===============1276889373201818389== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gj7VWzII++aCOTNo" Content-Disposition: inline --gj7VWzII++aCOTNo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 15, 2025 at 09:09:08PM -0300, James Almer wrote: > On 3/15/2025 8:42 PM, Michael Niedermayer wrote: > > Hi > >=20 > > On Sat, Mar 15, 2025 at 08:36:33PM -0300, James Almer wrote: > > > On 3/15/2025 8:35 PM, Michael Niedermayer wrote: > > > > Hi > > > >=20 > > > > On Thu, Mar 13, 2025 at 11:08:09PM -0300, James Almer wrote: > > > > > Regression since 0e917389fe73c932049635d947bba076f1709589. > > > > > This change also reverts commit 431805c096738da7661a0baee2b12fe97= 24dcc95. > > > > >=20 > > > > > Signed-off-by: James Almer <jamrial@gmail.com> > > > > > --- > > > > > libavcodec/exr.c | 38 ++++++++++++++++++++++++++++++++++++-- > > > > > 1 file changed, 36 insertions(+), 2 deletions(-) > > > >=20 > > > > We dont do that for any other codec. > > > > For every other case we export all the color and gamma information > > > > but do not modify the sample values to some "normalized" representa= tion > > > >=20 > > > > Its also lossy to do it in the decoder like this > > > >=20 > > > > thx > > > We're still doing it for the float path, so in that case you may want= to > > > remove it from there too. > >=20 > > I think we should remove it, but I think I have no samples for that cod= e path. > > So i would not be able to test ... > >=20 > > thx >=20 > Even with no samples it should be a straightforward change. > But even then, since this feature includes two AVOptions that would be > broken after such removal (and in fact currently are for half float > samples), we should IMO deprecate them and remove the feature once the > options are gone. That includes applying this patch to restore the > functionality with half float samples. sure, feel free to restore it and deprecate them if thats whatr people prefer thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What is kyc? Its a tool that makes you give out your real ID, while crimina= ls give out a forged ID card. --gj7VWzII++aCOTNo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ9YZPwAKCRBhHseHBAsP q4A0AJ4t6tz+B8txcmzfaF/Y8a2d1cZADQCghH+ToasrGxjw4k3DL22kZBehLMk= =6djA -----END PGP SIGNATURE----- --gj7VWzII++aCOTNo-- --===============1276889373201818389== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1276889373201818389==--