From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/exrdec: restore applying color transfer characteristics for float16 samples
Date: Sun, 16 Mar 2025 00:42:01 +0100
Message-ID: <20250315234201.GS4991@pb2> (raw)
In-Reply-To: <eb0635bf-96f7-4943-8064-1bfafdf1ca39@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1237 bytes --]
Hi
On Sat, Mar 15, 2025 at 08:36:33PM -0300, James Almer wrote:
> On 3/15/2025 8:35 PM, Michael Niedermayer wrote:
> > Hi
> >
> > On Thu, Mar 13, 2025 at 11:08:09PM -0300, James Almer wrote:
> > > Regression since 0e917389fe73c932049635d947bba076f1709589.
> > > This change also reverts commit 431805c096738da7661a0baee2b12fe9724dcc95.
> > >
> > > Signed-off-by: James Almer <jamrial@gmail.com>
> > > ---
> > > libavcodec/exr.c | 38 ++++++++++++++++++++++++++++++++++++--
> > > 1 file changed, 36 insertions(+), 2 deletions(-)
> >
> > We dont do that for any other codec.
> > For every other case we export all the color and gamma information
> > but do not modify the sample values to some "normalized" representation
> >
> > Its also lossy to do it in the decoder like this
> >
> > thx
> We're still doing it for the float path, so in that case you may want to
> remove it from there too.
I think we should remove it, but I think I have no samples for that code path.
So i would not be able to test ...
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-03-15 23:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 2:08 James Almer
2025-03-15 23:35 ` Michael Niedermayer
2025-03-15 23:36 ` James Almer
2025-03-15 23:42 ` Michael Niedermayer [this message]
2025-03-16 0:09 ` James Almer
2025-03-16 0:20 ` Michael Niedermayer
2025-03-16 0:30 ` [FFmpeg-devel] [PATCH] avcodec/exr: deprecate gamma and apply_trc options James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250315234201.GS4991@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git