[FFmpeg-devel] [PATCH] avcodec/vlc: Reduce debug logging

[FFmpeg-devel] [PATCH] avcodec/vlc: Reduce debug logging

[softworkz]

From: softworkz <softworkz@hotmail.com>

Signed-off-by: softworkz <softworkz@hotmail.com>
---
    avcodec/vlc: Reduce debug logging
    
    It made it hardly possible to enable debug logging for viewing other log
    lines due to the excessive output created by this.

Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-60%2Fsoftworkz%2Fsubmit_vlclogging-v1
Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-60/softworkz/submit_vlclogging-v1
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/60

 libavcodec/vlc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/vlc.c b/libavcodec/vlc.c
index f46ecbb55e..c49c801181 100644
--- a/libavcodec/vlc.c
+++ b/libavcodec/vlc.c
@@ -155,7 +155,7 @@ static int build_table(VLC *vlc, int table_nb_bits, int nb_codes,
         int         n = codes[i].bits;
         uint32_t code = codes[i].code;
         int    symbol = codes[i].symbol;
-        ff_dlog(NULL, "i=%d n=%d code=0x%"PRIx32"\n", i, n, code);
+        ff_tlog(NULL, "i=%d n=%d code=0x%"PRIx32"\n", i, n, code);
         if (n <= table_nb_bits) {
             /* no need to add another table */
             int   j = code >> (32 - table_nb_bits);
@@ -169,7 +169,7 @@ static int build_table(VLC *vlc, int table_nb_bits, int nb_codes,
             for (int k = 0; k < nb; k++) {
                 int   bits = table[j].len;
                 int oldsym = table[j].sym;
-                ff_dlog(NULL, "%4x: code=%d n=%d\n", j, i, n);
+                ff_tlog(NULL, "%4x: code=%d n=%d\n", j, i, n);
                 if ((bits || oldsym) && (bits != n || oldsym != symbol)) {
                     av_log(NULL, AV_LOG_ERROR, "incorrect codes\n");
                     return AVERROR_INVALIDDATA;

base-commit: 1bce40cb73fffd9d1fb6e118d71ac8999cded808
-- 
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/vlc: Reduce debug logging

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1177 bytes --]

Hi

On Wed, Mar 12, 2025 at 03:48:20AM +0000, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
> 
> Signed-off-by: softworkz <softworkz@hotmail.com>
> ---
>     avcodec/vlc: Reduce debug logging
>     
>     It made it hardly possible to enable debug logging for viewing other log
>     lines due to the excessive output created by this.
> 
> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-60%2Fsoftworkz%2Fsubmit_vlclogging-v1
> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-60/softworkz/submit_vlclogging-v1
> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/60
> 
>  libavcodec/vlc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

will apply

btw, speaking of excessive output,
valgrind_backtrace (which is enabled by default when optimizations are disabled)
is also a feature that is rarely useful but very annoying noise wise
(just saying in case anyone wants to reduce noise in general)

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/vlc: Reduce debug logging

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> Michael Niedermayer
> Sent: Freitag, 14. März 2025 01:28
> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vlc: Reduce debug logging
> 
> Hi
> 
> On Wed, Mar 12, 2025 at 03:48:20AM +0000, softworkz wrote:
> > From: softworkz <softworkz@hotmail.com>
> >
> > Signed-off-by: softworkz <softworkz@hotmail.com>
> > ---
> >     avcodec/vlc: Reduce debug logging
> >
> >     It made it hardly possible to enable debug logging for viewing
> other log
> >     lines due to the excessive output created by this.
> >
> > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-
> ffstaging-60%2Fsoftworkz%2Fsubmit_vlclogging-v1
> > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-
> ffstaging-60/softworkz/submit_vlclogging-v1
> > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/60
> >
> >  libavcodec/vlc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> will apply

Thanks!


> btw, speaking of excessive output,
> valgrind_backtrace (which is enabled by default when optimizations are
> disabled)

Only when you have it installed I suppose..? 
For me, it's 0 in config.h even after ./configure --disable-optimizations


> is also a feature that is rarely useful but very annoying noise wise
> (just saying in case anyone wants to reduce noise in general)

Might make sense to require it to enable explicitly.


What I meant by excessive in that case is that it exhausted the console buffer so that I couldn't even scroll back to ffmpeg startup and it took several seconds to react to break (q was hardly working at all), so it was an extreme case.

Thank you
sw



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/vlc: Reduce debug logging

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 2037 bytes --]

Hi

On Fri, Mar 14, 2025 at 03:46:35AM +0000, Soft Works wrote:
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> > Michael Niedermayer
> > Sent: Freitag, 14. März 2025 01:28
> > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vlc: Reduce debug logging
> > 
> > Hi
> > 
> > On Wed, Mar 12, 2025 at 03:48:20AM +0000, softworkz wrote:
> > > From: softworkz <softworkz@hotmail.com>
> > >
> > > Signed-off-by: softworkz <softworkz@hotmail.com>
> > > ---
> > >     avcodec/vlc: Reduce debug logging
> > >
> > >     It made it hardly possible to enable debug logging for viewing
> > other log
> > >     lines due to the excessive output created by this.
> > >
> > > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-
> > ffstaging-60%2Fsoftworkz%2Fsubmit_vlclogging-v1
> > > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-
> > ffstaging-60/softworkz/submit_vlclogging-v1
> > > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/60
> > >
> > >  libavcodec/vlc.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > will apply
> 
> Thanks!
> 
> 
> > btw, speaking of excessive output,
> > valgrind_backtrace (which is enabled by default when optimizations are
> > disabled)
> 
> Only when you have it installed I suppose..? 

yes

Combine that with myself often lazyly throwing av_log(0,0, ...) in as a quick
debug fprintf(stderr, ...
and the 0 log level then triggers the valgrind backtrace
For me its 99% of the time not what i want.

I wonder if other people use that backtrace feature ?
or if it would be better switched off by default, or
switched off for log_level == 0

or maybe i should just stop using av_log(0,0, ...

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".