Re: [FFmpeg-devel] [PATCH] avcodec/vlc: Reduce debug logging

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 2037 bytes --]

Hi

On Fri, Mar 14, 2025 at 03:46:35AM +0000, Soft Works wrote:
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> > Michael Niedermayer
> > Sent: Freitag, 14. März 2025 01:28
> > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vlc: Reduce debug logging
> > 
> > Hi
> > 
> > On Wed, Mar 12, 2025 at 03:48:20AM +0000, softworkz wrote:
> > > From: softworkz <softworkz@hotmail.com>
> > >
> > > Signed-off-by: softworkz <softworkz@hotmail.com>
> > > ---
> > >     avcodec/vlc: Reduce debug logging
> > >
> > >     It made it hardly possible to enable debug logging for viewing
> > other log
> > >     lines due to the excessive output created by this.
> > >
> > > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-
> > ffstaging-60%2Fsoftworkz%2Fsubmit_vlclogging-v1
> > > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-
> > ffstaging-60/softworkz/submit_vlclogging-v1
> > > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/60
> > >
> > >  libavcodec/vlc.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > will apply
> 
> Thanks!
> 
> 
> > btw, speaking of excessive output,
> > valgrind_backtrace (which is enabled by default when optimizations are
> > disabled)
> 
> Only when you have it installed I suppose..? 

yes

Combine that with myself often lazyly throwing av_log(0,0, ...) in as a quick
debug fprintf(stderr, ...
and the 0 log level then triggers the valgrind backtrace
For me its 99% of the time not what i want.

I wonder if other people use that backtrace feature ?
or if it would be better switched off by default, or
switched off for log_level == 0

or maybe i should just stop using av_log(0,0, ...

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".