From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 7E6854E6EC
for <ffmpegdev@gitmailbox.com>; Fri, 14 Mar 2025 00:47:31 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5CC3668DDBC;
Fri, 14 Mar 2025 02:47:27 +0200 (EET)
Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net
[217.70.183.198])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D20CB68D9E8
for <ffmpeg-devel@ffmpeg.org>; Fri, 14 Mar 2025 02:47:20 +0200 (EET)
Received: by mail.gandi.net (Postfix) with ESMTPSA id 2FD7E432B8
for <ffmpeg-devel@ffmpeg.org>; Fri, 14 Mar 2025 00:47:19 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
s=gm1; t=1741913240;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=A//oZWwMHXySwE8bNEVm0+Mo38VB2YoeB+GUegrvElE=;
b=KqBUZVp0E2NcBG/V1JaeQvq7e/xTwmti7nxTS6rRvaN6kQ8zT6NAoKIDrSZbjfwiymieou
a0Mb7C1q1G0ehaxYYhmgDlP9oigcbUHx7camlCEiul7P2H368CqappigXn9a0A+v5xBLx7
UyiTQfjX0qMs2VkMu6PbWg9XPhEa/JzvIPgcT9D831X3TMkWMnMKzS6DWP7n5C8RUJN+Q4
kGkjGNbXxvcj6hM8vBu6JE64AzbB0ML0n83+tMFCVFojMYYfe8g05M3ulvfAG2VtqKNhjH
ThhqeH/z5onk9ha7J2VuKzHzRh6diFt9oi1L0X5iy5lXUHyBVFrnNUqTwBB6DA==
Date: Fri, 14 Mar 2025 01:47:19 +0100
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20250314004719.GI4991@pb2>
References: <20250311140433.1658540-1-michael@niedermayer.cc>
<0b6e2295-f876-4bd8-bc7b-4307b46c02f3@mediaarea.net>
MIME-Version: 1.0
In-Reply-To: <0b6e2295-f876-4bd8-bc7b-4307b46c02f3@mediaarea.net>
X-GND-State: clean
X-GND-Score: -70
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvdelgedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddunecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpedutedvhfduuedugedufefghefhvedvgffgffekhfdvgfdvtefftdejkeehteefheenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ffv1: Implement jeromes idea of
making remap flip optional
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============7466546292416357630=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250314004719.GI4991@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
--===============7466546292416357630==
Content-Type: multipart/signed; micalg=pgp-sha512;
protocol="application/pgp-signature"; boundary="nylPYAQViKd1wrtv"
Content-Disposition: inline
--nylPYAQViKd1wrtv
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi Jerome
On Tue, Mar 11, 2025 at 04:33:11PM +0100, Jerome Martinez wrote:
> Le 11/03/2025 =E0 15:04, Michael Niedermayer a =E9crit=A0:
> > Re: [FFmpeg-devel] [PATCH] avcodec/ffv1: Implement jeromes idea of maki=
ng remap flip optional
>=20
> Thanks.
>=20
>=20
> > - if (sc->remap > 1U ||
> > - sc->remap =3D=3D 1 && !f->flt) {
> > + if (sc->remap > 2U ||
> > + sc->remap && !f->flt) {
> > av_log(f->avctx, AV_LOG_ERROR, "unsupported remap %d\=
n", sc->remap);
> > return AVERROR_INVALIDDATA;
> > }
>=20
> As the feature is now independent of f->flt, it seems that we can remove =
the
> "sc->remap && !f->flt" check, it should be supported with integers (actua=
lly
> whatever is the value of=A0!f->flt) too.
yes, as soon as someone tests and verifies it works with integers
>=20
>=20
> > + { "remap_mode", "Remap Mode", OFFSET(remap_mode), AV_OPT_TYPE_INT,=
{ .i64 =3D -1 }, -1, 2, VE, .unit =3D "remap_mode" },
> > + { "auto", "Automatic", 0, AV_OPT_TYPE_CONST,
> > + { .i64 =3D -1 }, INT_MIN, INT_MAX, VE, .unit =3D "remap_mo=
de" },
> > + { "off", "Disabled", 0, AV_OPT_TYPE_CONST,
> > + { .i64 =3D 0 }, INT_MIN, INT_MAX, VE, .unit =3D "remap_mo=
de" },
> > + { "dualrle", "Dual RLE", 0, AV_OPT_TYPE_CONST,
> > + { .i64 =3D 1 }, INT_MIN, INT_MAX, VE, .unit =3D "remap_mo=
de" },
> > + { "flipdualrle", "Dual RLE", 0, AV_OPT_TYPE_CONST,
> > + { .i64 =3D 2 }, INT_MIN, INT_MAX, VE, .unit =3D "remap_mo=
de" },
>=20
> Even better to have na option for it.
> LGTM.
will apply
thx
[...]
--=20
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
No snowflake in an avalanche ever feels responsible. -- Voltaire
--nylPYAQViKd1wrtv
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ9N8lwAKCRBhHseHBAsP
q6REAJ0exEDHJtdueCrHDYYekn0Wss0hCgCgnAt0WP5KuyAaKM9qZLBlV1fLkEY=
=hozx
-----END PGP SIGNATURE-----
--nylPYAQViKd1wrtv--
--===============7466546292416357630==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--===============7466546292416357630==--