From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/ffv1: Implement jeromes idea of making remap flip optional
Date: Fri, 14 Mar 2025 01:47:19 +0100
Message-ID: <20250314004719.GI4991@pb2> (raw)
In-Reply-To: <0b6e2295-f876-4bd8-bc7b-4307b46c02f3@mediaarea.net>
[-- Attachment #1.1: Type: text/plain, Size: 1800 bytes --]
Hi Jerome
On Tue, Mar 11, 2025 at 04:33:11PM +0100, Jerome Martinez wrote:
> Le 11/03/2025 à 15:04, Michael Niedermayer a écrit :
> > Re: [FFmpeg-devel] [PATCH] avcodec/ffv1: Implement jeromes idea of making remap flip optional
>
> Thanks.
>
>
> > - if (sc->remap > 1U ||
> > - sc->remap == 1 && !f->flt) {
> > + if (sc->remap > 2U ||
> > + sc->remap && !f->flt) {
> > av_log(f->avctx, AV_LOG_ERROR, "unsupported remap %d\n", sc->remap);
> > return AVERROR_INVALIDDATA;
> > }
>
> As the feature is now independent of f->flt, it seems that we can remove the
> "sc->remap && !f->flt" check, it should be supported with integers (actually
> whatever is the value of !f->flt) too.
yes, as soon as someone tests and verifies it works with integers
>
>
> > + { "remap_mode", "Remap Mode", OFFSET(remap_mode), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 2, VE, .unit = "remap_mode" },
> > + { "auto", "Automatic", 0, AV_OPT_TYPE_CONST,
> > + { .i64 = -1 }, INT_MIN, INT_MAX, VE, .unit = "remap_mode" },
> > + { "off", "Disabled", 0, AV_OPT_TYPE_CONST,
> > + { .i64 = 0 }, INT_MIN, INT_MAX, VE, .unit = "remap_mode" },
> > + { "dualrle", "Dual RLE", 0, AV_OPT_TYPE_CONST,
> > + { .i64 = 1 }, INT_MIN, INT_MAX, VE, .unit = "remap_mode" },
> > + { "flipdualrle", "Dual RLE", 0, AV_OPT_TYPE_CONST,
> > + { .i64 = 2 }, INT_MIN, INT_MAX, VE, .unit = "remap_mode" },
>
> Even better to have na option for it.
> LGTM.
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
No snowflake in an avalanche ever feels responsible. -- Voltaire
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-03-14 0:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 14:04 Michael Niedermayer
2025-03-11 15:33 ` Jerome Martinez
2025-03-14 0:47 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314004719.GI4991@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git