From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 2AAB14CBB6
	for <ffmpegdev@gitmailbox.com>; Thu, 13 Mar 2025 23:54:38 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B15EB68CC79;
	Fri, 14 Mar 2025 01:54:34 +0200 (EET)
Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net
 [217.70.183.195])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C86A668DA3B
 for <ffmpeg-devel@ffmpeg.org>; Fri, 14 Mar 2025 01:54:27 +0200 (EET)
Received: by mail.gandi.net (Postfix) with ESMTPSA id AEE1820479;
 Thu, 13 Mar 2025 23:54:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
 s=gm1; t=1741910067;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=NTUJivDO402cO4/4s2pSwfYtaCegVbULwj/XXKkqdE0=;
 b=EtRKiFSscORdlfXf+DvtlYiCrsl/xdLq3sNjbdZoeX1jW5aWSagBeBDSpsXqeB4anyhegx
 23o470hUqJj43RupWhupGOtDpu5PtzkfM/F1RM7TxMXFVWKOZIiE4WHBJO4243KIX60Vze
 bLp/2IST17R9b9uMGPJYUghLiOkjLsRAsNBcr2NuDPOAng8E/twPq4N8Jg3DCpGM7GTGgd
 JtVaoOurX9F1s/nqCs4zKTWVrLdEzD63VRQtW4wfFwvwS32J9OUr22OmLqs/VD5AsPCwLS
 G/DFzr8iU3G4QRMnuI/9yAG0JggsscSHryr2rQIo74auMeTJAi7sctkEgNNa5A==
Date: Fri, 14 Mar 2025 00:54:25 +0100
From: Michael Niedermayer <michael@niedermayer.cc>
To: ffmpeg-devel@ffmpeg.org, Niklas Haas <ffmpeg@haasn.xyz>
Message-ID: <20250313235425.GC4991@pb2>
References: <20241226193325.288834126EE@natalya.videolan.org>
 <20250126182659.GE2768425@pb2>
MIME-Version: 1.0
In-Reply-To: <20250126182659.GE2768425@pb2>
X-GND-State: clean
X-GND-Score: 10
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvdelfedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecufghrlhcuvffnffculddutddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeegvddujeffkeehffetgfdthfefudffheejheetgffghefflefgteffueehhfevheenucffohhmrghinhepvhhiuggvohhlrghnrdhorhhgnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrghdprhgtphhtthhopehffhhmphgvgheshhgrrghsnhdrgiihii
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] swscale: use 16-bit intermediate
 precision for RGB/XYZ conversion
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============5538209914647961171=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250313235425.GC4991@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


--===============5538209914647961171==
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="3z0SiqipXr+x6VH2"
Content-Disposition: inline


--3z0SiqipXr+x6VH2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi

On Sun, Jan 26, 2025 at 07:26:59PM +0100, Michael Niedermayer wrote:
> On Thu, Dec 26, 2024 at 07:33:23PM +0000, Niklas Haas wrote:
> > ffmpeg | branch: master | Niklas Haas <git@haasn.dev> | Mon Dec 16 14:4=
9:39 2024 +0100| [af6d52eec66961f6a502b0f2f390c12226d087cd] | committer: Ni=
klas Haas
> >=20
> > swscale: use 16-bit intermediate precision for RGB/XYZ conversion
> >=20
> > The current logic uses 12-bit linear light math, which is woefully insu=
fficient
> > and leads to nasty postarization artifacts. This patch simply switches =
the
> > internal logic to 16-bit precision.
> >=20
> > This raises the memory requirement of these tables from 32 kB to 272 kB.
> >=20
> > All relevant FATE tests updated for improved accuracy.
> >=20
> > Fixes: #4829
> > Signed-off-by: Niklas Haas <git@haasn.dev>
> > Sponsored-by: Sovereign Tech Fund
> >=20
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=3Dcommit;h=3Daf6d52e=
ec66961f6a502b0f2f390c12226d087cd
> > ---
>=20
> this breaks on x86-32

ping

the fate tests for a major architecture are broken since this
This impacts future bisections over that range for example

you can trivially test this on x86-64 with something like:
--cross-prefix=3D/usr/i686-linux-gnu/bin/ --cc=3D'ccache i686-linux-gnu-gcc=
-7' --arch=3Dx86_32  --target-os=3Dlinux --enable-cross-compile
if you have the correponding packages installed

before af6d52eec66961f6a502b0f2f390c12226d087cd
TEST    filter-pixdesc-xyz12be

after af6d52eec66961f6a502b0f2f390c12226d087cd:
--- src/tests/ref/fate/filter-pixdesc-xyz12be	2025-03-14 00:46:40.445681223=
 +0100
+++ tests/data/fate/filter-pixdesc-xyz12be	2025-03-14 00:47:08.301903796 +0=
100
@@ -1 +1 @@
-pixdesc-xyz12be     1508a33dea936c45d9ee13f7743af00d
+pixdesc-xyz12be     198f43f452bc55f4ca1e0e0171de5c4c
Test filter-pixdesc-xyz12be failed. Look at tests/data/fate/filter-pixdesc-=
xyz12be.err for details.
make: *** [src/tests/Makefile:311: fate-filter-pixdesc-xyz12be] Error 1

in master:
--- src/tests/ref/fate/filter-pixdesc-xyz12be	2025-03-14 00:46:40.445681223=
 +0100
+++ tests/data/fate/filter-pixdesc-xyz12be	2025-03-14 00:48:43.042660972 +0=
100
@@ -1 +1 @@
-pixdesc-xyz12be     1508a33dea936c45d9ee13f7743af00d
+pixdesc-xyz12be     198f43f452bc55f4ca1e0e0171de5c4c
Test filter-pixdesc-xyz12be failed. Look at tests/data/fate/filter-pixdesc-=
xyz12be.err for details.
make: *** [src/tests/Makefile:315: fate-filter-pixdesc-xyz12be] Error 1


thx

[...]

--=20
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Never trust a computer, one day, it may think you are the virus. -- Compn

--3z0SiqipXr+x6VH2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ9NwLgAKCRBhHseHBAsP
q6kmAJ9C8Ma/LqtyG4p3LYU5n46A1dFbzwCgmZ5UAjUElGcLPME8sC9/zrisU8s=
=jrRt
-----END PGP SIGNATURE-----

--3z0SiqipXr+x6VH2--

--===============5538209914647961171==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

--===============5538209914647961171==--