From: Manuel Lauss <manuel.lauss@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Manuel Lauss <manuel.lauss@gmail.com>
Subject: [FFmpeg-devel] [PATCH 4/9] avcodec/sanm: fix codec3
Date: Tue, 11 Mar 2025 16:03:36 +0100
Message-ID: <20250311150341.348678-4-manuel.lauss@gmail.com> (raw)
In-Reply-To: <20250311150341.348678-1-manuel.lauss@gmail.com>
codec3 is codec1 which writes zero values instead of skipping them.
This fixes a lot of RA1 videos.
Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
---
libavcodec/sanm.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavcodec/sanm.c b/libavcodec/sanm.c
index b2923515b1..a512810987 100644
--- a/libavcodec/sanm.c
+++ b/libavcodec/sanm.c
@@ -556,7 +556,7 @@ static int rle_decode(SANMVideoContext *ctx, uint8_t *dst, const int out_size)
}
static int old_codec1(SANMVideoContext *ctx, int top,
- int left, int width, int height)
+ int left, int width, int height, int opaque)
{
uint8_t *dst = ((uint8_t *)ctx->frm0) + left + top * ctx->pitch;
int i, j, len, flag, code, val, pos, end;
@@ -581,7 +581,7 @@ static int old_codec1(SANMVideoContext *ctx, int top,
return AVERROR_INVALIDDATA;
if (flag) {
val = bytestream2_get_byteu(&ctx->gb);
- if (val)
+ if (val || opaque)
memset(dst + pos, val, code);
pos += code;
} else {
@@ -589,7 +589,7 @@ static int old_codec1(SANMVideoContext *ctx, int top,
return AVERROR_INVALIDDATA;
for (j = 0; j < code; j++) {
val = bytestream2_get_byteu(&ctx->gb);
- if (val)
+ if (val || opaque)
dst[pos] = val;
pos++;
}
@@ -1300,7 +1300,7 @@ static int process_frame_obj(SANMVideoContext *ctx)
switch (codec) {
case 1:
case 3:
- return old_codec1(ctx, top, left, w, h);
+ return old_codec1(ctx, top, left, w, h, codec != 1);
case 37:
return old_codec37(ctx, w, h);
case 47:
--
2.48.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-03-11 15:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 15:03 [FFmpeg-devel] [PATCH 1/9] avcodec/sanm: codec37: reimplement comp4 Manuel Lauss
2025-03-11 15:03 ` [FFmpeg-devel] [PATCH 2/9] avcodec/sanm: better frame size detection for old codecs Manuel Lauss
2025-03-11 15:03 ` [FFmpeg-devel] [PATCH 3/9] avcodec/sanm: disable left/top for fullscreen codecs Manuel Lauss
2025-03-11 15:03 ` Manuel Lauss [this message]
2025-03-11 15:03 ` [FFmpeg-devel] [PATCH 5/9] avcodec/sanm: FOBJ left/top are signed values Manuel Lauss
2025-03-11 15:03 ` [FFmpeg-devel] [PATCH 6/9] avcodec/sanm: misc fixes Manuel Lauss
2025-03-11 15:03 ` [FFmpeg-devel] [PATCH 7/9] avcodec/sanm: codec2 decoder Manuel Lauss
2025-03-11 15:03 ` [FFmpeg-devel] [PATCH 8/9] avcodec/sanm: codec23 decoder Manuel Lauss
2025-03-11 15:03 ` [FFmpeg-devel] [PATCH 9/9] avcodec/sanm: codec21 decoder Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250311150341.348678-4-manuel.lauss@gmail.com \
--to=manuel.lauss@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git