From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 15D3D4E43F for ; Tue, 11 Mar 2025 14:48:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B6BAC68E0EF; Tue, 11 Mar 2025 16:48:38 +0200 (EET) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 07A3468C5E5 for ; Tue, 11 Mar 2025 16:48:32 +0200 (EET) Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so17110695e9.2 for ; Tue, 11 Mar 2025 07:48:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741704511; x=1742309311; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Z2Yat7zeURc/oO7BOZfSV+ZVpzjhRp+bzEJQ9hYZpuM=; b=OWKXaXrRVHfELsJT5LunmGdT11O5SJueWW13KARo7f11WhcEE8V31bJWCwN55VagPM hA9U3T8lXWA1BV8OCLIBSZ5IDe6jBe7QaHN3J3IANLiq/O6usycIt88sQwHv9Ki8Kp2N G55TF0/IXyWSZXLfp4NejO8vtvC4BKx5r0v4hcexY93g1thXdIn2+9aBdH8s29PTuTte aZq5+gDv5v46gwkP0h4y4ON9b4hTs3P9GnvSacuoMqzGsEg2bnJZMLOJmZKQeQvXXQiA prGy8NEzTlkMFlsi3+9BibROHy9lLaJYuHcCgsypG5rH1zcxzL+WN2y/ZyJA3LN/I2nZ A8wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741704511; x=1742309311; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z2Yat7zeURc/oO7BOZfSV+ZVpzjhRp+bzEJQ9hYZpuM=; b=KtgSLKGjfi6Nwalrt5xa/TxZMhJEp8pY6llpCKOhG1inn7JhkdNs04tCLr0ipzNNQ/ o8DaNSTf5De91g8B6pdqdsqaFAnCjUHGr4Oe/XaOq4hi1nrma7jR6g0Gy1gKmoOs47i0 Xv2Xx1TwmERD9Hc0ONquPLKGo8LdJLBJs8+H/bhXHSaGbpuf9jHmpYKXMQM8JiGTaImo l2o2gH/o8Hj+XTxhXUBvqKuJlglvCU9Y7m1BIuLbuo7D07yxM9AD8YHles7j0syEc7yK jAYTqDbiR90dOQyFbaBvj4c2NsgkvRdiqI2rjrAzftmAo/4H6emIpRCBLSb4kL/ugjRV 2PvA== X-Gm-Message-State: AOJu0YytPNTCXHRQ4LoBJOroxNllDEfK5klnsRT+qvIx0/YdJ8a8oVA2 oU2LEb7KhuPXi7EqoV53wTQbpm0p8XatwUQJI6VubYRwHRMEYop6XrIjjZSN8Nw= X-Gm-Gg: ASbGncumH1SCZ+04CQFQlq6vDXOqf8Wtfz5FpsWUK30bMyDu2scX2O+XdRzfsM6Wokn qsSUuaRiYr07XdO38s/wCUoS2345RIZzbqbiGoi1T3hHa7dgzeeqO+zDIznwvkEQNehbfwj+Gcp vkVZdfJ9JHOi16aDFCuE1hznwzY22LBWTTC7dAaWC4WQJj8hLKRBXBFfM+OuqcqvbhLxo1F1B58 OWkLytj8zlayoscXM7yHqmS1WCrBBOUnv5dtNoMQOYyvczSdjMG6OSWp7S9khHSH3m9aIdd1ZyO UiSB5mQKj9rDV1e1g0S3BQR43q4WGt8GWr0SsTbcSxIqJtdAhRyQviHy9g/U05+tINHNSWoQb/i b2xqfy1UFDHCDNu2fgowk1BPwb7oCP4+BgARN+G8Mimbnxs0= X-Google-Smtp-Source: AGHT+IFqQl1jCgPodUYc9/2hC22xYtoJY3OiVsKLpB8/yqfNVre03pgbUYYLQXSEBosoqUie/Lnqqg== X-Received: by 2002:a05:600c:1c9d:b0:439:643a:c8d5 with SMTP id 5b1f17b1804b1-43c549dcc0amr163801535e9.0.1741704510775; Tue, 11 Mar 2025 07:48:30 -0700 (PDT) Received: from localhost.localdomain (178-222-11-229.dynamic.isp.telekom.rs. [178.222.11.229]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bdd9471b7sm180503515e9.34.2025.03.11.07.48.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Mar 2025 07:48:30 -0700 (PDT) From: Araz Iusubov X-Google-Original-From: Araz Iusubov To: ffmpeg-devel@ffmpeg.org Date: Tue, 11 Mar 2025 15:48:15 +0100 Message-ID: <20250311144816.324-1-Primeadvice@gmail.com> X-Mailer: git-send-email 2.47.1.windows.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec/amfenc: add smart access video option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Evgeny Pavlov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Evgeny Pavlov This commit adds option for enabling SmartAccess Video (SAV) in AMF encoders. SAV is an AMD hardware-specific feature which enables the parallelization of encode and decode streams across multiple Video Codec Engine (VCN) hardware instances. --- libavcodec/amfenc.h | 1 + libavcodec/amfenc_av1.c | 17 +++++++++++++++++ libavcodec/amfenc_h264.c | 18 ++++++++++++++++++ libavcodec/amfenc_hevc.c | 18 ++++++++++++++++++ 4 files changed, 54 insertions(+) diff --git a/libavcodec/amfenc.h b/libavcodec/amfenc.h index 3f42c4cd94..aec3a3f9ec 100644 --- a/libavcodec/amfenc.h +++ b/libavcodec/amfenc.h @@ -72,6 +72,7 @@ typedef struct AMFEncoderContext { int b_frame_delta_qp; int ref_b_frame_delta_qp; int bit_depth; + int smart_access_video; // Dynamic options, can be set after Init() call diff --git a/libavcodec/amfenc_av1.c b/libavcodec/amfenc_av1.c index 05ad2b8897..8c5fa9dfbc 100644 --- a/libavcodec/amfenc_av1.c +++ b/libavcodec/amfenc_av1.c @@ -133,6 +133,8 @@ static const AVOption options[] = { { "1080p", "", 0, AV_OPT_TYPE_CONST, {.i64 = AMF_VIDEO_ENCODER_AV1_ALIGNMENT_MODE_64X16_1080P_CODED_1082 }, 0, 0, VE, .unit = "align" }, { "none", "", 0, AV_OPT_TYPE_CONST, {.i64 = AMF_VIDEO_ENCODER_AV1_ALIGNMENT_MODE_NO_RESTRICTIONS }, 0, 0, VE, .unit = "align" }, + { "smart_access_video", "Enable Smart Access Video", OFFSET(smart_access_video), AV_OPT_TYPE_BOOL, {.i64 = -1 }, -1, 1, VE}, + //Pre Analysis options { "preanalysis", "Enable preanalysis", OFFSET(preanalysis), AV_OPT_TYPE_BOOL, {.i64 = -1 }, -1, 1, VE }, @@ -326,6 +328,21 @@ FF_ENABLE_DEPRECATION_WARNINGS av_log(ctx, AV_LOG_DEBUG, "Rate control turned to Peak VBR\n"); } } + if (ctx->smart_access_video != -1) { + AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, AMF_VIDEO_ENCODER_AV1_ENABLE_SMART_ACCESS_VIDEO, ctx->smart_access_video != 0); + if (res != AMF_OK) { + av_log(avctx, AV_LOG_ERROR, "The Smart Access Video is not supported by AMF.\n"); + if (ctx->smart_access_video != 0) + return AVERROR(ENOSYS); + } else { + av_log(avctx, AV_LOG_INFO, "The Smart Access Video (%d) is set.\n", ctx->smart_access_video); + // Set low latency mode if Smart Access Video is enabled + if (ctx->smart_access_video != 0) { + AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, AMF_VIDEO_ENCODER_AV1_ENCODING_LATENCY_MODE, AMF_VIDEO_ENCODER_AV1_ENCODING_LATENCY_MODE_LOWEST_LATENCY); + av_log(avctx, AV_LOG_INFO, "The Smart Access Video set low latency mode.\n"); + } + } + } // Pre-Pass, Pre-Analysis, Two-Pass if (ctx->rate_control_mode == AMF_VIDEO_ENCODER_AV1_RATE_CONTROL_METHOD_CONSTANT_QP) { diff --git a/libavcodec/amfenc_h264.c b/libavcodec/amfenc_h264.c index 4291f0ea64..2f906f3273 100644 --- a/libavcodec/amfenc_h264.c +++ b/libavcodec/amfenc_h264.c @@ -139,6 +139,8 @@ static const AVOption options[] = { { "forced_idr", "Force I frames to be IDR frames", OFFSET(forced_idr) , AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE }, { "aud", "Inserts AU Delimiter NAL unit", OFFSET(aud) , AV_OPT_TYPE_BOOL, { .i64 = -1 }, -1, 1, VE }, + { "smart_access_video", "Enable Smart Access Video", OFFSET(smart_access_video), AV_OPT_TYPE_BOOL, {.i64 = -1 }, -1, 1, VE}, + //Pre Analysis options { "preanalysis", "Enable preanalysis", OFFSET(preanalysis), AV_OPT_TYPE_BOOL, {.i64 = -1 }, -1, 1, VE }, @@ -399,6 +401,22 @@ FF_ENABLE_DEPRECATION_WARNINGS AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, AMF_VIDEO_ENCODER_LOWLATENCY_MODE, ((ctx->latency == 0) ? false : true)); } + if (ctx->smart_access_video != -1) { + AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, AMF_VIDEO_ENCODER_ENABLE_SMART_ACCESS_VIDEO, ctx->smart_access_video != 0); + if (res != AMF_OK) { + av_log(avctx, AV_LOG_ERROR, "The Smart Access Video is not supported by AMF.\n"); + if (ctx->smart_access_video != 0) + return AVERROR(ENOSYS); + } else { + av_log(avctx, AV_LOG_INFO, "The Smart Access Video (%d) is set.\n", ctx->smart_access_video); + // Set low latency mode if Smart Access Video is enabled + if (ctx->smart_access_video != 0) { + AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, AMF_VIDEO_ENCODER_LOWLATENCY_MODE, true); + av_log(avctx, AV_LOG_INFO, "The Smart Access Video set low latency mode.\n"); + } + } + } + if (ctx->preanalysis != -1) { AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, AMF_VIDEO_ENCODER_PRE_ANALYSIS_ENABLE, !!((ctx->preanalysis == 0) ? false : true)); } diff --git a/libavcodec/amfenc_hevc.c b/libavcodec/amfenc_hevc.c index 81ef1534f5..ace1d60c70 100644 --- a/libavcodec/amfenc_hevc.c +++ b/libavcodec/amfenc_hevc.c @@ -109,6 +109,8 @@ static const AVOption options[] = { { "forced_idr", "Force I frames to be IDR frames", OFFSET(forced_idr) ,AV_OPT_TYPE_BOOL,{ .i64 = 0 }, 0, 1, VE }, { "aud", "Inserts AU Delimiter NAL unit", OFFSET(aud) ,AV_OPT_TYPE_BOOL,{ .i64 = -1 }, -1, 1, VE }, + { "smart_access_video", "Enable Smart Access Video", OFFSET(smart_access_video), AV_OPT_TYPE_BOOL, {.i64 = -1 }, -1, 1, VE}, + //Pre Analysis options { "preanalysis", "Enable preanalysis", OFFSET(preanalysis), AV_OPT_TYPE_BOOL, {.i64 = -1 }, -1, 1, VE }, @@ -309,6 +311,22 @@ FF_ENABLE_DEPRECATION_WARNINGS } } + if (ctx->smart_access_video != -1) { + AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, AMF_VIDEO_ENCODER_HEVC_ENABLE_SMART_ACCESS_VIDEO, ctx->smart_access_video != 0); + if (res != AMF_OK) { + av_log(avctx, AV_LOG_ERROR, "The Smart Access Video is not supported by AMF.\n"); + if (ctx->smart_access_video != 0) + return AVERROR(ENOSYS); + } else { + av_log(avctx, AV_LOG_INFO, "The Smart Access Video (%d) is set.\n", ctx->smart_access_video); + // Set low latency mode if Smart Access Video is enabled + if (ctx->smart_access_video != 0) { + AMF_ASSIGN_PROPERTY_BOOL(res, ctx->encoder, AMF_VIDEO_ENCODER_HEVC_LOWLATENCY_MODE, true); + av_log(avctx, AV_LOG_INFO, "The Smart Access Video set low latency mode.\n"); + } + } + } + // Pre-Pass, Pre-Analysis, Two-Pass if (ctx->rate_control_mode == AMF_VIDEO_ENCODER_HEVC_RATE_CONTROL_METHOD_CONSTANT_QP) { AMF_ASSIGN_PROPERTY_INT64(res, ctx->encoder, AMF_VIDEO_ENCODER_HEVC_PREENCODE_ENABLE, 0); -- 2.45.2.windows.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".