From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 70C144C591
for <ffmpegdev@gitmailbox.com>; Sun, 9 Mar 2025 17:52:38 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0DD5A68E62C;
Sun, 9 Mar 2025 19:52:35 +0200 (EET)
Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net
[217.70.183.195])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8C61568D2FB
for <ffmpeg-devel@ffmpeg.org>; Sun, 9 Mar 2025 19:52:28 +0200 (EET)
Received: by mail.gandi.net (Postfix) with ESMTPSA id E6C6F20453
for <ffmpeg-devel@ffmpeg.org>; Sun, 9 Mar 2025 17:52:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
s=gm1; t=1741542748;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=lU6GgJeqULZcujC+6x6VBRw09sOdL9ZGtJoeXw4db8M=;
b=l6jgYpLgrRegMIzjKkf92h3rDfSQiRqVWRKmsdfB4ygFWBXbpUQbU37bQhi92ZXBeDfKNZ
N4Ru26dpQO0hZELYmS4TAC4ZNsKk2OE9SJgtq3REs1vaMO6U5PB2GMDhxwU0OV0/0Q1vdp
ebeWf4kFm8ysS3smXG7D5pO+D53Bl/swEuHtBBoSC0FNiJlXjmK4l1D+TWgoGXhMM1KrOi
a6OfdevY/4pLgXRfjUMYDAp7jyVeGm7/NGkOapW8qii/IrCgJkDLAdGXaJzArlAztMM/Sl
cz015etLe6EDMAuG3mVqIU1RuSylsuVRh93VCE4dBPGqasX5O5QehEMrp3OGVg==
Date: Sun, 9 Mar 2025 18:52:26 +0100
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20250309175226.GH4991@pb2>
References: <pull.59.v3.ffstaging.FFmpeg.1741294751.ffmpegagent@gmail.com>
<pull.59.v4.ffstaging.FFmpeg.1741474964.ffmpegagent@gmail.com>
<fa1ae9231a145ec012244c7fc14620c5d3e6f27b.1741474964.git.ffmpegagent@gmail.com>
MIME-Version: 1.0
In-Reply-To: <fa1ae9231a145ec012244c7fc14620c5d3e6f27b.1741474964.git.ffmpegagent@gmail.com>
X-GND-State: clean
X-GND-Score: -85
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduudejuddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeelkeeggfffiedufeejueffjeduhedttdduledtheevveevtdeiueelhfdtuedtkeenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH v4 3/4] fftools: Provide a an
fftools-specific logging callback function
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============1814069982237155110=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250309175226.GH4991@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
--===============1814069982237155110==
Content-Type: multipart/signed; micalg=pgp-sha512;
protocol="application/pgp-signature"; boundary="q4jLiTOECe4JD5GE"
Content-Disposition: inline
--q4jLiTOECe4JD5GE
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Mar 08, 2025 at 11:02:43PM +0000, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
>=20
> This goes together with a change to logging of context prefixes, which
> is printing logical ids instead of memory addresses.
> The benefits are:
>=20
> - Smaller log file sizes
> - The disambiguation is much easier to recognize and to follow
> - It eventually allows comparing and viewing log file diffs
> without almost every line being different due to those addresses
> ---
> fftools/Makefile | 7 +-
> fftools/ffmpeg.c | 2 +
> fftools/ffmpeg_filter.c | 2 +-
> fftools/ffplay.c | 2 +
> fftools/ffprobe.c | 2 +
> fftools/fftools_log.c | 480 ++++++++++++++++++++++++++++++++++++++++
> fftools/fftools_log.h | 44 ++++
> 7 files changed, 537 insertions(+), 2 deletions(-)
> create mode 100644 fftools/fftools_log.c
> create mode 100644 fftools/fftools_log.h
breaks build for ppc
CC fftools/fftools_log.o
src/fftools/fftools_log.c: In function =E2=80=98format_date_now=E2=80=99:
src/fftools/fftools_log.c:349:21: error: storage size of =E2=80=98tmbuf=E2=
=80=99 isn=E2=80=99t known
struct tm *ptm, tmbuf;
^~~~~
src/fftools/fftools_log.c:354:29: error: implicit declaration of function =
=E2=80=98localtime_r=E2=80=99 [-Werror=3Dimplicit-function-declaration]
ptm =3D localtime_r(&time_s, &tmbuf);
^~~~~~~~~~~
src/fftools/fftools_log.c:349:21: warning: unused variable =E2=80=98tmbuf=
=E2=80=99 [-Wunused-variable]
struct tm *ptm, tmbuf;
^~~~~
At top level:
src/fftools/fftools_log.c:58:12: warning: =E2=80=98nb_class_ids=E2=80=99 de=
fined but not used [-Wunused-variable]
static int nb_class_ids;
^~~~~~~~~~~~
cc1: some warnings being treated as errors
make: *** [src/ffbuild/common.mak:81: fftools/fftools_log.o] Error 1
make: Target 'all' not remade because of errors.
thx
[...]
--=20
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The day soldiers stop bringing you their problems is the day you have stopp=
ed=20
leading them. They have either lost confidence that you can help or conclud=
ed=20
you do not care. Either case is a failure of leadership. - Colin Powell
--q4jLiTOECe4JD5GE
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ83VVwAKCRBhHseHBAsP
q4PoAJ9SlCIq8IGauYBoLjQoni6znSdU+wCghkB1WawBJIN0sie5+U/hiPi5J7U=
=lsUn
-----END PGP SIGNATURE-----
--q4jLiTOECe4JD5GE--
--===============1814069982237155110==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--===============1814069982237155110==--