Re: [FFmpeg-devel] [PATCH v4 3/4] fftools: Provide a an fftools-specific logging callback function

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 2243 bytes --]

On Sat, Mar 08, 2025 at 11:02:43PM +0000, softworkz wrote:
> From: softworkz <softworkz@hotmail.com>
> 
> This goes together with a change to logging of context prefixes, which
> is printing logical ids instead of memory addresses.
> The benefits are:
> 
> - Smaller log file sizes
> - The disambiguation is much easier to recognize and to follow
> - It eventually allows comparing and viewing log file diffs
>   without almost every line being different due to those addresses
> ---
>  fftools/Makefile        |   7 +-
>  fftools/ffmpeg.c        |   2 +
>  fftools/ffmpeg_filter.c |   2 +-
>  fftools/ffplay.c        |   2 +
>  fftools/ffprobe.c       |   2 +
>  fftools/fftools_log.c   | 480 ++++++++++++++++++++++++++++++++++++++++
>  fftools/fftools_log.h   |  44 ++++
>  7 files changed, 537 insertions(+), 2 deletions(-)
>  create mode 100644 fftools/fftools_log.c
>  create mode 100644 fftools/fftools_log.h

breaks build for ppc

CC	fftools/fftools_log.o
src/fftools/fftools_log.c: In function ‘format_date_now’:
src/fftools/fftools_log.c:349:21: error: storage size of ‘tmbuf’ isn’t known
     struct tm *ptm, tmbuf;
                     ^~~~~
src/fftools/fftools_log.c:354:29: error: implicit declaration of function ‘localtime_r’ [-Werror=implicit-function-declaration]
     ptm                   = localtime_r(&time_s, &tmbuf);
                             ^~~~~~~~~~~
src/fftools/fftools_log.c:349:21: warning: unused variable ‘tmbuf’ [-Wunused-variable]
     struct tm *ptm, tmbuf;
                     ^~~~~
At top level:
src/fftools/fftools_log.c:58:12: warning: ‘nb_class_ids’ defined but not used [-Wunused-variable]
 static int nb_class_ids;
            ^~~~~~~~~~~~
cc1: some warnings being treated as errors
make: *** [src/ffbuild/common.mak:81: fftools/fftools_log.o] Error 1
make: Target 'all' not remade because of errors.


thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The day soldiers stop bringing you their problems is the day you have stopped 
leading them. They have either lost confidence that you can help or concluded 
you do not care. Either case is a failure of leadership. - Colin Powell

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".