From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 80F3F4C136 for ; Sat, 8 Mar 2025 00:28:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DE2F668F412; Sat, 8 Mar 2025 02:28:04 +0200 (EET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E30FD68F3CB for ; Sat, 8 Mar 2025 02:27:57 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4571242FF4 for ; Sat, 8 Mar 2025 00:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1741393677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jiq2V8H08t9R7bg6s+QD5qphY8JCGULu0PL1In3DHjc=; b=LPZ7lc7jQxGbE3s6t5OKyr0xD3irnaqdJOvUZS9xT5Sb38cm0PpUGGHzJ59OnGw/lISqYd sZpGFTPkUy3JMaMqQsCNbteJJIsgeUL8QZ07I95kqyGC8yo+PE5Gg12plXszCfPsLAvBqK N5HSVqrnwp7STKwT89RbL7E8+dy7bbeqpm+2gI2fjXAw4w5ErItEoz4ZO5VhJanUyfKVL8 a/t+WKuukV50cbDLKDa3LknhAFAqW6FxDD7ymrihdMbRdO9ZieN1vvU+H9zm4BGaNi7J9F R1UhdS7vCgjJ8Suz17s0DnUsUqLS7xJm0497b7JC7Cw1A9JgPzeca9S7L28x1A== Date: Sat, 8 Mar 2025 01:27:56 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250308002756.GZ4991@pb2> References: <20250303235632.GH4991@pb2> <20250304010937.GJ4991@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduuddvuddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6433788965117939498==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6433788965117939498== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dRqL6fk4Avt6z8U0" Content-Disposition: inline --dRqL6fk4Avt6z8U0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 04, 2025 at 10:17:25AM -0800, Nil Fons Miret via ffmpeg-devel w= rote: > I'm not sure I understand what documentation you'd like to add. The > behavior of ff_draw_init* is documented in drawutils.h, would you like > me to add a comment where these functions are called with no risk of > failing (as far as I can see, only qrencode.c)? My worry is that such > a comment can easily become outdated. In any case, once I understand > your request I'm happy to add any more documentation. yes, if you add a check that is unreachable and that is intentional it should receive a comment. Otherwise it can confuse the reader, also it can be removed when someone realizes it is unreachable thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Nations do behave wisely once they have exhausted all other alternatives.= =20 -- Abba Eban --dRqL6fk4Avt6z8U0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ8uPCAAKCRBhHseHBAsP q+sQAJ9rDbYnsTYVYLpDi5tTOXd4dorv1ACeKduylSuu7VInA97/A9ciAOX8GQ0= =jPO3 -----END PGP SIGNATURE----- --dRqL6fk4Avt6z8U0-- --===============6433788965117939498== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6433788965117939498==--