Re: [FFmpeg-devel] [PATCH 4/5] swscale: 16bit planar float input support

Re: [FFmpeg-devel] [PATCH 4/5] swscale: 16bit planar float input support

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1577 bytes --]

On Sat, Jan 11, 2025 at 03:02:47AM +0100, Michael Niedermayer wrote:
> On Fri, Jan 10, 2025 at 05:06:13AM +0100, Michael Niedermayer wrote:
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libswscale/input.c            | 97 +++++++++++++++++++++++++++++++++++
> >  libswscale/swscale_unscaled.c |  2 +-
> >  libswscale/utils.c            |  8 +++
> >  3 files changed, 106 insertions(+), 1 deletion(-)
> [...]
> 
> > diff --git a/libswscale/swscale_unscaled.c b/libswscale/swscale_unscaled.c
> > index dae3f45df9e..541cd159c74 100644
> > --- a/libswscale/swscale_unscaled.c
> > +++ b/libswscale/swscale_unscaled.c
> > @@ -2659,7 +2659,7 @@ void ff_get_unscaled_swscale(SwsInternal *c)
> >      if ( srcFormat == dstFormat ||
> >          (srcFormat == AV_PIX_FMT_YUVA420P && dstFormat == AV_PIX_FMT_YUV420P) ||
> >          (srcFormat == AV_PIX_FMT_YUV420P && dstFormat == AV_PIX_FMT_YUVA420P) ||
> > -        (isFloat(srcFormat) == isFloat(dstFormat)) && ((isPlanarYUV(srcFormat) && isPlanarGray(dstFormat)) ||
> > +        (isFloat(srcFormat) == isFloat(dstFormat) && c->srcFormatBpp == c->dstFormatBpp) && ((isPlanarYUV(srcFormat) && isPlanarGray(dstFormat)) ||
> 
> This is wrong, fixed locally

will apply this and the prerequesit pixfmt addition


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/exr: do not output 32bit floats when a file stores 16bit floats

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 473 bytes --]

On Fri, Jan 10, 2025 at 05:06:14AM +0100, Michael Niedermayer wrote:
> exr should not do a internal pixel format convert
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>

will apply

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".