[FFmpeg-devel] [PATCH 1/2] avcodec/ffv1: Store remap flag per slice

[FFmpeg-devel] [PATCH 1/2] avcodec/ffv1: Store remap flag per slice

[Michael Niedermayer]

This allows switching it on conditionally and also for non float,
it may improve compression for RGB data that was paletted
or other synthetic images

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/ffv1.h             | 1 +
 libavcodec/ffv1dec.c          | 8 ++++++++
 libavcodec/ffv1dec_template.c | 4 ++--
 libavcodec/ffv1enc.c          | 3 +++
 libavcodec/ffv1enc_template.c | 4 ++--
 5 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/libavcodec/ffv1.h b/libavcodec/ffv1.h
index 4ed06310f7f..c23d64d54a4 100644
--- a/libavcodec/ffv1.h
+++ b/libavcodec/ffv1.h
@@ -84,6 +84,7 @@ typedef struct FFV1SliceContext {
     int slice_coding_mode;
     int slice_rct_by_coef;
     int slice_rct_ry_coef;
+    int remap;
 
     // RefStruct reference, array of MAX_PLANES elements
     PlaneContext *plane;
diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c
index 7de161f442b..3926659ebc9 100644
--- a/libavcodec/ffv1dec.c
+++ b/libavcodec/ffv1dec.c
@@ -220,6 +220,14 @@ static int decode_slice_header(const FFV1Context *f,
                 return AVERROR_INVALIDDATA;
             }
         }
+        if (f->combined_version >= 0x40004) {
+            sc->remap = ff_ffv1_get_symbol(c, state, 0);
+            if (sc->remap > 1 ||
+                sc->remap == 1 && !f->flt) {
+                av_log(f->avctx, AV_LOG_ERROR, "unsupported remap %d\n", sc->remap);
+                return AVERROR_INVALIDDATA;
+            }
+        }
     }
 
     return 0;
diff --git a/libavcodec/ffv1dec_template.c b/libavcodec/ffv1dec_template.c
index a419aca8584..1fa9933d984 100644
--- a/libavcodec/ffv1dec_template.c
+++ b/libavcodec/ffv1dec_template.c
@@ -155,7 +155,7 @@ static int RENAME(decode_rgb_frame)(FFV1Context *f, FFV1SliceContext *sc,
 
     memset(RENAME(sc->sample_buffer), 0, 8 * (w + 6) * sizeof(*RENAME(sc->sample_buffer)));
 
-    if (f->flt) {
+    if (sc->remap) {
         for (int p= 0; p<3 + transparency; p++) {
             int j = 0;
             int lu = 0;
@@ -199,7 +199,7 @@ static int RENAME(decode_rgb_frame)(FFV1Context *f, FFV1SliceContext *sc,
                 b += g;
                 r += g;
             }
-            if (f->flt) {
+            if (sc->remap) {
                 r = sc->fltmap[0][r];
                 g = sc->fltmap[1][g];
                 b = sc->fltmap[2][b];
diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c
index 5c873fa8ba1..1292b4227d3 100644
--- a/libavcodec/ffv1enc.c
+++ b/libavcodec/ffv1enc.c
@@ -946,6 +946,8 @@ static int encode_init_internal(AVCodecContext *avctx)
         }
 
         ff_build_rac_states(&s->slices[j].c, 0.05 * (1LL << 32), 256 - 8);
+
+        s->slices[j].remap = s->flt;
     }
 
     if ((ret = ff_ffv1_init_slices_state(s)) < 0)
@@ -1000,6 +1002,7 @@ static void encode_slice_header(FFV1Context *f, FFV1SliceContext *sc)
             put_symbol(c, state, sc->slice_rct_by_coef, 0);
             put_symbol(c, state, sc->slice_rct_ry_coef, 0);
         }
+        put_symbol(c, state, sc->remap, 0);
     }
 }
 
diff --git a/libavcodec/ffv1enc_template.c b/libavcodec/ffv1enc_template.c
index 0d1b0a28432..4c7cd2e647c 100644
--- a/libavcodec/ffv1enc_template.c
+++ b/libavcodec/ffv1enc_template.c
@@ -148,7 +148,7 @@ static int RENAME(encode_rgb_frame)(FFV1Context *f, FFV1SliceContext *sc,
     memset(RENAME(sc->sample_buffer), 0, ring_size * MAX_PLANES *
            (w + 6) * sizeof(*RENAME(sc->sample_buffer)));
 
-    if (f->flt) {
+    if (sc->remap) {
         memset(sc->fltmap, 0, sizeof(sc->fltmap));
 
         for (y = 0; y < h; y++) {
@@ -221,7 +221,7 @@ static int RENAME(encode_rgb_frame)(FFV1Context *f, FFV1SliceContext *sc,
                 r = *((const uint16_t *)(src[2] + x*2 + stride[2]*y));
             }
 
-            if (f->flt) {
+            if (sc->remap) {
                 r = sc->fltmap[0][r];
                 g = sc->fltmap[1][g];
                 b = sc->fltmap[2][b];
-- 
2.48.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/2] avcodec/ffv1: Use dual run coder for fltmap

[Michael Niedermayer]

This improves compression by 0.1% overall
I tried several other things but so far this is the best
compromise between complexity and compression

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/ffv1dec_template.c | 10 ++++++++--
 libavcodec/ffv1enc_template.c | 13 +++++++++++--
 2 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/libavcodec/ffv1dec_template.c b/libavcodec/ffv1dec_template.c
index 1fa9933d984..1f8aeb52a2d 100644
--- a/libavcodec/ffv1dec_template.c
+++ b/libavcodec/ffv1dec_template.c
@@ -159,9 +159,15 @@ static int RENAME(decode_rgb_frame)(FFV1Context *f, FFV1SliceContext *sc,
         for (int p= 0; p<3 + transparency; p++) {
             int j = 0;
             int lu = 0;
-            uint8_t state[2] = {128, 128};
+            uint8_t state[2][32];
+            int run = -1;
+            memset(state, 128, sizeof(state));
             for (int i= 0; i<65536; i++) {
-                int u = get_rac(&sc->c, state + lu);
+                int u;
+                if (run < 0)
+                    run = get_symbol_inline(&sc->c, state[lu], 0);
+                u = lu ^ !run;
+                run --;
                 sc->fltmap[p][j] = i ^ ((i&0x8000) ? 0 : 0x7FFF);
                 j+= u;
                 lu = u;
diff --git a/libavcodec/ffv1enc_template.c b/libavcodec/ffv1enc_template.c
index 4c7cd2e647c..e62fa140bee 100644
--- a/libavcodec/ffv1enc_template.c
+++ b/libavcodec/ffv1enc_template.c
@@ -177,15 +177,24 @@ static int RENAME(encode_rgb_frame)(FFV1Context *f, FFV1SliceContext *sc,
         for (int p= 0; p<3 + transparency; p++) {
             int j = 0;
             int lu = 0;
-            uint8_t state[2] = {128, 128};
+            uint8_t state[2][32];
+            int run = 0;
+            memset(state, 128, sizeof(state));
             for (int i= 0; i<65536; i++) {
                 int ri = i ^ ((i&0x8000) ? 0 : 0x7FFF);
                 int u = sc->fltmap[p][ri];
                 sc->fltmap[p][ri] = j;
                 j+= u;
-                put_rac(&sc->c, state + lu, u);
+
+                if (lu == u) {
+                    run ++;
+                } else {
+                    put_symbol_inline(&sc->c, state[lu], run, 0, NULL, NULL);
+                    run = 0;
+                }
                 lu = u;
             }
+            put_symbol(&sc->c, state[lu], run, 0);
         }
     }
 
-- 
2.48.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".