From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B83894BC85 for ; Tue, 4 Mar 2025 08:31:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A263968ECC7; Tue, 4 Mar 2025 10:31:34 +0200 (EET) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A716C68EC9A for ; Tue, 4 Mar 2025 10:31:27 +0200 (EET) Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-54954fa61c9so4524656e87.1 for ; Tue, 04 Mar 2025 00:31:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1741077087; x=1741681887; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/WbN+pEOnQf0qyhdpEJyAvRsYi8tCaqFzwmzqoCPkBE=; b=NJLalNWRR6h00Jr1WU+3pzK9l7VvqiotAzAGPxsZeQ8k8rgwwwamgtJQ9WKzqX1AM2 0dpwMmCorc4tONtLnJHcvx1y4U+GIlcwi6V4W3f8wJyH5MQmmUid8NJnxw4K3SoI/y8D nuK1sgUeHv9jJVGtlN98hlophPEu9CoQK1CQEELClq0Lu0BuJcrXIw1l2uTkYi6oAqVN 8BdJkVedOPCZQgW3pHf48ToBM/PUuD/RkRm4gxAqyGdEy78GA5GTDVbDr4BBfd+wU+Pv 4SFirNor3y50N13QSJqonex/+fPEWKmIAPwM8oom/43TtSPE9rxucTXuGs68W+1Fl+34 4Qjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741077087; x=1741681887; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/WbN+pEOnQf0qyhdpEJyAvRsYi8tCaqFzwmzqoCPkBE=; b=i1buEj2eksdtlILzzViudM1oMoPZ2jh/z4O0DkGqXRDw8Alo+COqvcGXb/DqJXSPYe Rm7PanQyiHNYFHbfRNqOiJm1xv5ly4bDuWGJz59YoGL1IW3ePrTH80YSDUdKiFHhQTsf brale3NrAoGWcYB3yc3XMnFQhMfaVQdfEqJ7s1DudZKb32xu5qJyr5RfNRQP9BVARNfh L1irF+3H2IYv7UOQUvYEr8wyKnx4vGi1CWA3Clf7r18+5pJ33P8EyhInWVDdpX8FcHoE XMONflE0ZBP0EcrpzSel3d5STW/xe7jdYVjbKmMai8507/dUEIt4KK8AcKRugZDneBsJ RipA== X-Gm-Message-State: AOJu0YyRsUfZMNE4/OvnhP4MTfFIv46eRMLXpb4hEfO3l1vFAJIRN/+u WFSBSkQy7bJlSoBMN4qCKvtjznNGYGLDGq0Hl+hEDPV2k7bW69GA1jKDhXnWzNENXQppT+WVWx4 pzQ== X-Gm-Gg: ASbGnctJC6glZIlz/d12B74487CMpJisCoioDt/CnLrLKmAMatE5iXNIWLd5pSaM6iZ VtH817XUQmj4QkyHIwGqJfofP8jemdqrBXjOXqV+FYHCsQz5SjshKMx1zTHcD/p7Ae2qXJS8u2g ccWFzEN79EpBWgcpLh8c0pl3pNPiSxjBhRl9Zrd53zn3Bt2WSu+rbKKLNzmOVepZJpq1gj/idev afyI1fij22S23NtJhNGZkSzp0QZxDoX2xAewwo6YdPhfm8xsXfvTH/plmW43SMjHmIY+msDGhey KQEVtfUFWkFpPa0Iisc8vBTyQdbGbUcYGaBsqdQAB4z0sLVDiWjCOsm/37lf9p+Gm8eyvPAc5Zp tRhxw07W+ZA0= X-Google-Smtp-Source: AGHT+IHF4DSrAUS1fth1EE6XQOHeYKrdK36MCqlEWJcEnX0IyiwDPp9kFS4prDXf/jH4zLsemz1CGA== X-Received: by 2002:a05:6512:a8b:b0:545:8f7:8597 with SMTP id 2adb3069b0e04-5494c118a19mr7670137e87.16.1741077086627; Tue, 04 Mar 2025 00:31:26 -0800 (PST) Received: from localhost (dsl-tkubng21-50de30-198.dhcp.inet.fi. [80.222.48.198]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5494f155095sm1298734e87.30.2025.03.04.00.31.26 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 04 Mar 2025 00:31:26 -0800 (PST) From: =?UTF-8?q?Martin=20Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Tue, 4 Mar 2025 10:31:25 +0200 Message-Id: <20250304083125.40223-1-martin@martin.st> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] swscale: aarch64: Simplify the assignment of lumToYV12 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Krzysztof Pyrkosz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: We normally don't need else statements here; the common pattern is to assign lower level SIMD implementations first, then conditionally reassign higher level ones afterwards, if supported. --- Sorry, I didn't notice this while reviewing the patch, until after pushing it. --- libswscale/aarch64/swscale.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libswscale/aarch64/swscale.c b/libswscale/aarch64/swscale.c index 18746b1b19..6e5a721c1f 100644 --- a/libswscale/aarch64/swscale.c +++ b/libswscale/aarch64/swscale.c @@ -300,13 +300,12 @@ av_cold void ff_sws_init_swscale_aarch64(SwsInternal *c) c->chrToYV12 = ff_bgr24ToUV_neon; break; case AV_PIX_FMT_BGRA: + c->lumToYV12 = ff_bgra32ToY_neon; #if HAVE_DOTPROD if (have_dotprod(cpu_flags)) { c->lumToYV12 = ff_bgra32ToY_neon_dotprod; } - else #endif - c->lumToYV12 = ff_bgra32ToY_neon; if (c->chrSrcHSubSample) c->chrToYV12 = ff_bgra32ToUV_half_neon; else @@ -320,13 +319,12 @@ av_cold void ff_sws_init_swscale_aarch64(SwsInternal *c) c->chrToYV12 = ff_rgb24ToUV_neon; break; case AV_PIX_FMT_RGBA: + c->lumToYV12 = ff_rgba32ToY_neon; #if HAVE_DOTPROD if (have_dotprod(cpu_flags)) { c->lumToYV12 = ff_rgba32ToY_neon_dotprod; } - else #endif - c->lumToYV12 = ff_rgba32ToY_neon; if (c->chrSrcHSubSample) c->chrToYV12 = ff_rgba32ToUV_half_neon; else -- 2.39.5 (Apple Git-154) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".