From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 711C54DD61 for ; Tue, 4 Mar 2025 01:09:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8823868E964; Tue, 4 Mar 2025 03:09:44 +0200 (EET) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7A98B68E6BA for ; Tue, 4 Mar 2025 03:09:38 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id C856B433C9 for ; Tue, 4 Mar 2025 01:09:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1741050577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=stH+UVoYOFzsI9rCtDAuGD0dt9X2u5ezt4XUGyv1vZ8=; b=VdlQAym5r1b+0x/7HVkxaALdCrsKwZkXk+01ypBNqscX5Wj5VQ6jQj5EKB9Lnf2pA4G03b a2wnadbxDwy6IUNn9ryqUs3W23A4Pt0xZ19oTztkrSbetNgKN2J4OAaSZvY06vMskKLrLM Hj4FEfxA91NFQ+9r4y+1RbnM1yqTfjY3Uqv8EeqRL0Ir2RiPPk/E+sGO7s5Dtbm7gHXd9V LSQ43abzO2A9BTZwS2ukuo+Rc+uJGTQFQutcjbyxp7acAaEnDdhTu4G0pK/o8Oycha84ni NGOQmFt7CkctCr5Otqd6Gb84PZpLSZZtdPcfZt8XAUwxQTgneDp3OfOOR1H3bQ== Date: Tue, 4 Mar 2025 02:09:37 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250304010937.GJ4991@pb2> References: <20250303235632.GH4991@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddutddtieehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2713708989710479377==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2713708989710479377== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bGbq6RtYDCrpTM87" Content-Disposition: inline --bGbq6RtYDCrpTM87 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 03, 2025 at 05:05:58PM -0800, Nil Fons Miret via ffmpeg-devel w= rote: > From what I can see, that one time it is called with constants in > qrencode.c will never fail. I can remove that check, but I am a bit > worried it will make it brittle if the internals of ff_draw_init* > change later on, e.g. to introduce more failure modes. In fact, I ran > across this issue while upgrading an old ffmpeg that did not have some > of these checks, so it was one of the new checks that caused the > segfault. Let me know what you think, I am open to changing it. I think the important bit, is it should be documented. Its not so important if theres a check. Even with a check it could be documented that the case cannot occur currently thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not simpler. -- Albert Einstein --bGbq6RtYDCrpTM87 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ8ZS0AAKCRBhHseHBAsP qxG5AJ994nAjQ73EuyPvb8BBnLDknVQ7egCfX2Q2n/MnGEOuXDtr2YnIUpbGwiU= =jv/B -----END PGP SIGNATURE----- --bGbq6RtYDCrpTM87-- --===============2713708989710479377== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2713708989710479377==--