From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2F4434DD3F for ; Mon, 3 Mar 2025 23:56:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3274B68EA05; Tue, 4 Mar 2025 01:56:41 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7C73668E592 for ; Tue, 4 Mar 2025 01:56:34 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id B2AE620457 for ; Mon, 3 Mar 2025 23:56:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1741046193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DJruDdLURjCUm+rXwMTiNy1merufygZcomhUegInxfI=; b=k00pxQWyP9X7+4oeaG7faQYpTURJaCamccoSFUrUYA53VtYsq2pWWkcjMr/1nqAYQlic+9 s3LciZiiFLbuAvWGUXzwrINJOU/OWKEffvzgj9+8ydhRbmvxctlcxTzgkaBuSBQL1KJFkc sTwcJ2mq3FPFtb9JiysBRRH5Owqt+caJsHxqxtdAzFbh81LMI9LhDxGiuJLaHndpYQdqRr 41iY8V4+qR6picfzpF35udEFvpHoHQ8GJWQ6fCW7Eb50eZsmnc9fy2WuDswwdw6MZuhx5j RXeRgDxAb47CdS+QDEKGlgDVLLY3u7y8aC7ehNYff76ftY8LjUqE506zly6oiA== Date: Tue, 4 Mar 2025 00:56:32 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250303235632.GH4991@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddutddthedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdeftddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeeigeektdejudffjefhteegjedtgeettefggedthfejgfevhfetgeekjedtvdfhveenucfkphepgedurdeiiedrieejrdduudefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieejrdduudefpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1446604829380787541==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1446604829380787541== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="V8oVs23DQdoqz9wY" Content-Disposition: inline --V8oVs23DQdoqz9wY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 20, 2025 at 10:31:57PM -0500, Nil Fons Miret via ffmpeg-devel w= rote: > The return value of ff_draw_init and ff_draw_init2 are not checked in > most usages. However, if they return an error, they don't get to the > point where they set the attributes of the FFDrawContext. These > functions are typically used in conjunction with ff_draw_color, which > checks draw->desc->flags, causing a null pointer dereference. >=20 > Attaching patch with a fix to guard against this. Is every of these ff_draw_init* calls able to fail ? i see one is called with constants for example thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad --V8oVs23DQdoqz9wY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ8ZBqgAKCRBhHseHBAsP qz1LAJ9VjvakOgPw20C528WOzqvWvN7w7ACfWw6xgy4lVgnXhQSKyS1x1kLu7YI= =81+/ -----END PGP SIGNATURE----- --V8oVs23DQdoqz9wY-- --===============1446604829380787541== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1446604829380787541==--