From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] aacenc: move encoder to libavcodec/aac/
Date: Sun, 2 Mar 2025 02:54:52 +0100
Message-ID: <20250302015452.GB4991@pb2> (raw)
In-Reply-To: <20250228135445.101947-1-dev@lynne.ee>
[-- Attachment #1.1: Type: text/plain, Size: 3703 bytes --]
On Fri, Feb 28, 2025 at 02:54:40PM +0100, Lynne wrote:
> ---
> libavcodec/Makefile | 18 ++++++------------
> libavcodec/aac/Makefile | 7 +++++++
> libavcodec/{ => aac}/aac.h | 0
> libavcodec/{ => aac}/aaccoder.c | 10 +++++-----
> libavcodec/{ => aac}/aaccoder_trellis.h | 4 ++--
> libavcodec/{ => aac}/aaccoder_twoloop.h | 6 +++---
> libavcodec/aac/aacdec.c | 4 ++--
> libavcodec/aac/aacdec.h | 2 +-
> libavcodec/aac/aacdec_ac.c | 2 +-
> libavcodec/aac/aacdec_dsp_template.c | 2 +-
> libavcodec/aac/aacdec_fixed.c | 2 +-
> libavcodec/aac/aacdec_float.c | 2 +-
> libavcodec/aac/aacdec_tab.c | 4 ++--
> libavcodec/aac/aacdec_usac.c | 2 +-
> libavcodec/{ => aac}/aacenc.c | 18 +++++++++---------
> libavcodec/{ => aac}/aacenc.h | 11 +++++------
> libavcodec/{ => aac}/aacenc_is.c | 0
> libavcodec/{ => aac}/aacenc_is.h | 0
> libavcodec/{ => aac}/aacenc_quantization.h | 2 +-
> .../{ => aac}/aacenc_quantization_misc.h | 0
> libavcodec/{ => aac}/aacenc_tns.c | 2 +-
> libavcodec/{ => aac}/aacenc_tns.h | 0
> libavcodec/{ => aac}/aacenc_utils.h | 0
> libavcodec/{ => aac}/aacencdsp.h | 0
> libavcodec/{ => aac}/aacenctab.c | 0
> libavcodec/{ => aac}/aacenctab.h | 3 ++-
> libavcodec/{ => aac}/aacpsy.c | 4 ++--
> libavcodec/{ => aac}/aactab.c | 4 ++--
> libavcodec/{ => aac}/aactab.h | 0
> libavcodec/aacsbr.c | 2 +-
> libavcodec/aacsbr_fixed.c | 2 +-
> libavcodec/aarch64/aacencdsp_init.c | 2 +-
> libavcodec/sbrdsp.c | 2 +-
> libavcodec/sbrdsp_fixed.c | 2 +-
> libavcodec/x86/aacencdsp_init.c | 2 +-
> 35 files changed, 61 insertions(+), 60 deletions(-)
> rename libavcodec/{ => aac}/aac.h (100%)
> rename libavcodec/{ => aac}/aaccoder.c (99%)
> rename libavcodec/{ => aac}/aaccoder_trellis.h (99%)
> rename libavcodec/{ => aac}/aaccoder_twoloop.h (99%)
> rename libavcodec/{ => aac}/aacenc.c (99%)
> rename libavcodec/{ => aac}/aacenc.h (98%)
> rename libavcodec/{ => aac}/aacenc_is.c (100%)
> rename libavcodec/{ => aac}/aacenc_is.h (100%)
> rename libavcodec/{ => aac}/aacenc_quantization.h (98%)
> rename libavcodec/{ => aac}/aacenc_quantization_misc.h (100%)
> rename libavcodec/{ => aac}/aacenc_tns.c (99%)
> rename libavcodec/{ => aac}/aacenc_tns.h (100%)
> rename libavcodec/{ => aac}/aacenc_utils.h (100%)
> rename libavcodec/{ => aac}/aacencdsp.h (100%)
> rename libavcodec/{ => aac}/aacenctab.c (100%)
> rename libavcodec/{ => aac}/aacenctab.h (99%)
> rename libavcodec/{ => aac}/aacpsy.c (99%)
> rename libavcodec/{ => aac}/aactab.c (99%)
> rename libavcodec/{ => aac}/aactab.h (100%)
seems to break:
make fate
tests/checkasm/aacencdsp.c:25:10: fatal error: libavcodec/aacenc_utils.h: No such file or directory
25 | #include "libavcodec/aacenc_utils.h"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [ffbuild/common.mak:81: tests/checkasm/aacencdsp.o] Error 1
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
There will always be a question for which you do not know the correct answer.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-03-02 1:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 13:54 Lynne
2025-02-28 14:50 ` [FFmpeg-devel] [PATCH] aac: move SBR code to libavcodec/aac Lynne
2025-03-02 1:43 ` Michael Niedermayer
2025-03-02 1:54 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250302015452.GB4991@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git