From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTPS id 4DF5A4B9AA
	for <ffmpegdev@gitmailbox.com>; Sun,  2 Mar 2025 01:43:24 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AE1D468E2B7;
	Sun,  2 Mar 2025 03:43:20 +0200 (EET)
Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net
 [217.70.183.198])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 44E9868E0EF
 for <ffmpeg-devel@ffmpeg.org>; Sun,  2 Mar 2025 03:43:14 +0200 (EET)
Received: by mail.gandi.net (Postfix) with ESMTPSA id 2FC6243288
 for <ffmpeg-devel@ffmpeg.org>; Sun,  2 Mar 2025 01:43:12 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
 s=gm1; t=1740879793;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=1KSE2mQG0UoSxS86effZ1VbXdtzs8vwEy9DIWks6330=;
 b=PoWHeUGxWL7G4iXxPjSjWYRtWsNH2/MgiQEuklnu5O4FfhDANYOVMXzDip/Eh7Q+lvUw7T
 bdwPzN8nDja8+oagqeMeUwwmOXkzXlRGX4GJmJsz5J2bSFTBINtjWnBe3fZZsYddfOWBHQ
 p5a/YoN2MNMr31JUxPgiBhXi4KyWBUl2TFzsB39+RC3yZZE+ZJWsSTh4DTuzKXYStvID+S
 QlNAbjKigujJ99vHjlwTCggqO5LHHJZ8HlMQD/4nHwdEHBU2wM0BQHWgp4TY5biGFaKReZ
 GIgXFSfyztLcRTpOYqtdkNUCke3zxzQ9D4txw8T8+l5bxDxmeg7M9h4O3CI40Q==
Date: Sun, 2 Mar 2025 02:43:12 +0100
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20250302014312.GA4991@pb2>
References: <20250228135445.101947-1-dev@lynne.ee>
 <20250228145102.110763-1-dev@lynne.ee>
MIME-Version: 1.0
In-Reply-To: <20250228145102.110763-1-dev@lynne.ee>
X-GND-State: clean
X-GND-Score: -70
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdelgeeludcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH] aac: move SBR code to libavcodec/aac
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============6298163702177019079=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250302014312.GA4991@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>


--===============6298163702177019079==
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="uI6Vl0RWkJC1NV0y"
Content-Disposition: inline


--uI6Vl0RWkJC1NV0y
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 28, 2025 at 03:50:39PM +0100, Lynne wrote:
> ---
>  libavcodec/Makefile                            | 8 --------
>  libavcodec/aac/Makefile                        | 9 +++++++++
>  libavcodec/{ =3D> aac}/aac_defines.h             | 0
>  libavcodec/aac/aacdec.c                        | 4 ++--
>  libavcodec/aac/aacdec_fixed.c                  | 4 ++--
>  libavcodec/aac/aacdec_float.c                  | 4 ++--
>  libavcodec/aac/aacdec_tab.c                    | 2 +-
>  libavcodec/aac/aacdec_usac.c                   | 2 +-
>  libavcodec/{ =3D> aac}/aacps.c                   | 0
>  libavcodec/{ =3D> aac}/aacps.h                   | 2 +-
>  libavcodec/{ =3D> aac}/aacps_common.c            | 2 +-
>  libavcodec/{ =3D> aac}/aacps_fixed.c             | 0
>  libavcodec/{ =3D> aac}/aacps_fixed_tablegen.c    | 0
>  libavcodec/{ =3D> aac}/aacps_fixed_tablegen.h    | 0
>  libavcodec/{ =3D> aac}/aacps_float.c             | 0
>  libavcodec/{ =3D> aac}/aacps_tablegen.c          | 0
>  libavcodec/{ =3D> aac}/aacps_tablegen.h          | 0
>  libavcodec/{ =3D> aac}/aacps_tablegen_template.c | 0
>  libavcodec/{ =3D> aac}/aacpsdata.c               | 0
>  libavcodec/{ =3D> aac}/aacpsdsp.h                | 0
>  libavcodec/{ =3D> aac}/aacpsdsp_fixed.c          | 0
>  libavcodec/{ =3D> aac}/aacpsdsp_float.c          | 0
>  libavcodec/{ =3D> aac}/aacpsdsp_template.c       | 0
>  libavcodec/{ =3D> aac}/aacsbr.c                  | 2 +-
>  libavcodec/{ =3D> aac}/aacsbr.h                  | 4 ++--
>  libavcodec/{ =3D> aac}/aacsbr_fixed.c            | 2 +-
>  libavcodec/{ =3D> aac}/aacsbr_template.c         | 6 +++---
>  libavcodec/{ =3D> aac}/aacsbrdata.h              | 0
>  libavcodec/{ =3D> aac}/sbr.h                     | 0
>  libavcodec/{ =3D> aac}/sbrdsp.c                  | 2 +-
>  libavcodec/{ =3D> aac}/sbrdsp.h                  | 0
>  libavcodec/{ =3D> aac}/sbrdsp_fixed.c            | 2 +-
>  libavcodec/{ =3D> aac}/sbrdsp_template.c         | 0
>  libavcodec/aarch64/aacpsdsp_init_aarch64.c     | 2 +-
>  libavcodec/aarch64/sbrdsp_init_aarch64.c       | 2 +-
>  libavcodec/cbrt_tablegen.h                     | 2 +-
>  libavcodec/x86/aacpsdsp_init.c                 | 2 +-
>  libavcodec/x86/sbrdsp_init.c                   | 2 +-
>  38 files changed, 33 insertions(+), 32 deletions(-)
>  rename libavcodec/{ =3D> aac}/aac_defines.h (100%)
>  rename libavcodec/{ =3D> aac}/aacps.c (100%)
>  rename libavcodec/{ =3D> aac}/aacps.h (99%)
>  rename libavcodec/{ =3D> aac}/aacps_common.c (99%)
>  rename libavcodec/{ =3D> aac}/aacps_fixed.c (100%)
>  rename libavcodec/{ =3D> aac}/aacps_fixed_tablegen.c (100%)
>  rename libavcodec/{ =3D> aac}/aacps_fixed_tablegen.h (100%)
>  rename libavcodec/{ =3D> aac}/aacps_float.c (100%)
>  rename libavcodec/{ =3D> aac}/aacps_tablegen.c (100%)
>  rename libavcodec/{ =3D> aac}/aacps_tablegen.h (100%)
>  rename libavcodec/{ =3D> aac}/aacps_tablegen_template.c (100%)
>  rename libavcodec/{ =3D> aac}/aacpsdata.c (100%)
>  rename libavcodec/{ =3D> aac}/aacpsdsp.h (100%)
>  rename libavcodec/{ =3D> aac}/aacpsdsp_fixed.c (100%)
>  rename libavcodec/{ =3D> aac}/aacpsdsp_float.c (100%)
>  rename libavcodec/{ =3D> aac}/aacpsdsp_template.c (100%)
>  rename libavcodec/{ =3D> aac}/aacsbr.c (99%)
>  rename libavcodec/{ =3D> aac}/aacsbr.h (98%)
>  rename libavcodec/{ =3D> aac}/aacsbr_fixed.c (99%)
>  rename libavcodec/{ =3D> aac}/aacsbr_template.c (99%)
>  rename libavcodec/{ =3D> aac}/aacsbrdata.h (100%)
>  rename libavcodec/{ =3D> aac}/sbr.h (100%)
>  rename libavcodec/{ =3D> aac}/sbrdsp.c (99%)
>  rename libavcodec/{ =3D> aac}/sbrdsp.h (100%)
>  rename libavcodec/{ =3D> aac}/sbrdsp_fixed.c (99%)
>  rename libavcodec/{ =3D> aac}/sbrdsp_template.c (100%)

breaks arm build

src/libavcodec/arm/aacpsdsp_init_arm.c:25:10: fatal error: libavcodec/aacps=
dsp.h: No such file or directory
 #include "libavcodec/aacpsdsp.h"
          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
src/libavcodec/arm/sbrdsp_init_arm.c:24:10: fatal error: libavcodec/sbrdsp.=
h: No such file or directory
 #include "libavcodec/sbrdsp.h"
          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [src/ffbuild/common.mak:81: libavcodec/arm/aacpsdsp_init_arm.o] E=
rror 1
make: *** Waiting for unfinished jobs....
make: *** [src/ffbuild/common.mak:81: libavcodec/arm/sbrdsp_init_arm.o] Err=
or 1

thx

[...]
--=20
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answe=
r.

--uI6Vl0RWkJC1NV0y
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ8O3qAAKCRBhHseHBAsP
q2ULAKCT9I92w4KSSXaCglIhLTzEhrE9PwCfTGy+emb36AIp9nQK8uvPSwF4Ibg=
=3a1g
-----END PGP SIGNATURE-----

--uI6Vl0RWkJC1NV0y--

--===============6298163702177019079==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

--===============6298163702177019079==--