From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] aac: move SBR code to libavcodec/aac
Date: Sun, 2 Mar 2025 02:43:12 +0100
Message-ID: <20250302014312.GA4991@pb2> (raw)
In-Reply-To: <20250228145102.110763-1-dev@lynne.ee>
[-- Attachment #1.1: Type: text/plain, Size: 4481 bytes --]
On Fri, Feb 28, 2025 at 03:50:39PM +0100, Lynne wrote:
> ---
> libavcodec/Makefile | 8 --------
> libavcodec/aac/Makefile | 9 +++++++++
> libavcodec/{ => aac}/aac_defines.h | 0
> libavcodec/aac/aacdec.c | 4 ++--
> libavcodec/aac/aacdec_fixed.c | 4 ++--
> libavcodec/aac/aacdec_float.c | 4 ++--
> libavcodec/aac/aacdec_tab.c | 2 +-
> libavcodec/aac/aacdec_usac.c | 2 +-
> libavcodec/{ => aac}/aacps.c | 0
> libavcodec/{ => aac}/aacps.h | 2 +-
> libavcodec/{ => aac}/aacps_common.c | 2 +-
> libavcodec/{ => aac}/aacps_fixed.c | 0
> libavcodec/{ => aac}/aacps_fixed_tablegen.c | 0
> libavcodec/{ => aac}/aacps_fixed_tablegen.h | 0
> libavcodec/{ => aac}/aacps_float.c | 0
> libavcodec/{ => aac}/aacps_tablegen.c | 0
> libavcodec/{ => aac}/aacps_tablegen.h | 0
> libavcodec/{ => aac}/aacps_tablegen_template.c | 0
> libavcodec/{ => aac}/aacpsdata.c | 0
> libavcodec/{ => aac}/aacpsdsp.h | 0
> libavcodec/{ => aac}/aacpsdsp_fixed.c | 0
> libavcodec/{ => aac}/aacpsdsp_float.c | 0
> libavcodec/{ => aac}/aacpsdsp_template.c | 0
> libavcodec/{ => aac}/aacsbr.c | 2 +-
> libavcodec/{ => aac}/aacsbr.h | 4 ++--
> libavcodec/{ => aac}/aacsbr_fixed.c | 2 +-
> libavcodec/{ => aac}/aacsbr_template.c | 6 +++---
> libavcodec/{ => aac}/aacsbrdata.h | 0
> libavcodec/{ => aac}/sbr.h | 0
> libavcodec/{ => aac}/sbrdsp.c | 2 +-
> libavcodec/{ => aac}/sbrdsp.h | 0
> libavcodec/{ => aac}/sbrdsp_fixed.c | 2 +-
> libavcodec/{ => aac}/sbrdsp_template.c | 0
> libavcodec/aarch64/aacpsdsp_init_aarch64.c | 2 +-
> libavcodec/aarch64/sbrdsp_init_aarch64.c | 2 +-
> libavcodec/cbrt_tablegen.h | 2 +-
> libavcodec/x86/aacpsdsp_init.c | 2 +-
> libavcodec/x86/sbrdsp_init.c | 2 +-
> 38 files changed, 33 insertions(+), 32 deletions(-)
> rename libavcodec/{ => aac}/aac_defines.h (100%)
> rename libavcodec/{ => aac}/aacps.c (100%)
> rename libavcodec/{ => aac}/aacps.h (99%)
> rename libavcodec/{ => aac}/aacps_common.c (99%)
> rename libavcodec/{ => aac}/aacps_fixed.c (100%)
> rename libavcodec/{ => aac}/aacps_fixed_tablegen.c (100%)
> rename libavcodec/{ => aac}/aacps_fixed_tablegen.h (100%)
> rename libavcodec/{ => aac}/aacps_float.c (100%)
> rename libavcodec/{ => aac}/aacps_tablegen.c (100%)
> rename libavcodec/{ => aac}/aacps_tablegen.h (100%)
> rename libavcodec/{ => aac}/aacps_tablegen_template.c (100%)
> rename libavcodec/{ => aac}/aacpsdata.c (100%)
> rename libavcodec/{ => aac}/aacpsdsp.h (100%)
> rename libavcodec/{ => aac}/aacpsdsp_fixed.c (100%)
> rename libavcodec/{ => aac}/aacpsdsp_float.c (100%)
> rename libavcodec/{ => aac}/aacpsdsp_template.c (100%)
> rename libavcodec/{ => aac}/aacsbr.c (99%)
> rename libavcodec/{ => aac}/aacsbr.h (98%)
> rename libavcodec/{ => aac}/aacsbr_fixed.c (99%)
> rename libavcodec/{ => aac}/aacsbr_template.c (99%)
> rename libavcodec/{ => aac}/aacsbrdata.h (100%)
> rename libavcodec/{ => aac}/sbr.h (100%)
> rename libavcodec/{ => aac}/sbrdsp.c (99%)
> rename libavcodec/{ => aac}/sbrdsp.h (100%)
> rename libavcodec/{ => aac}/sbrdsp_fixed.c (99%)
> rename libavcodec/{ => aac}/sbrdsp_template.c (100%)
breaks arm build
src/libavcodec/arm/aacpsdsp_init_arm.c:25:10: fatal error: libavcodec/aacpsdsp.h: No such file or directory
#include "libavcodec/aacpsdsp.h"
^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
src/libavcodec/arm/sbrdsp_init_arm.c:24:10: fatal error: libavcodec/sbrdsp.h: No such file or directory
#include "libavcodec/sbrdsp.h"
^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [src/ffbuild/common.mak:81: libavcodec/arm/aacpsdsp_init_arm.o] Error 1
make: *** Waiting for unfinished jobs....
make: *** [src/ffbuild/common.mak:81: libavcodec/arm/sbrdsp_init_arm.o] Error 1
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
There will always be a question for which you do not know the correct answer.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-03-02 1:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 13:54 [FFmpeg-devel] [PATCH v2] aacenc: move encoder to libavcodec/aac/ Lynne
2025-02-28 14:50 ` [FFmpeg-devel] [PATCH] aac: move SBR code to libavcodec/aac Lynne
2025-03-02 1:43 ` Michael Niedermayer [this message]
2025-03-02 1:54 ` [FFmpeg-devel] [PATCH v2] aacenc: move encoder to libavcodec/aac/ Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250302014312.GA4991@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git