From: Krzysztof Pyrkosz via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Krzysztof Pyrkosz <ffmpeg@szaka.eu>
Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/aarch64/ac3dsp_neon.S: Optimize ac3_extract_exponents
Date: Fri, 28 Feb 2025 22:21:48 +0100
Message-ID: <20250228212148.11560-2-ffmpeg@szaka.eu> (raw)
Before and after:
A78
ac3_extract_exponents_n512_neon: 503.2 ( 3.36x)
ac3_extract_exponents_n3072_neon: 2986.2 ( 3.35x)
ac3_extract_exponents_n512_neon: 211.2 ( 8.02x)
ac3_extract_exponents_n3072_neon: 1251.5 ( 8.00x)
A72
ac3_extract_exponents_n512_neon: 964.7 ( 2.39x)
ac3_extract_exponents_n3072_neon: 5434.5 ( 2.47x)
ac3_extract_exponents_n512_neon: 465.6 ( 4.87x)
ac3_extract_exponents_n3072_neon: 2696.3 ( 4.97x)
---
This version handles 16 ints in one go and consolidates separate
extractions and writes into one. I assume the length of the input is a
multiple of 16 (there are no constraints defined in the template file),
but the tests are passing.
Krzysztof
libavcodec/aarch64/ac3dsp_neon.S | 25 ++++++++++++++++++-------
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/libavcodec/aarch64/ac3dsp_neon.S b/libavcodec/aarch64/ac3dsp_neon.S
index 7e97cc39f7..b2ac9edc55 100644
--- a/libavcodec/aarch64/ac3dsp_neon.S
+++ b/libavcodec/aarch64/ac3dsp_neon.S
@@ -38,15 +38,26 @@ function ff_ac3_exponent_min_neon, export=1
endfunc
function ff_ac3_extract_exponents_neon, export=1
- movi v1.4s, #8
-1: ld1 {v0.4s}, [x1], #16
+ movi v4.16b, #8
+1: ld1 {v0.4s - v3.4s}, [x1], #64
+ subs w2, w2, #16
abs v0.4s, v0.4s
+ abs v1.4s, v1.4s
+ abs v2.4s, v2.4s
+ abs v3.4s, v3.4s
+
clz v0.4s, v0.4s
- sub v0.4s, v0.4s, v1.4s
- xtn v0.4h, v0.4s
- xtn v0.8b, v0.8h
- st1 {v0.s}[0], [x0], #4
- subs w2, w2, #4
+ clz v1.4s, v1.4s
+ clz v2.4s, v2.4s
+ clz v3.4s, v3.4s
+
+ uzp1 v0.8h, v0.8h, v1.8h
+ uzp1 v2.8h, v2.8h, v3.8h
+ uzp1 v0.16b, v0.16b, v2.16b
+ sub v0.16b, v0.16b, v4.16b
+
+ st1 {v0.16b}, [x0], #16
+
b.gt 1b
ret
endfunc
--
2.47.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2025-02-28 21:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 21:21 Krzysztof Pyrkosz via ffmpeg-devel [this message]
2025-02-28 21:21 ` [FFmpeg-devel] [PATCH 2/2] avcodec/aarch64/ac3dsp_neon.S: Optimize ac3_sum_square_butterfly_int32_neon Krzysztof Pyrkosz via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228212148.11560-2-ffmpeg@szaka.eu \
--to=ffmpeg-devel@ffmpeg.org \
--cc=ffmpeg@szaka.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git