From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 33BE04DA9D for ; Fri, 28 Feb 2025 03:22:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6049C68DBEF; Fri, 28 Feb 2025 05:22:36 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1BF7968DA15 for ; Fri, 28 Feb 2025 05:22:30 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 712CB42D83 for ; Fri, 28 Feb 2025 03:22:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1740712949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oCs9KOLV1Tw7f4La+3xENBtwvJCXb9uc6h494get1mU=; b=mReUCQ03/OSQbJMaFrI1xZYzqMLd/WnokSKkFlok6isMX3SPmi8mAgAjBd3AFNVYXtTCY4 M1maY3P908aT2N0lWZnQ0SI8cP+Ye0CFPlp2rZzesSMNOfQexhW9qRBVMN+BIbYOxFse6d vP6iS5WKLt18uf6KhagvSlZ2128vFOPYM/weTLUVjgYQEn2g0doVU94/pKan8U0QGGsotq kZM/5v9f3od/mvj+JGGqWUQmLMY5V8rQtF6MymJn/OoymkJuVBFONmdi8GHQpEO1ZceSsX uASASlSmPwGp3dSJLdkAdEGp1IP30Rg/Aq0rpkIxJ0guLZ3MM6I67uQtx8AR9w== Date: Fri, 28 Feb 2025 04:22:28 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250228032228.GS4991@pb2> References: <20250227011054.3028508-1-michael@niedermayer.cc> <6D690464-DE4D-44B1-B851-44C855005FE7@gmail.com> <20250227231432.GL4991@pb2> <1F96354D-B189-4A6D-82FD-81DD1C0016B1@gmail.com> MIME-Version: 1.0 In-Reply-To: <1F96354D-B189-4A6D-82FD-81DD1C0016B1@gmail.com> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekledvlecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1614804463315047952==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1614804463315047952== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HDfwTeZjuKTehLZn" Content-Disposition: inline --HDfwTeZjuKTehLZn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 28, 2025 at 12:25:43AM +0100, epirat07@gmail.com wrote: >=20 >=20 > On 28 Feb 2025, at 0:14, Michael Niedermayer wrote: >=20 > > Hi > > > > On Thu, Feb 27, 2025 at 11:46:54PM +0100, epirat07@gmail.com wrote: > >> On 27 Feb 2025, at 2:10, Michael Niedermayer wrote: > >> > >>> Signed-off-by: Michael Niedermayer > >>> --- > >>> doc/developer.texi | 11 +++++------ > >>> 1 file changed, 5 insertions(+), 6 deletions(-) > >>> > >>> diff --git a/doc/developer.texi b/doc/developer.texi > >>> index a1bfe180c9b..6a753f99da6 100644 > >>> --- a/doc/developer.texi > >>> +++ b/doc/developer.texi > >>> @@ -179,18 +179,17 @@ int fields =3D ilace ? 2 : 1; > >>> @end example > >>> > >>> @item > >>> -No braces around single-line blocks: > >>> +No braces around single-line blocks, unless they are followed by an = else (to keep future patches cleaner) > >>> > >> > >> I agree with this, however people in the past pointed it out when new = code did this, IIRC. > > > > yes, i know, ive seen it in both directions for this one. > > > > > >> > >> So if we merge this, people should stop flagging this in reviews, else= its frustrating > >> for new contributors following the documentation and then getting cont= radicting reviews. > > > > I think as long as its in a style guide, the author of a patch can easi= ly > > point the reviewer to the guide and that should resolve it immedeatly > > > > will apply > > >=20 > Sounds good. >=20 > Can you maybe check the styling issue at some point? > I had updated the CSS and locally I get the right classes assigned to the > codeblocks and the CSS styling them to hint which of them are good and wh= ich > bad examples. >=20 > But on the website deployed version its not working. there seem to be 2 style.min.css one in ffmpeg and one generated by Makefile in ffmpeg-web but only one on the website, this may be slightly suboptimal ive simply copied the one from ffmpeg over on the server now, backup in style.min.css.bak2 if it breaks something and timo wants to undo also that change, did change the look of the frontpage, we have a bigger download button now and some empty space between entries in "October 30th, 2016, Results: Summer Of Code 2016." some html/css person, should look at this i think. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once" - "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew .= =2E." --HDfwTeZjuKTehLZn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ8Er8QAKCRBhHseHBAsP q92sAKCIzjVHYK4x8TiYixkiIGnkfXuvAwCffcWvplpn4DWKzE80T8v50CECeJ8= =5oTU -----END PGP SIGNATURE----- --HDfwTeZjuKTehLZn-- --===============1614804463315047952== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1614804463315047952==--