Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 2665 bytes --]

On Fri, Feb 28, 2025 at 12:25:43AM +0100, epirat07@gmail.com wrote:
> 
> 
> On 28 Feb 2025, at 0:14, Michael Niedermayer wrote:
> 
> > Hi
> >
> > On Thu, Feb 27, 2025 at 11:46:54PM +0100, epirat07@gmail.com wrote:
> >> On 27 Feb 2025, at 2:10, Michael Niedermayer wrote:
> >>
> >>> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> >>> ---
> >>>  doc/developer.texi | 11 +++++------
> >>>  1 file changed, 5 insertions(+), 6 deletions(-)
> >>>
> >>> diff --git a/doc/developer.texi b/doc/developer.texi
> >>> index a1bfe180c9b..6a753f99da6 100644
> >>> --- a/doc/developer.texi
> >>> +++ b/doc/developer.texi
> >>> @@ -179,18 +179,17 @@ int fields = ilace ? 2 : 1;
> >>>  @end example
> >>>
> >>>  @item
> >>> -No braces around single-line blocks:
> >>> +No braces around single-line blocks, unless they are followed by an else (to keep future patches cleaner)
> >>>
> >>
> >> I agree with this, however people in the past pointed it out when new code did this, IIRC.
> >
> > yes, i know, ive seen it in both directions for this one.
> >
> >
> >>
> >> So if we merge this, people should stop flagging this in reviews, else its frustrating
> >> for new contributors following the documentation and then getting contradicting reviews.
> >
> > I think as long as its in a style guide, the author of a patch can easily
> > point the reviewer to the guide and that should resolve it immedeatly
> >
> > will apply
> >
> 
> Sounds good.
> 
> Can you maybe check the styling issue at some point?
> I had updated the CSS and locally I get the right classes assigned to the
> codeblocks and the CSS styling them to hint which of them are good and which
> bad examples.
> 
> But on the website deployed version its not working.

there seem to be 2 style.min.css
one in ffmpeg and one generated by Makefile in ffmpeg-web
but only one on the website, this may be slightly suboptimal

ive simply copied the one from ffmpeg over on the server now, backup in
style.min.css.bak2 if it breaks something and timo wants to undo

also that change, did change the look of the frontpage, we have a bigger
download button now and some empty space
between entries in "October 30th, 2016, Results: Summer Of Code 2016."

some html/css person, should look at this i think.

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".