From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id C82F74DA8C for ; Fri, 28 Feb 2025 02:33:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7B5C968DD5A; Fri, 28 Feb 2025 04:33:27 +0200 (EET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8001768DBC2 for ; Fri, 28 Feb 2025 04:33:20 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id D68454438F for ; Fri, 28 Feb 2025 02:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1740710000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BATPEA68HpRdAmP/hQFbdx8MuT7Nvcs7MbX3VCvdU08=; b=D8jgIqJIA3jkkYlH4VgPEA5bkG0nyVg9hkzC2PtOIvTuiuiMTqWSP4ARJcIiyU1VFGDjYi wzfqk5sqfbJhA9gJ5YSzLOaxQwLWIjVSBx3pgOH4mvySB/KIiU7S88do7n0WXhm8DYraFV u6r2EN9YsQ0VEdvd+n/2YCLdGeoYBs9XVbQ5xPaUGacEEDBpJpbyNVbyxx7M4ItAjDfWmW ftFr3Q6SebsMaFH7TBb2U5gwTUW2/E7nGmS86s0jlTwepUaMvdHOX8kutPlG4Ul7XMO1/G 7TJnU5WmhQN22H88Lt5nnoWrdJk2eYf8PyEogT208rUh8DWQGgC013jEkNTphQ== Date: Fri, 28 Feb 2025 03:33:18 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250228023318.GR4991@pb2> References: <20250227011054.3028508-1-michael@niedermayer.cc> <6527f199-5abd-40ed-8b19-b7a6b8bd40cd@lynne.ee> MIME-Version: 1.0 In-Reply-To: <6527f199-5abd-40ed-8b19-b7a6b8bd40cd@lynne.ee> X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekledukecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3723378088477130684==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3723378088477130684== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jxZ3M3coGUDJTJtE" Content-Disposition: inline --jxZ3M3coGUDJTJtE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 28, 2025 at 03:25:06AM +0100, Lynne wrote: > On 27/02/2025 02:10, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > doc/developer.texi | 11 +++++------ > > 1 file changed, 5 insertions(+), 6 deletions(-) > >=20 > > diff --git a/doc/developer.texi b/doc/developer.texi > > index a1bfe180c9b..6a753f99da6 100644 > > --- a/doc/developer.texi > > +++ b/doc/developer.texi > > @@ -179,18 +179,17 @@ int fields =3D ilace ? 2 : 1; > > @end example > > @item > > -No braces around single-line blocks: > > +No braces around single-line blocks, unless they are followed by an el= se (to keep future patches cleaner) > > @example c, good > > // Good > > -if (bits_pixel =3D=3D 24) > > +if (bits_pixel =3D=3D 24) @{ > > avctx->pix_fmt =3D AV_PIX_FMT_BGR24; > > -else if (bits_pixel =3D=3D 8) > > +@} else if (bits_pixel =3D=3D 8) @{ > > avctx->pix_fmt =3D AV_PIX_FMT_GRAY8; > > -else @{ > > - av_log(avctx, AV_LOG_ERROR, "Invalid pixel format.\n"); > > +@} else > > return AVERROR_INVALIDDATA; > > -@} > > + > > @end example > > @item >=20 > Strongly objecting to this patch. It's all over our codebase, and I like = it. > Literally everywhere you look. > If future patches need to add more under the branch, then it only needs to > be done once. >=20 > Such fundamental changes need more than a single patch hastily accepted, = and > should involve the community as a whole, I believe. Its not a change, look at tools/patcheck or try: + if(this) + that + else + nothat + patcheck reports: missing } prior to else patcheck.stdout:11:+ else missing whitespace between keyword and ( (feel free to ignore) patcheck.stdout:9:+ if(this) [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If one takes all money from those who grow wealth and gives it to those who do not grow wealth, 10 years later, almost the same people who where wealthy will be wealthy again, the same people who where poor will be poor again. --jxZ3M3coGUDJTJtE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ8EgbgAKCRBhHseHBAsP q3DkAJ4422fzMnOc+YuKBLiryOKcwQXk7wCghvOq8SJgjgoswX9CObXwpxFiaAM= =GnR5 -----END PGP SIGNATURE----- --jxZ3M3coGUDJTJtE-- --===============3723378088477130684== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3723378088477130684==--