From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2AB2D4DA67 for ; Fri, 28 Feb 2025 02:29:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 500FD68DD1E; Fri, 28 Feb 2025 04:29:24 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3C5A568DBAB for ; Fri, 28 Feb 2025 04:29:17 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 704A220480 for ; Fri, 28 Feb 2025 02:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1740709756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L5+MkpKOhOmVqmvVKAifSNK2n7kKTCnaIX0UnTsJQ8Q=; b=cDV5oenivNgCGOYPo5Np8/WNIGgI+e6z1koZAj0O57suK/V0bfgp5ziDMPyGo+dlxsW1q6 zb4+rxa/ibB91Tj1IlZBYD5+5ToTFyGTRkmmRtZfCc0YG1y2txeeHKp2Kn6kYmqJQ6jIpO 9zFYDfDJB/Rtwus4r1r74o4j/y07EKou+Mi0VtiUiURrXfGsEmh35f39AQiTZNjbZX3NJp VB6HZ5I68FnRCTGBL84yuj+DgTy8SwGZ38wByDes5LgpU8vC5HdoY42cLypOGpW3tokomw G/FqdWkpJGRfQkj5N/6kEFnqVBmVMYKBfG12ajIBtBHg2/AYedBMrd/DfVNlAQ== Date: Fri, 28 Feb 2025 03:29:15 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250228022915.GQ4991@pb2> References: <89d538cab47c517b35ecaccb563e14334c9f9927.1740664900.git.ffmpegagent@gmail.com> <20250228012321.GP4991@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -90 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekledujecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdluddtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/8] ffprobe/avtextformat: Rename and move writer functions and options X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4070476957546214607==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4070476957546214607== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dBjQ/HbU8u0+xRDC" Content-Disposition: inline --dBjQ/HbU8u0+xRDC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 28, 2025 at 01:47:05AM +0000, Soft Works wrote: >=20 >=20 > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of Soft > > Works > > Sent: Freitag, 28. Februar 2025 02:31 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH 2/8] ffprobe/avtextformat: Rename and > > move writer functions and options > >=20 > >=20 > >=20 > > > -----Original Message----- > > > From: ffmpeg-devel On Behalf Of > > > Michael Niedermayer > > > Sent: Freitag, 28. Februar 2025 02:23 > > > To: FFmpeg development discussions and patches > devel@ffmpeg.org> > > > Subject: Re: [FFmpeg-devel] [PATCH 2/8] ffprobe/avtextformat: Rename > > and > > > move writer functions and options > > > > > > On Thu, Feb 27, 2025 at 02:01:34PM +0000, softworkz wrote: > > > > From: softworkz > > > > > > > > Signed-off-by: softworkz > > > > --- > > > > fftools/ffprobe.c | 910 ++++++------------------- > > -- > > > - > > > > libavutil/Makefile | 1 + > > > > libavutil/avtextformat.h | 50 ++ > > > > libavutil/textformat/avtextformat.c | 620 +++++++++++++++++++ > > > > 4 files changed, 848 insertions(+), 733 deletions(-) > > > > create mode 100644 libavutil/textformat/avtextformat.c > > > > > > this and patch 1 crash > > > > > > =3D=3D1574970=3D=3D Invalid read of size 1 > > > =3D=3D1574970=3D=3D at 0x483EF46: strlen (in /usr/lib/x86_64-linux- > > > gnu/valgrind/vgpreload_memcheck-amd64-linux.so) > > > =3D=3D1574970=3D=3D by 0x7683D14: __vfprintf_internal (vfprintf- > > > internal.c:1688) > > > =3D=3D1574970=3D=3D by 0x7696F99: __vsnprintf_internal (vsnprintf.= c:114) > > > =3D=3D1574970=3D=3D by 0x1239AA1: av_vbprintf (in ffmpeg/ffprobe_g) > > > =3D=3D1574970=3D=3D by 0x1256473: av_log_default_callback (in > > > ffmpeg/ffprobe_g) > > > =3D=3D1574970=3D=3D by 0x1256162: av_log (in ffmpeg/ffprobe_g) > > > =3D=3D1574970=3D=3D by 0x125CB4B: av_opt_set_defaults2 (in > > ffmpeg/ffprobe_g) > > > =3D=3D1574970=3D=3D by 0x127611C: avtext_context_open (in ffmpeg/f= fprobe_g) > > > =3D=3D1574970=3D=3D by 0x2F9672: main (in ffmpeg/ffprobe_g) > > > =3D=3D1574970=3D=3D Address 0xffffffff is not stack'd, malloc'd or (= recently) > > > free'd > > > =3D=3D1574970=3D=3D > > > =3D=3D1574970=3D=3D > > > =3D=3D1574970=3D=3D Process terminating with default action of signal= 11 > > > (SIGSEGV) > > > =3D=3D1574970=3D=3D Access not within mapped region at address 0xFFF= FFFFF > > > =3D=3D1574970=3D=3D at 0x483EF46: strlen (in /usr/lib/x86_64-linux- > > > gnu/valgrind/vgpreload_memcheck-amd64-linux.so) > > > =3D=3D1574970=3D=3D by 0x7683D14: __vfprintf_internal (vfprintf- > > > internal.c:1688) > > > =3D=3D1574970=3D=3D by 0x7696F99: __vsnprintf_internal (vsnprintf.= c:114) > > > =3D=3D1574970=3D=3D by 0x1239AA1: av_vbprintf (in ffmpeg/ffprobe_g) > > > =3D=3D1574970=3D=3D by 0x1256473: av_log_default_callback (in > > > ffmpeg/ffprobe_g) > > > =3D=3D1574970=3D=3D by 0x1256162: av_log (in ffmpeg/ffprobe_g) > > > =3D=3D1574970=3D=3D by 0x125CB4B: av_opt_set_defaults2 (in > > ffmpeg/ffprobe_g) > > > =3D=3D1574970=3D=3D by 0x127611C: avtext_context_open (in ffmpeg/f= fprobe_g) > > > =3D=3D1574970=3D=3D by 0x2F9672: main (in ffmpeg/ffprobe_g) > > > =3D=3D1574970=3D=3D If you believe this happened as a result of a st= ack > > > =3D=3D1574970=3D=3D overflow in your program's main thread (unlikely= but > > > =3D=3D1574970=3D=3D possible), you can try to increase the size of t= he > > > =3D=3D1574970=3D=3D main thread stack using the --main-stacksize=3D = flag. > > > =3D=3D1574970=3D=3D The main thread stack size used in this run was = 8388608. > > > > > > testcase: ./ffprobe_g -v 99 ~/tickets/3679/wgetmjpegdump > > > > > > tell me if this file is not in the ticket and ill send it to you > >=20 > > Hi Michael, > >=20 > > only patch 8/8 is expected to work. Since this is a RFC for the moment, > > I spared the time for making sure that every single commit builds. > > (please see cover letter notes in 0/8) > >=20 > > Once the direction is clear, I'll prepare a patchset with all commits > > working of course. ok > >=20 > > Thanks >=20 > Did you try 8/8 - does it pass for you? It's fine locally on x64 Linux, o= n AzDevops Linux x64 and on Patchwork andriy/make_fate_x86. > But what bothers me a bit is that it failed on the Chinese CPU system. i found the issue in 1+2 as a result of bisecting, so no the whole set crashed thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The difference between a dictatorship and a democracy is that every 4 years the population together is allowed to provide 1 bit of input to the governm= ent. --dBjQ/HbU8u0+xRDC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ8EfeAAKCRBhHseHBAsP qxgAAKCGxfQtrZS2218yyqVuBkG3ECJI2ACfXexGqZTH5/JkObObtztQ7Kn43I0= =wu6j -----END PGP SIGNATURE----- --dBjQ/HbU8u0+xRDC-- --===============4070476957546214607== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4070476957546214607==--