From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D91304DA30 for ; Fri, 28 Feb 2025 00:59:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9E1A268DBCE; Fri, 28 Feb 2025 02:59:07 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0D81468D80B for ; Fri, 28 Feb 2025 02:59:01 +0200 (EET) Received: by mail.gandi.net (Postfix) with ESMTPSA id 7B83B4418B for ; Fri, 28 Feb 2025 00:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1740704340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bxHeKuYxdSqJrz520lTvryvNScu7sUPyqfY94UWJxfI=; b=b5LBftDc8kKrq8Cgzm5kKNwK1KmE3T3w9zdog4Jfi2ZEdZLMRqxGNo6/1hs0E1dv8A56va SxwrzvrfSLg2IWW5i6QT8I4xTUFklzjfSIw46nL5uFzFbkFymkdq5EDKKC/pEhQPPDZ2Fp XvDPsmxhkjsDEmVwMCs3DT3+SNTR+SiVx3c1pJ4Sc9v13Oc8dJ2jybhKMoTs/YxDaVMSDt V3th9xFCbhvgOK0mIE0zDdE7S44yy2I0xkSQrZAiLjSwUKIioF98Nn8koHxnzj3QP94eJ4 7dpmofjavlYjk+z67vmwb6c4h8r2puqZD8Mtrz+2ziS3ax4vfdavAusKmPAOxQ== Date: Fri, 28 Feb 2025 01:58:59 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250228005859.GM4991@pb2> References: <20250227011054.3028508-1-michael@niedermayer.cc> <6D690464-DE4D-44B1-B851-44C855005FE7@gmail.com> <96fd7a0f-d755-4726-931c-c317a5f6d541@gmail.com> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekkeelkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepleekgefgffeiudefjeeuffejudehtddtudeltdehveevvedtieeulefhtdeutdeknecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8097083747140868417==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8097083747140868417== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TX+jBbfNa6Yyh7Uj" Content-Disposition: inline --TX+jBbfNa6Yyh7Uj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 27, 2025 at 07:40:14PM -0500, Devin Heitmueller wrote: > On Thu, Feb 27, 2025 at 5:57=E2=80=AFPM James Almer w= rote: > > > would loooove a format defining script with a prehook that formats yo= ur > > > patches before sending <3 > > > > That can be done automatically as one of the many jobs CI runs once we > > move to forgejo/gitlab. Same with every other check in patcheck. >=20 > In my opinion, developers generally want to clean up style issues > prior to submission. The problem with doing it in a CI job is that it > will just tell you after the fact that your patch didn't meet the > coding standards and you have to revise and resubmit. The alternative > is for the CI job to "fix" the patch to conform, which people > generally don't want because what they submitted is different than > what gets committed. >=20 > For what it's worth, with the Linux Kernel we solved this years ago > with a "checkpatch.pl" which developers can run prior to committing. > Thus I could quickly run checkpatch.pl, fix anything it complains > about, and then run git commit and be confident that it conforms to > the standard. Personally I prefer this approach as it lets me fix the > patches prior to submission, and the CI system isn't changing things > without my knowledge. we have tools/patcheck :) I have the feeling we started forgeting about it And I also think changing submissions in CI is problematic. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He who knows, does not speak. He who speaks, does not know. -- Lao Tsu --TX+jBbfNa6Yyh7Uj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ8EKUAAKCRBhHseHBAsP qwncAJwM1ZYa9G3MztAByMlzeAoio0b0NwCeI5368/2fFU3S1/Vokwsy+chrZwE= =x7ik -----END PGP SIGNATURE----- --TX+jBbfNa6Yyh7Uj-- --===============8097083747140868417== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8097083747140868417==--