Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule
Date: Fri, 28 Feb 2025 01:58:59 +0100
Message-ID: <20250228005859.GM4991@pb2> (raw)
In-Reply-To: <CAHGibzEtxPuUkbpaLbVv0dd2CYZi2bMvtR4CJB_uS=5bVA7+CA@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1626 bytes --]

On Thu, Feb 27, 2025 at 07:40:14PM -0500, Devin Heitmueller wrote:
> On Thu, Feb 27, 2025 at 5:57 PM James Almer <jamrial@gmail.com> wrote:
> > > would loooove a format defining script with a prehook that formats your
> > > patches before sending <3
> >
> > That can be done automatically as one of the many jobs CI runs once we
> > move to forgejo/gitlab. Same with every other check in patcheck.
> 
> In my opinion, developers generally want to clean up style issues
> prior to submission.  The problem with doing it in a CI job is that it
> will just tell you after the fact that your patch didn't meet the
> coding standards and you have to revise and resubmit.  The alternative
> is for the CI job to "fix" the patch to conform, which people
> generally don't want because what they submitted is different than
> what gets committed.
> 

> For what it's worth, with the Linux Kernel we solved this years ago
> with a "checkpatch.pl" which developers can run prior to committing.
> Thus I could quickly run checkpatch.pl, fix anything it complains
> about, and then run git commit and be confident that it conforms to
> the standard.  Personally I prefer this approach as it lets me fix the
> patches prior to submission, and the CI system isn't changing things
> without my knowledge.

we have tools/patcheck :)
I have the feeling we started forgeting about it

And I also think changing submissions in CI is problematic.

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".