From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 55E114DA35
for <ffmpegdev@gitmailbox.com>; Thu, 27 Feb 2025 23:14:44 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 21A3D68DC48;
Fri, 28 Feb 2025 01:14:41 +0200 (EET)
Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net
[217.70.183.194])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3391D68C1FD
for <ffmpeg-devel@ffmpeg.org>; Fri, 28 Feb 2025 01:14:34 +0200 (EET)
Received: by mail.gandi.net (Postfix) with ESMTPSA id 828B043150
for <ffmpeg-devel@ffmpeg.org>; Thu, 27 Feb 2025 23:14:33 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc;
s=gm1; t=1740698073;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=zI6ZD4nGYUiiM49xJqWa33MY8co3Eix3clI+QFcjVv0=;
b=pLeGmQ+vKraC66rI1AlFQ15OO5JuWNJ+iNyiNNQutIRTlIQ42/U/at9HPF/FkErknR1Fh6
G4ICz68Vki1MAfl3j+36s56pn2xgnTYK2iGRWc/VUd3M57flQdizjdk8v0kOR0sFXSS8IA
WCUxe0RRPlcMNqBhpSUKVbHHVPxF7BgX+SV7OXhwhNrAnPGU5RMAokHi15K8473Wddr5y0
TX+HrDl2tg84FSdO3O/97qkD1Sn3qtO++BTWKCW5lDgaHxRo3BRD677b7CufneqsAxuMKg
yM8nlv6iWlP3fLuoiK9FTHQ9AFNWahVZtVCGjF/6e0MB5A7W9T2RCmJ34ka8DQ==
Date: Fri, 28 Feb 2025 00:14:32 +0100
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Message-ID: <20250227231432.GL4991@pb2>
References: <20250227011054.3028508-1-michael@niedermayer.cc>
<6D690464-DE4D-44B1-B851-44C855005FE7@gmail.com>
MIME-Version: 1.0
In-Reply-To: <6D690464-DE4D-44B1-B851-44C855005FE7@gmail.com>
X-GND-State: clean
X-GND-Score: -85
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekkeejjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeijedruddufeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeijedruddufedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh
X-GND-Sasl: michael@niedermayer.cc
Subject: Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: multipart/mixed; boundary="===============8874944147884427981=="
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20250227231432.GL4991@pb2/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
--===============8874944147884427981==
Content-Type: multipart/signed; micalg=pgp-sha512;
protocol="application/pgp-signature"; boundary="EMcoWH1MSvk9yJrz"
Content-Disposition: inline
--EMcoWH1MSvk9yJrz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi
On Thu, Feb 27, 2025 at 11:46:54PM +0100, epirat07@gmail.com wrote:
> On 27 Feb 2025, at 2:10, Michael Niedermayer wrote:
>=20
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> > doc/developer.texi | 11 +++++------
> > 1 file changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/doc/developer.texi b/doc/developer.texi
> > index a1bfe180c9b..6a753f99da6 100644
> > --- a/doc/developer.texi
> > +++ b/doc/developer.texi
> > @@ -179,18 +179,17 @@ int fields =3D ilace ? 2 : 1;
> > @end example
> >
> > @item
> > -No braces around single-line blocks:
> > +No braces around single-line blocks, unless they are followed by an el=
se (to keep future patches cleaner)
> >
>=20
> I agree with this, however people in the past pointed it out when new cod=
e did this, IIRC.
yes, i know, ive seen it in both directions for this one.
>=20
> So if we merge this, people should stop flagging this in reviews, else it=
s frustrating
> for new contributors following the documentation and then getting contrad=
icting reviews.
I think as long as its in a style guide, the author of a patch can easily
point the reviewer to the guide and that should resolve it immedeatly
will apply
thx
[...]
--=20
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
--EMcoWH1MSvk9yJrz
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCZ8Dx1QAKCRBhHseHBAsP
q2BJAJ9D+qlH79a6sZupsQPTQCNoqOXamACdHMSjryV1QTUOsA6mGg8+U1jJ4Fw=
=R4oa
-----END PGP SIGNATURE-----
--EMcoWH1MSvk9yJrz--
--===============8874944147884427981==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--===============8874944147884427981==--