Re: [FFmpeg-devel] [PATCH] doc/developer: Better {} style rule

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1400 bytes --]

Hi

On Thu, Feb 27, 2025 at 11:46:54PM +0100, epirat07@gmail.com wrote:
> On 27 Feb 2025, at 2:10, Michael Niedermayer wrote:
> 
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  doc/developer.texi | 11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> >
> > diff --git a/doc/developer.texi b/doc/developer.texi
> > index a1bfe180c9b..6a753f99da6 100644
> > --- a/doc/developer.texi
> > +++ b/doc/developer.texi
> > @@ -179,18 +179,17 @@ int fields = ilace ? 2 : 1;
> >  @end example
> >
> >  @item
> > -No braces around single-line blocks:
> > +No braces around single-line blocks, unless they are followed by an else (to keep future patches cleaner)
> >
> 
> I agree with this, however people in the past pointed it out when new code did this, IIRC.

yes, i know, ive seen it in both directions for this one.


> 
> So if we merge this, people should stop flagging this in reviews, else its frustrating
> for new contributors following the documentation and then getting contradicting reviews.

I think as long as its in a style guide, the author of a patch can easily
point the reviewer to the guide and that should resolve it immedeatly

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".